From 84be1c5eb67aaaf574caa1f0eaa1b9df35adef9e Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=E4=B8=96=E7=95=8C?= <i@sekai.icu>
Date: Sun, 10 Jul 2022 21:43:21 +0800
Subject: [PATCH] Remove ToString0[T] usage to fix golangci-lint

---
 .golangci.yml              | 52 +++++++-------------------------------
 common/exceptions/error.go |  1 -
 common/exceptions/multi.go |  2 +-
 common/format/fmt.go       | 10 ++++++++
 common/task/task.go        |  2 +-
 5 files changed, 21 insertions(+), 46 deletions(-)

diff --git a/.golangci.yml b/.golangci.yml
index 70f5a22..5505a92 100644
--- a/.golangci.yml
+++ b/.golangci.yml
@@ -1,50 +1,16 @@
-run:
-  timeout: 5m
-
 linters:
-  enable-all: true
-  disable:
-    - errcheck
-    - wrapcheck
-    - varnamelen
-    - stylecheck
-    - nonamedreturns
-    - nlreturn
-    - ireturn
-    - gomnd
-    - exhaustivestruct
-    - ifshort
-    - goerr113
-    - gochecknoglobals
-    - forcetypeassert
-    - exhaustruct
-    - exhaustive
-    - cyclop
-    - containedctx
-    - wsl
-    - nestif
-    - lll
-    - funlen
-    - goconst
-    - godot
-    - gocognit
-    - golint
-    - goimports
-    - nosnakecase
+  disable-all: true
+  enable:
+    - gofumpt
+    - govet
+    - gci
+    - staticcheck
 
 linters-settings:
-  revive:
-    rules:
-      - name: var-naming
-        disabled: true
-  govet:
-    enable-all: true
-    disable:
-      - composites
-      - fieldalignment
-      - shadow
   gci:
     sections:
       - standard
       - prefix(github.com/sagernet/sing)
-      - default
\ No newline at end of file
+      - default
+  staticcheck:
+    go: '1.18'
diff --git a/common/exceptions/error.go b/common/exceptions/error.go
index f0d7399..e71e51d 100644
--- a/common/exceptions/error.go
+++ b/common/exceptions/error.go
@@ -1,4 +1,3 @@
-//nolint:errorlint
 package exceptions
 
 import (
diff --git a/common/exceptions/multi.go b/common/exceptions/multi.go
index 9b79be2..dc1d599 100644
--- a/common/exceptions/multi.go
+++ b/common/exceptions/multi.go
@@ -13,7 +13,7 @@ type multiError struct {
 }
 
 func (e *multiError) Error() string {
-	return "multi error: (" + strings.Join(common.Map(e.errors, F.ToString0[error]), " | ") + ")"
+	return "multi error: (" + strings.Join(F.MapToString(e.errors), " | ") + ")"
 }
 
 func (e *multiError) Unwrap() error {
diff --git a/common/format/fmt.go b/common/format/fmt.go
index 21497c7..3e4d278 100644
--- a/common/format/fmt.go
+++ b/common/format/fmt.go
@@ -2,6 +2,8 @@ package format
 
 import (
 	"strconv"
+
+	"github.com/sagernet/sing/common"
 )
 
 type Stringer interface {
@@ -61,6 +63,14 @@ func ToString0[T any](message T) string {
 	return ToString(message)
 }
 
+func MapToString[T any](arr []T) []string {
+	// TODO: replace if golangci-lint fixed
+	// return common.Map(arr, ToString0[T])
+	return common.Map(arr, func(it T) string {
+		return ToString(it)
+	})
+}
+
 func Seconds(seconds float64) string {
 	seconds100 := int(seconds * 100)
 	return ToString(seconds100/100, ".", seconds100%100, seconds100%10)
diff --git a/common/task/task.go b/common/task/task.go
index b998194..a04e4c2 100644
--- a/common/task/task.go
+++ b/common/task/task.go
@@ -33,9 +33,9 @@ func Run(ctx context.Context, tasks ...func() error) error {
 	return E.Errors(retErr...)
 }
 
-//goland:noinspection GoVetLostCancel
 func Any(ctx context.Context, tasks ...func(ctx context.Context) error) error {
 	runtimeCtx, cancel := context.WithCancel(ctx)
+	defer cancel()
 	var retErr error
 	for _, task := range tasks {
 		currentTask := task