SagerNet/sing
1
0
Fork 0
mirror of https://github.com/SagerNet/sing.git synced 2025-04-03 03:47:38 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix HTTP server leak

Browse source
This commit is contained in:
世界 2023-10-01 14:36:31 +08:00
parent e727641a98
commit e0ec961fb1
No known key found for this signature in database
GPG key ID: CD109927C34A63C4
1 changed files with 21 additions and 22 deletions
Download patch file Download diff file Expand all files Collapse all files

43
protocol/http/handshake.go
View file

@ -21,7 +21,6 @@ import (
type Handler = N.TCPConnectionHandler
func HandleConnection(ctx context.Context, conn net.Conn, reader *std_bufio.Reader, authenticator auth.Authenticator, handler Handler, metadata M.Metadata) error {
var httpClient *http.Client
for {
request, err := ReadRequest(reader)
if err != nil {
@ -95,28 +94,26 @@ func HandleConnection(ctx context.Context, conn net.Conn, reader *std_bufio.Read
}
var innerErr error
if httpClient == nil {
httpClient = &http.Client{
Transport: &http.Transport{
DisableCompression: true,
DialContext: func(context context.Context, network, address string) (net.Conn, error) {
metadata.Destination = M.ParseSocksaddr(address)
metadata.Protocol = "http"
input, output := net.Pipe()
go func() {
hErr := handler.NewConnection(ctx, output, metadata)
if hErr != nil {
innerErr = hErr
common.Close(input, output)
}
}()
return input, nil
},
httpClient := &http.Client{
Transport: &http.Transport{
DisableCompression: true,
DialContext: func(context context.Context, network, address string) (net.Conn, error) {
metadata.Destination = M.ParseSocksaddr(address)
metadata.Protocol = "http"
input, output := net.Pipe()
go func() {
hErr := handler.NewConnection(ctx, output, metadata)
if hErr != nil {
innerErr = hErr
common.Close(input, output)
}
}()
return input, nil
},
CheckRedirect: func(req *http.Request, via []*http.Request) error {
return http.ErrUseLastResponse
},
}
},
CheckRedirect: func(req *http.Request, via []*http.Request) error {
return http.ErrUseLastResponse
},
}
response, err := httpClient.Do(request)
@ -139,6 +136,8 @@ func HandleConnection(ctx context.Context, conn net.Conn, reader *std_bufio.Read
return E.Errors(innerErr, err)
}
httpClient.CloseIdleConnections()
if !keepAlive {
return conn.Close()
}