Fix JSON parse error

Closes #94
This commit is contained in:
Pierce 2022-09-13 09:10:05 -07:00
parent 639474ba92
commit 8d59a34afe
2 changed files with 7 additions and 6 deletions

View file

@ -46,7 +46,7 @@ class Handler {
_request.on('response', (data) => { _request.on('response', (data) => {
if (data.statusCode === 404) { if (data.statusCode === 404) {
this.client.emit('debug', `[MCLC]: Failed to download ${url} due to: File not found...`) this.client.emit('debug', `[MCLC]: Failed to download ${url} due to: File not found...`)
resolve(false) return resolve(false)
} }
totalBytes = parseInt(data.headers['content-length']) totalBytes = parseInt(data.headers['content-length'])
@ -113,14 +113,14 @@ class Handler {
const manifest = `${this.options.overrides.url.meta}/mc/game/version_manifest.json` const manifest = `${this.options.overrides.url.meta}/mc/game/version_manifest.json`
request.get(manifest, (error, response, body) => { request.get(manifest, (error, response, body) => {
if (error) resolve(error) if (error) return resolve(error)
const parsed = JSON.parse(body) const parsed = JSON.parse(body)
for (const desiredVersion in parsed.versions) { for (const desiredVersion in parsed.versions) {
if (parsed.versions[desiredVersion].id === this.options.version.number) { if (parsed.versions[desiredVersion].id === this.options.version.number) {
request.get(parsed.versions[desiredVersion].url, (error, response, body) => { request.get(parsed.versions[desiredVersion].url, (error, response, body) => {
if (error) resolve(error) if (error) return resolve(error)
this.client.emit('debug', '[MCLC]: Parsed version from version manifest') this.client.emit('debug', '[MCLC]: Parsed version from version manifest')
this.version = JSON.parse(body) this.version = JSON.parse(body)
@ -576,8 +576,8 @@ class Handler {
'${game_assets}': assetPath, '${game_assets}': assetPath,
'${version_type}': this.options.version.type, '${version_type}': this.options.version.type,
'${clientid}': this.options.authorization.meta.clientId || (this.options.authorization.client_token || this.options.authorization.access_token), '${clientid}': this.options.authorization.meta.clientId || (this.options.authorization.client_token || this.options.authorization.access_token),
'${resolution_width}' : this.options.window ? this.options.window.width : 856, '${resolution_width}': this.options.window ? this.options.window.width : 856,
'${resolution_height}': this.options.window ? this.options.window.height : 482, '${resolution_height}': this.options.window ? this.options.window.height : 482
} }
if (this.options.authorization.meta.demo && (this.options.features ? !this.options.features.includes('is_demo_user') : true)) { if (this.options.authorization.meta.demo && (this.options.features ? !this.options.features.includes('is_demo_user') : true)) {
@ -624,6 +624,7 @@ class Handler {
}) })
if (this.options.window) { if (this.options.window) {
// eslint-disable-next-line no-unused-expressions
this.options.window.fullscreen this.options.window.fullscreen
? args.push('--fullscreen') ? args.push('--fullscreen')
: () => { : () => {

View file

@ -1,6 +1,6 @@
{ {
"name": "minecraft-launcher-core", "name": "minecraft-launcher-core",
"version": "3.16.16", "version": "3.16.17",
"description": "Lightweight module that downloads and runs Minecraft using javascript / NodeJS", "description": "Lightweight module that downloads and runs Minecraft using javascript / NodeJS",
"main": "index.js", "main": "index.js",
"dependencies": { "dependencies": {