mirrors/aria2
1
0
Fork 0
mirror of https://github.com/aria2/aria2.git synced 2025-04-04 21:17:41 +03:00
Code Issues Projects Releases Packages Wiki Activity

Don't copy Option in RequestGroup ctor.

Browse source 
Copy on receive is not a practice in aria2 source code.
This commit is contained in:
Tatsuhiro Tsujikawa 2011-10-25 21:44:04 +09:00
parent 62a07fff5f
commit 12659c74a8
9 changed files with 53 additions and 39 deletions
Download patch file Download diff file Expand all files Collapse all files

8
test/RpcMethodTest.cc
View file

@ -752,11 +752,11 @@ void RpcMethodTest::testGatherProgressCommon()
SharedHandle<DownloadContext> dctx(new DownloadContext(0, 0,"aria2.tar.bz2"));
std::string uris[] = { "http://localhost/aria2.tar.bz2" };
dctx->getFirstFileEntry()->addUris(vbegin(uris), vend(uris));
SharedHandle<RequestGroup> group(new RequestGroup(option_));
SharedHandle<RequestGroup> group(new RequestGroup(util::copy(option_)));
group->setDownloadContext(dctx);
std::vector<SharedHandle<RequestGroup> > followedBy;
for(int i = 0; i < 2; ++i) {
followedBy.push_back(SharedHandle<RequestGroup>(new RequestGroup(option_)));
followedBy.push_back(SharedHandle<RequestGroup>(new RequestGroup(util::copy(option_))));
}
group->followedBy(followedBy.begin(), followedBy.end());
@ -844,9 +844,9 @@ void RpcMethodTest::testGatherBitTorrentMetadata()
void RpcMethodTest::testChangePosition()
{
e_->getRequestGroupMan()->addReservedGroup
(SharedHandle<RequestGroup>(new RequestGroup(option_)));
(SharedHandle<RequestGroup>(new RequestGroup(util::copy(option_))));
e_->getRequestGroupMan()->addReservedGroup
(SharedHandle<RequestGroup>(new RequestGroup(option_)));
(SharedHandle<RequestGroup>(new RequestGroup(util::copy(option_))));
ChangePositionRpcMethod m;
RpcRequest req(ChangePositionRpcMethod::getMethodName(), List::g());