mirrors/aria2
1
0
Fork 0
mirror of https://github.com/aria2/aria2.git synced 2025-04-05 13:37:40 +03:00
Code Issues Projects Releases Packages Wiki Activity

2008-09-14 Tatsuhiro Tsujikawa <tujikawa at rednoah dot com>

Browse source 
Added upper limit of FTP response buffer. The current 
implementation
	uses 4096bytes as a limit.
	* src/FtpConnection.cc
	* src/FtpConnection.h
	* test/FtpConnectionTest.cc
This commit is contained in:
Tatsuhiro Tsujikawa 2008-09-14 12:51:30 +00:00
parent 495f02ebbc
commit 479a16edd6
4 changed files with 38 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

22
test/FtpConnectionTest.cc
View file

@ -4,7 +4,9 @@
#include "SocketCore.h"
#include "Request.h"
#include "Option.h"
#include "DlRetryEx.h"
#include <iostream>
#include <cstring>
#include <cppunit/extensions/HelperMacros.h>
namespace aria2 {
@ -13,6 +15,7 @@ class FtpConnectionTest:public CppUnit::TestFixture {
CPPUNIT_TEST_SUITE(FtpConnectionTest);
CPPUNIT_TEST(testReceiveResponse);
CPPUNIT_TEST(testReceiveResponse_overflow);
CPPUNIT_TEST(testSendMdtm);
CPPUNIT_TEST(testReceiveMdtmResponse);
CPPUNIT_TEST_SUITE_END();
@ -50,6 +53,7 @@ public:
void testSendMdtm();
void testReceiveMdtmResponse();
void testReceiveResponse();
void testReceiveResponse_overflow();
};
@ -137,4 +141,22 @@ void FtpConnectionTest::testReceiveMdtmResponse()
}
}
void FtpConnectionTest::testReceiveResponse_overflow()
{
char data[1024];
memset(data, 0, sizeof(data));
memcpy(data, "213 ", 4);
for(int i = 0; i < 4; ++i) {
_serverSocket->writeData(data, sizeof(data));
CPPUNIT_ASSERT_EQUAL((unsigned int)0, _ftp->receiveResponse());
}
_serverSocket->writeData(data, sizeof(data));
try {
_ftp->receiveResponse();
CPPUNIT_FAIL("exception must be thrown.");
} catch(DlRetryEx& e) {
// success
}
}
} // namespace aria2