mirrors/aria2
1
0
Fork 0
mirror of https://github.com/aria2/aria2.git synced 2025-04-05 13:37:40 +03:00
Code Issues Projects Releases Packages Wiki Activity

Return std::unique_ptr member as const ref

Browse source 
Returning raw pointer has a risk that it may be stolen by
std::shared_ptr in accident.
This commit is contained in:
Tatsuhiro Tsujikawa 2013-06-26 23:56:43 +09:00
parent 47402c5f29
commit da7400ef5c
18 changed files with 35 additions and 33 deletions
Download patch file Download diff file Expand all files Collapse all files

1
test/UTMetadataRequestExtensionMessageTest.cc
View file

@ -41,7 +41,6 @@ public:
messageFactory_.reset(new WrapExtBtMessageFactory());
dispatcher_.reset(new MockBtMessageDispatcher());
dctx_.reset(new DownloadContext());
std::shared_ptr<TorrentAttribute> attrs(new TorrentAttribute());
dctx_->setAttribute(CTX_ATTR_BT, make_unique<TorrentAttribute>());
peer_.reset(new Peer("host", 6880));
peer_->allocateSessionResource(0, 0);