From 6ae388e646fb3562608d644aa83bf80f2212ebb0 Mon Sep 17 00:00:00 2001
From: Frank Denis <github@pureftpd.org>
Date: Fri, 19 Apr 2024 18:19:16 +0200
Subject: [PATCH] DNS64 plugin: don't return SYNTH data, alter the response
 directly

Fixes #2619

However, cached responses now appear with the "PASS" status rather
than "CLOAK".
---
 dnscrypt-proxy/plugin_dns64.go | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/dnscrypt-proxy/plugin_dns64.go b/dnscrypt-proxy/plugin_dns64.go
index 7e1a06ce..9792bf22 100644
--- a/dnscrypt-proxy/plugin_dns64.go
+++ b/dnscrypt-proxy/plugin_dns64.go
@@ -152,11 +152,10 @@ func (plugin *PluginDNS64) Eval(pluginsState *PluginsState, msg *dns.Msg) error
 		}
 	}
 
-	synth := EmptyResponseFromMessage(msg)
-	synth.Answer = append(synth.Answer, synth64...)
+	msg.Answer = synth64
+	msg.AuthenticatedData = false
+	msg.SetEdns0(uint16(MaxDNSUDPSafePacketSize), false)
 
-	pluginsState.synthResponse = synth
-	pluginsState.action = PluginsActionSynth
 	pluginsState.returnCode = PluginsReturnCodeCloak
 
 	return nil