From a108d048d83a8956db413dd3fb986ccfaa07dccf Mon Sep 17 00:00:00 2001
From: Frank Denis <github@pureftpd.org>
Date: Fri, 11 Aug 2023 11:16:44 +0200
Subject: [PATCH] A useless Chtimes() call is still required for the tests :/

---
 dnscrypt-proxy/sources.go | 14 ++++++--------
 1 file changed, 6 insertions(+), 8 deletions(-)

diff --git a/dnscrypt-proxy/sources.go b/dnscrypt-proxy/sources.go
index 2c94061e..80ac9ac7 100644
--- a/dnscrypt-proxy/sources.go
+++ b/dnscrypt-proxy/sources.go
@@ -108,18 +108,16 @@ func (source *Source) updateCache(bin, sig []byte, now time.Time) {
 		absPath = resolved
 	}
 
-	if bytes.Equal(source.bin, bin) {
-		if err := os.Chtimes(file, now, now); err != nil {
-			dlog.Warnf("Couldn't update cache file [%s]: %s", absPath, err)
+	if !bytes.Equal(source.bin, bin) {
+		if err := writeSource(file, bin, sig); err != nil {
+			dlog.Warnf("Couldn't write cache file [%s]: %s", absPath, err) // an error writing to the cache isn't fatal
 		}
-		return
+	}
+	if err := os.Chtimes(file, now, now); err != nil {
+		dlog.Warnf("Couldn't update cache file [%s]: %s", absPath, err)
 	}
 
 	source.bin = bin
-
-	if err := writeSource(file, bin, sig); err != nil {
-		dlog.Warnf("Couldn't write cache file [%s]: %s", absPath, err) // an error writing to the cache isn't fatal
-	}
 }
 
 func (source *Source) parseURLs(urls []string) {