mirrors/dnscrypt-proxy
1
0
Fork 0
mirror of https://github.com/DNSCrypt/dnscrypt-proxy.git synced 2025-04-06 14:47:35 +03:00
Code Issues Projects Releases Packages Wiki Activity

Handle Drop/Synth actions the same way in query and response plugins

Browse source
This commit is contained in:
Frank Denis 2019-12-17 16:28:12 +01:00
parent a23f07a93d
commit b1c08f8931
2 changed files with 23 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

1
dnscrypt-proxy/plugins.go
View file

@ -226,6 +226,7 @@ type Plugin interface {
func NewPluginsState(proxy *Proxy, clientProto string, clientAddr *net.Addr, start time.Time) PluginsState { func NewPluginsState(proxy *Proxy, clientProto string, clientAddr *net.Addr, start time.Time) PluginsState {
return PluginsState{ return PluginsState{
action: PluginsActionForward, action: PluginsActionForward,
returnCode: PluginsReturnCodeForward,
maxPayloadSize: MaxDNSUDPPacketSize - ResponseOverhead, maxPayloadSize: MaxDNSUDPPacketSize - ResponseOverhead,
clientProto: clientProto, clientProto: clientProto,
clientAddr: clientAddr, clientAddr: clientAddr,

35
dnscrypt-proxy/proxy.go
View file

@ -442,23 +442,19 @@ func (proxy *Proxy) processIncomingQuery(serverInfo *ServerInfo, clientProto str
if len(query) < MinDNSPacketSize || len(query) > MaxDNSPacketSize { if len(query) < MinDNSPacketSize || len(query) > MaxDNSPacketSize {
return return
} }
if pluginsState.action == PluginsActionDrop {
pluginsState.returnCode = PluginsReturnCodeDrop
pluginsState.ApplyLoggingPlugins(&proxy.pluginsGlobals)
return
}
var err error var err error
if pluginsState.action != PluginsActionForward { if pluginsState.synthResponse != nil {
if pluginsState.synthResponse != nil { response, err = pluginsState.synthResponse.PackBuffer(response)
response, err = pluginsState.synthResponse.PackBuffer(response) if err != nil {
if err != nil { pluginsState.returnCode = PluginsReturnCodeParseError
pluginsState.returnCode = PluginsReturnCodeParseError
pluginsState.ApplyLoggingPlugins(&proxy.pluginsGlobals)
return
}
}
if pluginsState.action == PluginsActionDrop {
pluginsState.returnCode = PluginsReturnCodeDrop
pluginsState.ApplyLoggingPlugins(&proxy.pluginsGlobals) pluginsState.ApplyLoggingPlugins(&proxy.pluginsGlobals)
return return
} }
} else {
pluginsState.returnCode = PluginsReturnCodeForward
} }
if len(response) == 0 && serverInfo != nil { if len(response) == 0 && serverInfo != nil {
var ttl *uint32 var ttl *uint32
@ -533,6 +529,19 @@ func (proxy *Proxy) processIncomingQuery(serverInfo *ServerInfo, clientProto str
serverInfo.noticeFailure(proxy) serverInfo.noticeFailure(proxy)
return return
} }
if pluginsState.action == PluginsActionDrop {
pluginsState.returnCode = PluginsReturnCodeDrop
pluginsState.ApplyLoggingPlugins(&proxy.pluginsGlobals)
return
}
if pluginsState.synthResponse != nil {
response, err = pluginsState.synthResponse.PackBuffer(response)
if err != nil {
pluginsState.returnCode = PluginsReturnCodeParseError
pluginsState.ApplyLoggingPlugins(&proxy.pluginsGlobals)
return
}
}
if rcode := Rcode(response); rcode == dns.RcodeServerFailure { // SERVFAIL if rcode := Rcode(response); rcode == dns.RcodeServerFailure { // SERVFAIL
dlog.Infof("Server [%v] returned temporary error code [%v] -- Upstream server may be experiencing connectivity issues", serverInfo.Name, rcode) dlog.Infof("Server [%v] returned temporary error code [%v] -- Upstream server may be experiencing connectivity issues", serverInfo.Name, rcode)
serverInfo.noticeFailure(proxy) serverInfo.noticeFailure(proxy)