From 840d23e931d4cb22474837680f0488dc6f3f04cf Mon Sep 17 00:00:00 2001 From: qvalentin Date: Sat, 8 Jun 2024 15:16:13 +0200 Subject: [PATCH 1/8] feat: add artist page --- data/album.go | 29 +++++++++++------ data/artist.go | 65 ++++++++++++++++++++++++++++++++++++++ data/lyrics.go | 13 +++----- handlers/artist.go | 70 +++++++++++++++++++++++++++++++++++++++++ handlers/artist_test.go | 50 +++++++++++++++++++++++++++++ handlers/cache.go | 2 +- handlers/handler.go | 1 + style/artist.css | 25 +++++++++++++++ style/lyrics.css | 1 - views/album.templ | 2 +- views/artist.templ | 27 ++++++++++++++++ 11 files changed, 264 insertions(+), 21 deletions(-) create mode 100644 data/artist.go create mode 100644 handlers/artist.go create mode 100644 handlers/artist_test.go create mode 100644 style/artist.css create mode 100644 views/artist.templ diff --git a/data/album.go b/data/album.go index ba2fec6..95a5f79 100644 --- a/data/album.go +++ b/data/album.go @@ -7,10 +7,15 @@ import ( "github.com/PuerkitoBio/goquery" ) +type AlbumPreview struct { + Name string + Image string + URL string +} + type Album struct { - Artist string - Name string - Image string + AlbumPreview + Artist ArtistPreview About [2]string Tracks []Track @@ -24,11 +29,11 @@ type Track struct { type albumMetadata struct { Album struct { - Id int `json:"id"` - Image string `json:"cover_art_thumbnail_url"` - Name string `json:"name"` - Description string `json:"description_preview"` - Artist `json:"artist"` + Id int `json:"id"` + Image string `json:"cover_art_thumbnail_url"` + Name string `json:"name"` + Description string `json:"description_preview"` + artistPreviewMetadata `json:"artist"` } AlbumAppearances []AlbumAppearances `json:"album_appearances"` } @@ -42,8 +47,9 @@ type AlbumAppearances struct { } } -type Artist struct { +type artistPreviewMetadata struct { Name string `json:"name"` + URL string `json:"url"` } func (a *Album) parseAlbumData(doc *goquery.Document) error { @@ -58,7 +64,10 @@ func (a *Album) parseAlbumData(doc *goquery.Document) error { } albumData := albumMetadataFromPage.Album - a.Artist = albumData.Artist.Name + a.Artist = ArtistPreview{ + Name: albumData.artistPreviewMetadata.Name, + URL: strings.Replace(albumData.artistPreviewMetadata.URL, "https://genius.com", "", -1), + } a.Name = albumData.Name a.Image = albumData.Image a.About[0] = albumData.Description diff --git a/data/artist.go b/data/artist.go new file mode 100644 index 0000000..b5829a9 --- /dev/null +++ b/data/artist.go @@ -0,0 +1,65 @@ +package data + +import ( + "encoding/json" + "strings" + + "github.com/PuerkitoBio/goquery" +) + +type ArtistPreview struct { + Name string + URL string +} + +type Artist struct { + Name string + Description string + Albums []AlbumPreview + Image string +} + +type artistMetadata struct { + Artist struct { + Id int `json:"id"` + Name string `json:"name"` + Description string `json:"description_preview"` + Image string `json:"image_url"` + } + Albums []struct { + Id int `json:"id"` + Image string `json:"cover_art_thumbnail_url"` + Name string `json:"name"` + URL string `json:"url"` + } `json:"artist_albums"` +} + +func (a *Artist) parseArtistData(doc *goquery.Document) error { + pageMetadata, exists := doc.Find("meta[itemprop='page_data']").Attr("content") + if !exists { + return nil + } + + var artistMetadataFromPage artistMetadata + if err := json.Unmarshal([]byte(pageMetadata), &artistMetadataFromPage); err != nil { + return err + } + + a.Name = artistMetadataFromPage.Artist.Name + a.Description = artistMetadataFromPage.Artist.Description + a.Image = artistMetadataFromPage.Artist.Image + + for _, album := range artistMetadataFromPage.Albums { + a.Albums = append(a.Albums, AlbumPreview{ + Name: album.Name, + Image: album.Image, + URL: strings.Replace(album.URL, "https://genius.com", "", -1), + }) + } + + return nil +} + +func (a *Artist) Parse(doc *goquery.Document) error { + return a.parseArtistData(doc) +} diff --git a/data/lyrics.go b/data/lyrics.go index 016258e..60d378f 100644 --- a/data/lyrics.go +++ b/data/lyrics.go @@ -16,11 +16,7 @@ type Song struct { Lyrics string Credits map[string]string About [2]string - Album struct { - URL string - Name string - Image string - } + Album AlbumPreview } type songResponse struct { @@ -38,10 +34,10 @@ type songResponse struct { Image string `json:"cover_art_url"` } CustomPerformances []customPerformance `json:"custom_performances"` - WriterArtists []struct { + WriterArtists []struct { Name string } `json:"writer_artists"` - ProducerArtists []struct { + ProducerArtists []struct { Name string } `json:"producer_artists"` } @@ -117,7 +113,8 @@ func (s *Song) parseSongData(doc *goquery.Document) error { func joinNames(data []struct { Name string -}) string { +}, +) string { var names []string for _, hasName := range data { names = append(names, hasName.Name) diff --git a/handlers/artist.go b/handlers/artist.go new file mode 100644 index 0000000..4406133 --- /dev/null +++ b/handlers/artist.go @@ -0,0 +1,70 @@ +package handlers + +import ( + "context" + "fmt" + "net/http" + + "github.com/PuerkitoBio/goquery" + "github.com/gorilla/mux" + "github.com/rramiachraf/dumb/data" + "github.com/rramiachraf/dumb/utils" + "github.com/rramiachraf/dumb/views" +) + +func artist(l *utils.Logger) http.HandlerFunc { + return func(w http.ResponseWriter, r *http.Request) { + artistName := mux.Vars(r)["artist"] + + id := fmt.Sprintf("artist:%s", artistName) + + if a, err := getCache[data.Artist](id); err == nil { + views.ArtistPage(a).Render(context.Background(), w) + return + } + + url := fmt.Sprintf("https://genius.com/artists/%s", artistName) + + resp, err := utils.SendRequest(url) + if err != nil { + l.Error(err.Error()) + w.WriteHeader(http.StatusInternalServerError) + views.ErrorPage(500, "cannot reach Genius servers").Render(context.Background(), w) + return + } + + defer resp.Body.Close() + + if resp.StatusCode == http.StatusNotFound { + w.WriteHeader(http.StatusNotFound) + views.ErrorPage(404, "page not found").Render(context.Background(), w) + return + } + + doc, err := goquery.NewDocumentFromReader(resp.Body) + if err != nil { + l.Error(err.Error()) + w.WriteHeader(http.StatusInternalServerError) + views.ErrorPage(500, "something went wrong").Render(context.Background(), w) + return + } + + cf := doc.Find(".cloudflare_content").Length() + if cf > 0 { + l.Error("cloudflare got in the way") + views.ErrorPage(500, "cloudflare is detected").Render(context.Background(), w) + return + } + + var a data.Artist + if err = a.Parse(doc); err != nil { + l.Error(err.Error()) + } + + views.ArtistPage(a).Render(context.Background(), w) + + if err = setCache(id, a); err != nil { + l.Error(err.Error()) + } + } +} diff --git a/handlers/artist_test.go b/handlers/artist_test.go new file mode 100644 index 0000000..b51ca32 --- /dev/null +++ b/handlers/artist_test.go @@ -0,0 +1,50 @@ +package handlers + +import ( + "net/http" + "net/http/httptest" + "os" + "testing" + + "github.com/PuerkitoBio/goquery" + + "github.com/rramiachraf/dumb/utils" +) + +func TestArtist(t *testing.T) { + url := "/artists/Red-hot-chili-peppers" + name := "Red Hot Chili Peppers" + firstAlbumName := "Cardiff, Wales: 6/23/04" + + r, err := http.NewRequest(http.MethodGet, url, nil) + if err != nil { + t.Fatal(err) + } + + rr := httptest.NewRecorder() + l := utils.NewLogger(os.Stdout) + m := New(l, &assets{}) + + m.ServeHTTP(rr, r) + + defer rr.Result().Body.Close() + + if rr.Result().StatusCode != http.StatusOK { + t.Fatalf("expected %d, got %d\n", http.StatusOK, rr.Result().StatusCode) + } + + doc, err := goquery.NewDocumentFromReader(rr.Result().Body) + if err != nil { + t.Fatal(err) + } + + artistName := doc.Find("#metadata-info > h1").First().Text() + if artistName != name { + t.Fatalf("expected %q, got %q\n", name, artistName) + } + + albumName := doc.Find("#artist-albumlist > a > p").First().Text() + if albumName != firstAlbumName { + t.Fatalf("expected %q, got %q\n", firstAlbumName, albumName) + } +} diff --git a/handlers/cache.go b/handlers/cache.go index 4874057..d07a876 100644 --- a/handlers/cache.go +++ b/handlers/cache.go @@ -10,7 +10,7 @@ import ( ) type cachable interface { - data.Album | data.Song | data.Annotation | []byte + data.Album | data.Song | data.Annotation | data.Artist | []byte } var c, _ = bigcache.New(context.Background(), bigcache.DefaultConfig(time.Hour*24)) diff --git a/handlers/handler.go b/handlers/handler.go index 738bf7e..9cb32c7 100644 --- a/handlers/handler.go +++ b/handlers/handler.go @@ -22,6 +22,7 @@ func New(logger *utils.Logger, staticFiles static) *mux.Router { w.Write([]byte("User-agent: *\nDisallow: /\n")) }) r.HandleFunc("/albums/{artist}/{albumName}", album(logger)).Methods("GET") + r.HandleFunc("/artists/{artist}", artist(logger)).Methods("GET") r.HandleFunc("/images/{filename}.{ext}", imageProxy(logger)).Methods("GET") r.HandleFunc("/search", search(logger)).Methods("GET") r.HandleFunc("/{annotation-id}/{artist-song}/{verse}/annotations", annotations(logger)).Methods("GET") diff --git a/style/artist.css b/style/artist.css new file mode 100644 index 0000000..2144fd0 --- /dev/null +++ b/style/artist.css @@ -0,0 +1,25 @@ +artist-albumlist #artist-albumlist p { + color: #181d31; + font-weight: 500; +} + +.dark #artist-albumlist p { + color: #ddd; +} + +#artist-albumlist small { + font-size: 1.5rem; + color: #333; +} + +.dark #artist-albumlist small { + color: #ccc; +} + +#metadata p { + color: #171717; +} + +.dark #metadata p { + color: #ddd; +} diff --git a/style/lyrics.css b/style/lyrics.css index a527a86..972ed6a 100644 --- a/style/lyrics.css +++ b/style/lyrics.css @@ -132,4 +132,3 @@ text-align: center; } } - diff --git a/views/album.templ b/views/album.templ index bac1b96..32e002c 100644 --- a/views/album.templ +++ b/views/album.templ @@ -11,7 +11,7 @@ templ AlbumPage(a data.Album) {
Album image
-

{ a.Artist }

+

{ a.Artist.Name }

{ a.Name }

diff --git a/views/artist.templ b/views/artist.templ new file mode 100644 index 0000000..80903de --- /dev/null +++ b/views/artist.templ @@ -0,0 +1,27 @@ +package views + +import ( + "github.com/rramiachraf/dumb/data" +) + +templ ArtistPage(a data.Artist) { + @layout(a.Name) { +
+
+ Artist image +
+

{ a.Name }

+

@templ.Raw(a.Description)

+
+
+
+ for _, album := range a.Albums { + + Artist image +

{ album.Name }

+ + } +
+
+ } +} From e6e9d5b16d31b70402291755e45de68950963e3d Mon Sep 17 00:00:00 2001 From: rramiachraf <51409801+rramiachraf@users.noreply.github.com> Date: Sun, 9 Jun 2024 21:29:17 +0100 Subject: [PATCH 2/8] refactor: improve styling a bit --- static/script.js | 10 ++++---- style/artist.css | 61 +++++++++++++++++++++++++++++++++++++------- style/layout.css | 14 +++++++--- style/main.css | 4 +++ utils/description.go | 9 +++++++ views/album.templ | 6 ++--- views/artist.templ | 40 ++++++++++++++++++++++------- views/lyrics.templ | 6 ++--- 8 files changed, 118 insertions(+), 32 deletions(-) create mode 100644 utils/description.go diff --git a/static/script.js b/static/script.js index 2109349..1336945 100644 --- a/static/script.js +++ b/static/script.js @@ -1,12 +1,12 @@ -const fullAbout = document.querySelector("#about #full_about") -const summary = document.querySelector("#about #summary") +const description = document.querySelector("#description > #full") +const summary = document.querySelector("#description > #summary") -function showAbout() { +function showDescription() { summary.classList.toggle("hidden") - fullAbout.classList.toggle("hidden") + description.classList.toggle("hidden") } -fullAbout && [fullAbout, summary].forEach(item => item.onclick = showAbout) +description && [description, summary].forEach(item => item.onclick = showDescription) window.addEventListener("load", () => { const geniusURL = "https://genius.com" + document.location.pathname + document.location.search diff --git a/style/artist.css b/style/artist.css index 2144fd0..9cbec55 100644 --- a/style/artist.css +++ b/style/artist.css @@ -1,25 +1,68 @@ -artist-albumlist #artist-albumlist p { - color: #181d31; - font-weight: 500; +#artist-albumlist { + color: #181d31; + font-weight: 500; + display: grid; + grid-template-columns: repeat(auto-fill, 150px); + gap: 1.5rem; +} + +#artwork-preview { + width: 150px; + height: 150px; + border-radius: 5px; + border: 1px solid #ddd; +} + +#artist-image { + border-radius: 50%; + border: 2px solid #ddd; +} + +#artist-name { + text-align: center; +} + +#artist-single-album { + color: #111; + display: flex; + flex-direction: column; + gap: 0.5rem; + text-align: center; } .dark #artist-albumlist p { - color: #ddd; + color: #ddd; } #artist-albumlist small { - font-size: 1.5rem; - color: #333; + font-size: 1.5rem; + color: #333; } .dark #artist-albumlist small { - color: #ccc; + color: #ccc; } #metadata p { - color: #171717; + color: #171717; } .dark #metadata p { - color: #ddd; + color: #ddd; +} + +#artist-section { + display: flex; + flex-direction: column; + gap: 1rem; +} + +#artist-sections { + display: flex; + flex-direction: column; + gap: 2rem; +} + +#artist-section h2 { + font-size: 2rem; } diff --git a/style/layout.css b/style/layout.css index 3fef342..ec126f9 100644 --- a/style/layout.css +++ b/style/layout.css @@ -5,15 +5,23 @@ } #container { - display: grid; padding: 5rem 0; - grid-template-columns: 24rem calc(1024px - 56rem) 24rem; width: 1024px; margin: 0 auto; - gap: 4rem; + display: grid; flex: 1; } +.trio-split { + grid-template-columns: 24rem calc(1024px - 56rem) 24rem; + gap: 4rem; +} + +.duo-split { + grid-template-columns: 24rem 1fr; + gap: 4rem; +} + .main { flex-grow: 1; } diff --git a/style/main.css b/style/main.css index 1f15feb..5b94c27 100644 --- a/style/main.css +++ b/style/main.css @@ -57,6 +57,10 @@ a { text-decoration: none; } +a:hover { + text-decoration: underline; +} + body.dark { background-color: #181d31; } diff --git a/utils/description.go b/utils/description.go new file mode 100644 index 0000000..4de94dd --- /dev/null +++ b/utils/description.go @@ -0,0 +1,9 @@ +package utils + +func TrimText(text string, keep int) string { + if len(text) > keep { + return text[0:keep] + "..." + } + + return text +} diff --git a/views/album.templ b/views/album.templ index 32e002c..bbb68ba 100644 --- a/views/album.templ +++ b/views/album.templ @@ -7,7 +7,7 @@ import ( templ AlbumPage(a data.Album) { @layout(fmt.Sprintf("%s - %s", a.Artist, a.Name)) { -
+
Album image
@@ -25,9 +25,9 @@ templ AlbumPage(a data.Album) {
if a.About[0] != "" {
-
+

About

- +

{ a.About[1] }

diff --git a/views/artist.templ b/views/artist.templ index 80903de..7796427 100644 --- a/views/artist.templ +++ b/views/artist.templ @@ -2,24 +2,46 @@ package views import ( "github.com/rramiachraf/dumb/data" + "github.com/rramiachraf/dumb/utils" ) templ ArtistPage(a data.Artist) { @layout(a.Name) { -
+
Artist image
-

{ a.Name }

-

@templ.Raw(a.Description)

+

{ a.Name }

-
- for _, album := range a.Albums { - - Artist image -

{ album.Name }

- +
+ if a.Description != "" { +
+

About { a.Name }

+
+

+ { utils.TrimText(a.Description, 500) } +

+ +
+
+ } + if len(a.Albums) > 0 { +
+

Albums

+
+ for _, album := range a.Albums { + + Artist image +

{ album.Name }

+ + } +
+
}
diff --git a/views/lyrics.templ b/views/lyrics.templ index 9eecfb4..5b2fcdb 100644 --- a/views/lyrics.templ +++ b/views/lyrics.templ @@ -7,7 +7,7 @@ import ( templ LyricsPage(s data.Song) { @layout(fmt.Sprintf("%s - %s lyrics", s.Artist, s.Title)) { -
+
if s.About[0] != "?" { -
+

About

- +

{ s.About[1] }

} From 355b721069478591ab20bae15cce5035f5f68ca7 Mon Sep 17 00:00:00 2001 From: rramiachraf <51409801+rramiachraf@users.noreply.github.com> Date: Mon, 10 Jun 2024 12:16:11 +0100 Subject: [PATCH 3/8] fix: display albums and artists on the search page, and also few css fixes --- data/search.go | 5 ++++ style/artist.css | 4 +++ style/lyrics.css | 6 ++--- style/search.css | 61 +++++++++++---------------------------------- utils/url.go | 19 ++++++++++++++ views/search.templ | 62 +++++++++++++++++++++++++++++++++++----------- 6 files changed, 94 insertions(+), 63 deletions(-) create mode 100644 utils/url.go diff --git a/data/search.go b/data/search.go index d78ce41..8490941 100644 --- a/data/search.go +++ b/data/search.go @@ -11,6 +11,11 @@ type result struct { Title string Path string Thumbnail string `json:"song_art_image_thumbnail_url"` + ArtistImage string `json:"image_url"` + ArtistName string `json:"name"` + URL string `json:"url"` + AlbumImage string `json:"cover_art_url"` + AlbumName string `json:"full_title"` } type hits []struct { diff --git a/style/artist.css b/style/artist.css index 9cbec55..06f64b2 100644 --- a/style/artist.css +++ b/style/artist.css @@ -66,3 +66,7 @@ #artist-section h2 { font-size: 2rem; } + +.dark #artist-section h2 { + color: #ddd; +} diff --git a/style/lyrics.css b/style/lyrics.css index 972ed6a..99db93a 100644 --- a/style/lyrics.css +++ b/style/lyrics.css @@ -47,13 +47,13 @@ flex-basis: 0; } -#about { +#description { display: flex; flex-direction: column; gap: 0.5rem; } -#about p { +#description p { font-size: 1.4rem; color: #171717; line-height: 1.8rem; @@ -121,7 +121,7 @@ color: #ddd; } -.dark #about p, +.dark #description p, .dark #credits summary { color: #ccc; } diff --git a/style/search.css b/style/search.css index f791ff9..70fd4c6 100644 --- a/style/search.css +++ b/style/search.css @@ -15,13 +15,19 @@ #search-results { display: flex; flex-direction: column; - gap: 1rem; + gap: 4rem; } -#search-results h1 { - text-align: center; - color: #111; - font-size: 2.5rem; +#search-results h2 { + color: #222; + font-size: 1.8rem; + font-weight: 500; +} + +#search-section { + display: flex; + flex-direction: column; + gap: 1rem; } #search-item { @@ -34,9 +40,9 @@ box-shadow: 0 1px 1px #ddd; } -#search-item h2 { +#search-item h3 { font-size: 1.8rem; - color: #222; + color: #333; } #search-item span { @@ -58,44 +64,7 @@ color: #222; } -#search-results { - display: flex; - flex-direction: column; - gap: 1rem; -} - -#search-results h1 { - text-align: center; - color: #111; - font-size: 2.5rem; -} - -#search-item { - display: flex; - height: 8rem; - border: 1px solid #eee; - border-radius: 5px; - gap: 1rem; - padding: 1rem; - box-shadow: 0 1px 1px #ddd; -} - -#search-item h2 { - font-size: 1.8rem; - color: #222; -} - -#search-item span { - font-size: 1.3rem; - color: #333; -} - -#search-item img { - width: 8rem; - border-radius: 5px; -} - -.dark #search-page h1 { +.dark #search-page h2 { color: #eee; } @@ -103,7 +72,7 @@ border: 1px solid #888; } -.dark #search-item h2 { +.dark #search-item h3 { color: #ddd; } diff --git a/utils/url.go b/utils/url.go new file mode 100644 index 0000000..c3454d4 --- /dev/null +++ b/utils/url.go @@ -0,0 +1,19 @@ +package utils + +import ( + "net/url" + "strings" +) + +func TrimURL(u string) string { + uu, err := url.Parse(u) + if err != nil { + return "" + } + + if strings.HasPrefix(uu.Path, "/") { + return uu.Path + } + + return "/" + uu.Path +} diff --git a/views/search.templ b/views/search.templ index 7daf62c..01d6896 100644 --- a/views/search.templ +++ b/views/search.templ @@ -1,8 +1,8 @@ package views import ( - "fmt" "github.com/rramiachraf/dumb/data" + "github.com/rramiachraf/dumb/utils" ) templ SearchPage(r data.SearchResults) { @@ -14,19 +14,53 @@ templ SearchPage(r data.SearchResults) {
for _, s := range r.Sections { if s.Type == "song" { -

Songs

- for _, s := range s.Hits { - - { -
- { s.Result.ArtistNames } -

{ s.Result.Title }

-
- - } +
+

Songs

+ for _, s := range s.Hits { + + Song image +
+ { s.Result.ArtistNames } +

{ s.Result.Title }

+
+ + } +
+ } + if s.Type == "album" { +
+

Albums

+ for _, a := range s.Hits { + + Album image +
+

{ a.Result.AlbumName }

+
+ + } +
+ } + if s.Type == "artist" { +
+

Artists

+ for _, a := range s.Hits { + + Artist image +
+

{ a.Result.ArtistName }

+
+ + } +
} }
From c86b07618887a2ed79b50beb95d9ef280431a9fa Mon Sep 17 00:00:00 2001 From: rramiachraf <51409801+rramiachraf@users.noreply.github.com> Date: Mon, 10 Jun 2024 12:38:32 +0100 Subject: [PATCH 4/8] fix: trim large album names on search page --- views/search.templ | 21 ++++++--------------- 1 file changed, 6 insertions(+), 15 deletions(-) diff --git a/views/search.templ b/views/search.templ index 01d6896..908be95 100644 --- a/views/search.templ +++ b/views/search.templ @@ -18,13 +18,10 @@ templ SearchPage(r data.SearchResults) {

Songs

for _, s := range s.Hits { - Song image + Song image
{ s.Result.ArtistNames } -

{ s.Result.Title }

+

{ utils.TrimText(s.Result.Title,70) }

 } @@ -35,12 +32,9 @@ templ SearchPage(r data.SearchResults) {

Albums

for _, a := range s.Hits { - Album image + Album image
-

{ a.Result.AlbumName }

+

{ utils.TrimText(a.Result.AlbumName, 70) }

 } @@ -51,12 +45,9 @@ templ SearchPage(r data.SearchResults) {

Artists

for _, a := range s.Hits { - Artist image + Artist image
-

{ a.Result.ArtistName }

+

{ utils.TrimText(a.Result.ArtistName, 70) }

 } From 3bf802c9c24e67f1a3c413db2d18145857268f02 Mon Sep 17 00:00:00 2001 From: rramiachraf <51409801+rramiachraf@users.noreply.github.com> Date: Tue, 11 Jun 2024 20:42:33 +0100 Subject: [PATCH 5/8] refactor: organize routing a bit --- handlers/handler.go | 35 ++++++++++++++++++++++++++++------- views/album.templ | 2 +- views/artist.templ | 2 +- 3 files changed, 30 insertions(+), 9 deletions(-) diff --git a/handlers/handler.go b/handlers/handler.go index 9cb32c7..fd0cceb 100644 --- a/handlers/handler.go +++ b/handlers/handler.go @@ -11,26 +11,47 @@ import ( "github.com/rramiachraf/dumb/views" ) +type route struct { + Path string + Handler func(*utils.Logger) http.HandlerFunc + Method string +} + func New(logger *utils.Logger, staticFiles static) *mux.Router { r := mux.NewRouter() r.Use(utils.MustHeaders) r.Use(gorillaHandlers.CompressHandler) + routes := []route{ + {Path: "/albums/{artist}/{albumName}", Handler: album}, + {Path: "/artists/{artist}", Handler: artist}, + {Path: "/images/{filename}.{ext}", Handler: imageProxy}, + {Path: "/search", Handler: search}, + {Path: "/{annotation-id}/{artist-song}/{verse}/annotations", Handler: annotations}, + {Path: "/instances.json", Handler: instances}, + } + + for _, rr := range routes { + method := rr.Method + if method == "" { + method = http.MethodGet + } + + r.HandleFunc(rr.Path, rr.Handler(logger)).Methods(method) + } + + r.PathPrefix("/static/").HandlerFunc(staticAssets(logger, staticFiles)) + r.Handle("/", templ.Handler(views.HomePage())) r.HandleFunc("/robots.txt", func(w http.ResponseWriter, r *http.Request) { w.Write([]byte("User-agent: *\nDisallow: /\n")) }) - r.HandleFunc("/albums/{artist}/{albumName}", album(logger)).Methods("GET") - r.HandleFunc("/artists/{artist}", artist(logger)).Methods("GET") - r.HandleFunc("/images/{filename}.{ext}", imageProxy(logger)).Methods("GET") - r.HandleFunc("/search", search(logger)).Methods("GET") - r.HandleFunc("/{annotation-id}/{artist-song}/{verse}/annotations", annotations(logger)).Methods("GET") - r.HandleFunc("/instances.json", instances(logger)).Methods("GET") - r.PathPrefix("/static/").HandlerFunc(staticAssets(logger, staticFiles)) + r.PathPrefix("/{annotation-id}/{artist-song}-lyrics").HandlerFunc(lyrics(logger)).Methods("GET") r.PathPrefix("/{annotation-id}/{artist-song}").HandlerFunc(lyrics(logger)).Methods("GET") r.PathPrefix("/{annotation-id}").HandlerFunc(lyrics(logger)).Methods("GET") + r.NotFoundHandler = http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { w.WriteHeader(http.StatusNotFound) views.ErrorPage(404, "page not found").Render(context.Background(), w) diff --git a/views/album.templ b/views/album.templ index bbb68ba..c0e6df5 100644 --- a/views/album.templ +++ b/views/album.templ @@ -6,7 +6,7 @@ import ( ) templ AlbumPage(a data.Album) { - @layout(fmt.Sprintf("%s - %s", a.Artist, a.Name)) { + @layout(fmt.Sprintf("%s - %s", a.Artist.Name, a.Name)) {
Album image diff --git a/views/artist.templ b/views/artist.templ index 7796427..732e6a1 100644 --- a/views/artist.templ +++ b/views/artist.templ @@ -35,7 +35,7 @@ templ ArtistPage(a data.Artist) { Artist image

{ album.Name }

From 41d13e1edb1b4c1330d5807ece98cca70ea22c43 Mon Sep 17 00:00:00 2001 From: rramiachraf <51409801+rramiachraf@users.noreply.github.com> Date: Tue, 11 Jun 2024 21:02:58 +0100 Subject: [PATCH 6/8] refactor: remove redundant code --- data/album.go | 5 ++--- data/lyrics.go | 15 ++------------- views/album.templ | 11 +++++++---- views/lyrics.templ | 7 ++++--- 4 files changed, 15 insertions(+), 23 deletions(-) diff --git a/data/album.go b/data/album.go index 95a5f79..8d907ca 100644 --- a/data/album.go +++ b/data/album.go @@ -16,7 +16,7 @@ type AlbumPreview struct { type Album struct { AlbumPreview Artist ArtistPreview - About [2]string + About string Tracks []Track } @@ -70,8 +70,7 @@ func (a *Album) parseAlbumData(doc *goquery.Document) error { } a.Name = albumData.Name a.Image = albumData.Image - a.About[0] = albumData.Description - a.About[1] = truncateText(albumData.Description) + a.About = albumData.Description for _, track := range albumMetadataFromPage.AlbumAppearances { url := strings.Replace(track.Song.Url, "https://genius.com", "", -1) diff --git a/data/lyrics.go b/data/lyrics.go index 60d378f..1611451 100644 --- a/data/lyrics.go +++ b/data/lyrics.go @@ -15,7 +15,7 @@ type Song struct { Image string Lyrics string Credits map[string]string - About [2]string + About string Album AlbumPreview } @@ -94,8 +94,7 @@ func (s *Song) parseSongData(doc *goquery.Document) error { s.Artist = songData.ArtistNames s.Image = songData.Image s.Title = songData.Title - s.About[0] = songData.Description.Plain - s.About[1] = truncateText(songData.Description.Plain) + s.About = songData.Description.Plain s.Credits = make(map[string]string) s.Album.Name = songData.Album.Name s.Album.URL = strings.Replace(songData.Album.URL, "https://genius.com", "", -1) @@ -122,16 +121,6 @@ func joinNames(data []struct { return strings.Join(names, ", ") } -func truncateText(text string) string { - textArr := strings.Split(text, "") - - if len(textArr) > 250 { - return strings.Join(textArr[0:250], "") + "..." - } - - return text -} - func (s *Song) Parse(doc *goquery.Document) error { if err := s.parseLyrics(doc); err != nil { return err diff --git a/views/album.templ b/views/album.templ index c0e6df5..f655172 100644 --- a/views/album.templ +++ b/views/album.templ @@ -3,6 +3,7 @@ package views import ( "fmt" "github.com/rramiachraf/dumb/data" + "github.com/rramiachraf/dumb/utils" ) templ AlbumPage(a data.Album) { @@ -11,7 +12,9 @@ templ AlbumPage(a data.Album) { @@ -23,12 +26,12 @@ templ AlbumPage(a data.Album) { }
- if a.About[0] != "" { + if a.About != "" {

About

- -

{ a.About[1] }

+ +

{ utils.TrimText(a.About, 250) }

} diff --git a/views/lyrics.templ b/views/lyrics.templ index 5b2fcdb..5c75b4d 100644 --- a/views/lyrics.templ +++ b/views/lyrics.templ @@ -3,6 +3,7 @@ package views import ( "fmt" "github.com/rramiachraf/dumb/data" + "github.com/rramiachraf/dumb/utils" ) templ LyricsPage(s data.Song) { @@ -23,11 +24,11 @@ templ LyricsPage(s data.Song) { @templ.Raw(s.Lyrics)
- if s.About[0] != "?" { + if s.About != "?" {

About

- -

{ s.About[1] }

+ +

{ utils.TrimText(s.About, 250) }

} if len(s.Credits) > 0 { From 8545cb313c91ba960fdc7602bebacf116b480d91 Mon Sep 17 00:00:00 2001 From: rramiachraf <51409801+rramiachraf@users.noreply.github.com> Date: Tue, 11 Jun 2024 21:15:27 +0100 Subject: [PATCH 7/8] feat: add artist link on lyrics page --- data/lyrics.go | 19 ++++++++++++------- views/lyrics.templ | 10 ++++------ 2 files changed, 16 insertions(+), 13 deletions(-) diff --git a/data/lyrics.go b/data/lyrics.go index 1611451..0c1abf4 100644 --- a/data/lyrics.go +++ b/data/lyrics.go @@ -10,13 +10,14 @@ import ( ) type Song struct { - Artist string - Title string - Image string - Lyrics string - Credits map[string]string - About string - Album AlbumPreview + Artist string + Title string + Image string + Lyrics string + Credits map[string]string + About string + Album AlbumPreview + ArtistPageURL string } type songResponse struct { @@ -40,6 +41,9 @@ type songResponse struct { ProducerArtists []struct { Name string } `json:"producer_artists"` + PrimaryArtist struct { + URL string + } `json:"primary_artist"` } } } @@ -97,6 +101,7 @@ func (s *Song) parseSongData(doc *goquery.Document) error { s.About = songData.Description.Plain s.Credits = make(map[string]string) s.Album.Name = songData.Album.Name + s.ArtistPageURL = utils.TrimURL(songData.PrimaryArtist.URL) s.Album.URL = strings.Replace(songData.Album.URL, "https://genius.com", "", -1) s.Album.Image = ExtractImageURL(songData.Album.Image) diff --git a/views/lyrics.templ b/views/lyrics.templ index 5c75b4d..6bf58dc 100644 --- a/views/lyrics.templ +++ b/views/lyrics.templ @@ -10,13 +10,11 @@ templ LyricsPage(s data.Song) { @layout(fmt.Sprintf("%s - %s lyrics", s.Artist, s.Title)) {
- Song image + Song image
-

{ s.Artist }

+ +

{ s.Artist }

+

{ s.Title }

From 7e26bf48f68637c5ae1af5c5a7f16559e5294fd2 Mon Sep 17 00:00:00 2001 From: rramiachraf <51409801+rramiachraf@users.noreply.github.com> Date: Tue, 11 Jun 2024 21:25:27 +0100 Subject: [PATCH 8/8] refactor: remove redundant code --- data/album.go | 3 ++- data/artist.go | 4 ++-- data/lyrics.go | 2 +- 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a/data/album.go b/data/album.go index 8d907ca..085fd97 100644 --- a/data/album.go +++ b/data/album.go @@ -5,6 +5,7 @@ import ( "strings" "github.com/PuerkitoBio/goquery" + "github.com/rramiachraf/dumb/utils" ) type AlbumPreview struct { @@ -66,7 +67,7 @@ func (a *Album) parseAlbumData(doc *goquery.Document) error { albumData := albumMetadataFromPage.Album a.Artist = ArtistPreview{ Name: albumData.artistPreviewMetadata.Name, - URL: strings.Replace(albumData.artistPreviewMetadata.URL, "https://genius.com", "", -1), + URL: utils.TrimURL(albumData.artistPreviewMetadata.URL), } a.Name = albumData.Name a.Image = albumData.Image diff --git a/data/artist.go b/data/artist.go index b5829a9..a2b9162 100644 --- a/data/artist.go +++ b/data/artist.go @@ -2,9 +2,9 @@ package data import ( "encoding/json" - "strings" "github.com/PuerkitoBio/goquery" + "github.com/rramiachraf/dumb/utils" ) type ArtistPreview struct { @@ -53,7 +53,7 @@ func (a *Artist) parseArtistData(doc *goquery.Document) error { a.Albums = append(a.Albums, AlbumPreview{ Name: album.Name, Image: album.Image, - URL: strings.Replace(album.URL, "https://genius.com", "", -1), + URL: utils.TrimURL(album.URL), }) } diff --git a/data/lyrics.go b/data/lyrics.go index 0c1abf4..bb1dc39 100644 --- a/data/lyrics.go +++ b/data/lyrics.go @@ -102,7 +102,7 @@ func (s *Song) parseSongData(doc *goquery.Document) error { s.Credits = make(map[string]string) s.Album.Name = songData.Album.Name s.ArtistPageURL = utils.TrimURL(songData.PrimaryArtist.URL) - s.Album.URL = strings.Replace(songData.Album.URL, "https://genius.com", "", -1) + s.Album.URL = utils.TrimURL(songData.Album.URL) s.Album.Image = ExtractImageURL(songData.Album.Image) s.Credits["Writers"] = joinNames(songData.WriterArtists)