mirrors/helix
1
0
Fork 0
mirror of https://github.com/helix-editor/helix.git synced 2025-04-04 11:27:46 +03:00
Code Issues Projects Releases Packages Wiki Activity

LSP: Properly discard out-of-date diagnostics

Browse source 
Previously the `filter` caused the diagnostics to not be attached to the
document - which is good - but the out-of-date diagnostics were still
inserted into the global (editor-wide) diagnostic set. Instead we should
completely discard out-of-date diagnostics.
This commit is contained in:
Michael Davis 2025-02-04 10:05:00 -05:00
parent 62625eda46
commit 313a6479b1
No known key found for this signature in database
1 changed files with 11 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

16
helix-view/src/handlers/lsp.rs
View file

@ -281,17 +281,17 @@ impl Editor {
version: Option<i32>, version: Option<i32>,
mut diagnostics: Vec<lsp::Diagnostic>, mut diagnostics: Vec<lsp::Diagnostic>,
) { ) {
let doc = self.documents.values_mut() let doc = self
.find(|doc| doc.uri().is_some_and(|u| u == uri)) .documents
.filter(|doc| { .values_mut()
if let Some(version) = version { .find(|doc| doc.uri().is_some_and(|u| u == uri));
if let Some((version, doc)) = version.zip(doc.as_ref()) {
if version != doc.version() { if version != doc.version() {
log::info!("Version ({version}) is out of date for {uri:?} (expected ({}), dropping PublishDiagnostic notification", doc.version()); log::info!("Version ({version}) is out of date for {uri:?} (expected ({})), dropping PublishDiagnostic notification", doc.version());
return false; return;
} }
} }
true
});
let mut unchanged_diag_sources = Vec::new(); let mut unchanged_diag_sources = Vec::new();
if let Some((lang_conf, old_diagnostics)) = doc if let Some((lang_conf, old_diagnostics)) = doc