From 09b08fa494cc75416da191f18b46cd72f05121cf Mon Sep 17 00:00:00 2001 From: Toby Date: Mon, 20 May 2024 14:19:04 -0700 Subject: [PATCH] fix: try to fix maybeAppLimited 2 --- core/internal/congestion/bbr/bbr_sender.go | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/core/internal/congestion/bbr/bbr_sender.go b/core/internal/congestion/bbr/bbr_sender.go index 6828dd6..62868ec 100644 --- a/core/internal/congestion/bbr/bbr_sender.go +++ b/core/internal/congestion/bbr/bbr_sender.go @@ -715,13 +715,9 @@ func (b *bbrSender) checkIfFullBandwidthReached(lastPacketSendState *sendTimeSta } func (b *bbrSender) maybeAppLimited(bytesInFlight congestion.ByteCount) { - congestionWindow := b.GetCongestionWindow() - // HACK: consider it app-limited if bytes in flight is less than 90% of the congestion window. - if bytesInFlight >= congestionWindow*9/10 || - (b.mode == bbrModeDrain && bytesInFlight > congestionWindow/2) { - return + if bytesInFlight < b.getTargetCongestionWindow(1) { + b.sampler.OnAppLimited() } - b.sampler.OnAppLimited() } // Transitions from STARTUP to DRAIN and from DRAIN to PROBE_BW if