From af2d75d1d008d29dd8305a393c60a389cac19ff8 Mon Sep 17 00:00:00 2001 From: "Haruue Icymoon (usamimi-wsl)" Date: Sat, 19 Oct 2024 16:27:16 +0800 Subject: [PATCH] fix: check masq url scheme in server cfg parsing Check the url scheme of masquerade.proxy.url when parsing server config and fail fast if it is not "http" or "https". ref: #1227 The user assigned the URL with a naked hostname and got errors until the request was handled. --- app/cmd/server.go | 3 +++ 1 file changed, 3 insertions(+) diff --git a/app/cmd/server.go b/app/cmd/server.go index 3da748d..a4b8470 100644 --- a/app/cmd/server.go +++ b/app/cmd/server.go @@ -804,6 +804,9 @@ func (c *serverConfig) fillMasqHandler(hyConfig *server.Config) error { if err != nil { return configError{Field: "masquerade.proxy.url", Err: err} } + if u.Scheme != "http" && u.Scheme != "https" { + return configError{Field: "masquerade.proxy.url", Err: fmt.Errorf("unsupported protocol scheme \"%s\"", u.Scheme)} + } handler = &httputil.ReverseProxy{ Rewrite: func(r *httputil.ProxyRequest) { r.SetURL(u)