mirrors/keepassxc
1
0
Fork 0
mirror of https://github.com/keepassxreboot/keepassxc.git synced 2025-04-04 21:17:43 +03:00
Code Issues Projects Releases Packages Wiki Activity

Significantly reduce impact of FileWatcher hashing (#3724)

Browse source 
* Fix #3699

Reduce file watch hashing of open database files from every second to every 30 seconds. Additionally, only hash the first 1024 bytes of the database file. This is valid since most of the header and the entire encrypted portion are changed significantly on every save.
This commit is contained in:
Jonathan White 2019-10-30 06:40:56 -04:00 • committed by Janek Bevendorff
parent 178bea6bbc
commit 36e14157be
3 changed files with 17 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

17
src/core/FileWatcher.cpp
View file

@ -42,7 +42,7 @@ FileWatcher::FileWatcher(QObject* parent)
m_fileIgnoreDelayTimer.setSingleShot(true);
}
void FileWatcher::start(const QString& filePath, int checksumInterval)
void FileWatcher::start(const QString& filePath, int checksumIntervalSeconds, int checksumSizeKibibytes)
{
stop();
@ -63,8 +63,14 @@ void FileWatcher::start(const QString& filePath, int checksumInterval)
m_fileWatcher.addPath(filePath);
m_filePath = filePath;
// Handle file checksum
m_fileChecksumSizeBytes = checksumSizeKibibytes * 1024;
m_fileChecksum = calculateChecksum();
m_fileChecksumTimer.start(checksumInterval);
if (checksumIntervalSeconds > 0) {
m_fileChecksumTimer.start(checksumIntervalSeconds * 1000);
}
m_ignoreFileChange = false;
}
@ -131,9 +137,12 @@ QByteArray FileWatcher::calculateChecksum()
QFile file(m_filePath);
if (file.open(QFile::ReadOnly)) {
QCryptographicHash hash(QCryptographicHash::Sha256);
if (hash.addData(&file)) {
return hash.result();
if (m_fileChecksumSizeBytes > 0) {
hash.addData(file.read(m_fileChecksumSizeBytes));
} else {
hash.addData(&file);
}
return hash.result();
}
return {};
}