mirrors/keepassxc
1
0
Fork 0
mirror of https://github.com/keepassxreboot/keepassxc.git synced 2025-04-03 20:47:37 +03:00
Code Issues Projects Releases Packages Wiki Activity

Support passkeys with Bitwarden import (#11401)

Browse source
This commit is contained in:
Sami Vänttinen 2024-10-25 03:12:47 +03:00 • committed by GitHub
parent 95bae8377c
commit 6e0baf9f2c
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
14 changed files with 180 additions and 47 deletions
Download patch file Download diff file Expand all files Collapse all files

35
tests/TestImports.cpp
View file

@ -1,5 +1,5 @@
/*
* Copyright (C) 2022 KeePassXC Team <team@keepassxc.org>
* Copyright (C) 2024 KeePassXC Team <team@keepassxc.org>
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
@ -282,3 +282,36 @@ void TestImports::testBitwardenEncrypted()
}
QVERIFY(db);
}
void TestImports::testBitwardenPasskey()
{
auto bitwardenPath =
QStringLiteral("%1/%2").arg(KEEPASSX_TEST_DATA_DIR, QStringLiteral("/bitwarden_passkey_export.json"));
BitwardenReader reader;
auto db = reader.convert(bitwardenPath);
QVERIFY2(!reader.hasError(), qPrintable(reader.errorString()));
QVERIFY(db);
// Confirm Login fields
auto entry = db->rootGroup()->findEntryByPath("/webauthn.io");
QVERIFY(entry);
QCOMPARE(entry->title(), QStringLiteral("webauthn.io"));
QCOMPARE(entry->username(), QStringLiteral("KPXC_BITWARDEN"));
QCOMPARE(entry->url(), QStringLiteral("https://webauthn.io/"));
// Confirm passkey attributes
auto attr = entry->attributes();
QCOMPARE(attr->value(EntryAttributes::KPEX_PASSKEY_CREDENTIAL_ID), QStringLiteral("o-FfiyfBQq6Qz6YVrYeFTw"));
QCOMPARE(
attr->value(EntryAttributes::KPEX_PASSKEY_PRIVATE_KEY_PEM),
QStringLiteral(
"-----BEGIN PRIVATE "
"KEY-----"
"MIGHAgEAMBMGByqGSM49AgEGCCqGSM49AwEHBG0wawIBAQQgmr4GQQjerojFuf0ZouOuUllMvAwxZSZAfB6gwDYcLiehRANCAAT0WR5zVS"
"p6ieusvjkLkzaGc7fjGBmwpiuLPxR/d+ZjqMI9L2DKh+takp6wGt2x0n4jzr1KA352NZg0vjZX9CHh-----END PRIVATE KEY-----"));
QCOMPARE(attr->value(EntryAttributes::KPEX_PASSKEY_USERNAME), QStringLiteral("KPXC_BITWARDEN"));
QCOMPARE(attr->value(EntryAttributes::KPEX_PASSKEY_RELYING_PARTY), QStringLiteral("webauthn.io"));
QCOMPARE(attr->value(EntryAttributes::KPEX_PASSKEY_USER_HANDLE),
QStringLiteral("aTFtdmFnOHYtS2dxVEJ0by1rSFpLWGg0enlTVC1iUVJReDZ5czJXa3c2aw"));
}

3
tests/TestImports.h
View file

@ -1,5 +1,5 @@
/*
* Copyright (C) 2022 KeePassXC Team <team@keepassxc.org>
* Copyright (C) 2024 KeePassXC Team <team@keepassxc.org>
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
@ -30,6 +30,7 @@ private slots:
void testOPVault();
void testBitwarden();
void testBitwardenEncrypted();
void testBitwardenPasskey();
};
#endif /* TEST_IMPORTS_H */

49
tests/data/bitwarden_passkey_export.json Normal file
View file

@ -0,0 +1,49 @@
{
"encrypted": false,
"folders": [],
"items": [
{
"passwordHistory": null,
"revisionDate": "2024-10-23T16:38:08.870Z",
"creationDate": "2024-10-23T16:38:08.606Z",
"deletedDate": null,
"id": "a8e579f0-98c2-4ac9-a126-b212011225f8",
"organizationId": null,
"folderId": null,
"type": 1,
"reprompt": 0,
"name": "webauthn.io",
"notes": null,
"favorite": false,
"login": {
"fido2Credentials": [
{
"credentialId": "a3e15f8b-27c1-42ae-90cf-a615ad87854f",
"keyType": "public-key",
"keyAlgorithm": "ECDSA",
"keyCurve": "P-256",
"keyValue": "MIGHAgEAMBMGByqGSM49AgEGCCqGSM49AwEHBG0wawIBAQQgmr4GQQjerojFuf0ZouOuUllMvAwxZSZAfB6gwDYcLiehRANCAAT0WR5zVSp6ieusvjkLkzaGc7fjGBmwpiuLPxR_d-ZjqMI9L2DKh-takp6wGt2x0n4jzr1KA352NZg0vjZX9CHh",
"rpId": "webauthn.io",
"userHandle": "aTFtdmFnOHYtS2dxVEJ0by1rSFpLWGg0enlTVC1iUVJReDZ5czJXa3c2aw",
"userName": "KPXC_BITWARDEN",
"counter": "0",
"rpName": "webauthn.io",
"userDisplayName": "KPXC_BITWARDEN",
"discoverable": "true",
"creationDate": "2024-10-23T16:38:08.617Z"
}
],
"uris": [
{
"match": null,
"uri": "https://webauthn.io/"
}
],
"username": "KPXC_BITWARDEN",
"password": null,
"totp": null
},
"collectionIds": null
}
]
}