From af3b4074e2b42c40261fb482aa90226145e21849 Mon Sep 17 00:00:00 2001 From: Carlo Teubner Date: Wed, 12 Jun 2024 22:21:53 +0100 Subject: [PATCH] Fix passphrase generator test (#10890) * Fix passphrase generator test Previously, the test case was assuming the wrong regex. In particular, the default word list (eff_large.wordlist) contains several words that contain dashes. Adjust the regex used in the test to reflect this. This should fix rare test failures --- tests/TestPassphraseGenerator.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/TestPassphraseGenerator.cpp b/tests/TestPassphraseGenerator.cpp index 9b1ed8ada..ffa21e9b7 100644 --- a/tests/TestPassphraseGenerator.cpp +++ b/tests/TestPassphraseGenerator.cpp @@ -49,6 +49,6 @@ void TestPassphraseGenerator::testWordCase() generator.setWordCase(PassphraseGenerator::TITLECASE); passphrase = generator.generatePassphrase(); - QRegularExpression regex("^([A-Z][a-z]* ?)+$"); - QVERIFY(regex.match(passphrase).hasMatch()); + QRegularExpression regex("^(?:[A-Z][a-z-]* )*[A-Z][a-z-]*$"); + QVERIFY2(regex.match(passphrase).hasMatch(), qPrintable(passphrase)); }