mirrors/keepassxc
1
0
Fork 0
mirror of https://github.com/keepassxreboot/keepassxc.git synced 2025-04-05 21:47:38 +03:00
Code Issues Projects Releases Packages Wiki Activity

Add filter for showing all password in health report

Browse source
This commit is contained in:
shotor 2025-03-08 02:05:02 +01:00
parent 33a3796074
commit d9b780b47b
4 changed files with 36 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

13
src/core/PasswordHealth.cpp
View file

@ -47,21 +47,28 @@ PasswordHealth::PasswordHealth(const QString& pwd)
void PasswordHealth::init(double entropy) void PasswordHealth::init(double entropy)
{ {
m_score = m_entropy = entropy; m_score = m_entropy = entropy;
m_scoreDetails << QObject::tr("Password entropy is %1 bits").arg(QString::number(m_entropy, 'f', 2));
switch (quality()) { switch (quality()) {
case Quality::Excellent:
m_scoreReasons << QObject::tr("Excellent password");
break;
case Quality::Good:
m_scoreReasons << QObject::tr("Good password");
break;
case Quality::Bad: case Quality::Bad:
case Quality::Poor: case Quality::Poor:
m_scoreReasons << QObject::tr("Very weak password"); m_scoreReasons << QObject::tr("Very weak password");
m_scoreDetails << QObject::tr("Password entropy is %1 bits").arg(QString::number(m_entropy, 'f', 2));
break; break;
case Quality::Weak: case Quality::Weak:
m_scoreReasons << QObject::tr("Weak password"); m_scoreReasons << QObject::tr("Weak password");
m_scoreDetails << QObject::tr("Password entropy is %1 bits").arg(QString::number(m_entropy, 'f', 2));
break; break;
default: default:
// No reason or details for good and excellent passwords // should never happen
break; break;
} }
} }

14
src/gui/reports/ReportsWidgetHealthcheck.cpp
View file

@ -124,12 +124,9 @@ Health::Health(QSharedPointer<Database> db)
m_anyExcludedEntries = true; m_anyExcludedEntries = true;
} }
// Add entry if its password isn't at least "good"
if (item->health->quality() < PasswordHealth::Quality::Good) {
m_items.append(item); m_items.append(item);
} }
} }
}
// Sort the result so that the worst passwords (least score) // Sort the result so that the worst passwords (least score)
// are at the top // are at the top
@ -154,6 +151,7 @@ ReportsWidgetHealthcheck::ReportsWidgetHealthcheck(QWidget* parent)
connect(m_ui->healthcheckTableView, SIGNAL(doubleClicked(QModelIndex)), SLOT(emitEntryActivated(QModelIndex))); connect(m_ui->healthcheckTableView, SIGNAL(doubleClicked(QModelIndex)), SLOT(emitEntryActivated(QModelIndex)));
connect(m_ui->showExcluded, SIGNAL(stateChanged(int)), this, SLOT(calculateHealth())); connect(m_ui->showExcluded, SIGNAL(stateChanged(int)), this, SLOT(calculateHealth()));
connect(m_ui->showExpired, SIGNAL(stateChanged(int)), this, SLOT(calculateHealth())); connect(m_ui->showExpired, SIGNAL(stateChanged(int)), this, SLOT(calculateHealth()));
connect(m_ui->showWeakOnly, SIGNAL(stateChanged(int)), this, SLOT(calculateHealth()));
new QShortcut(Qt::Key_Delete, this, SLOT(deleteSelectedEntries())); new QShortcut(Qt::Key_Delete, this, SLOT(deleteSelectedEntries()));
} }
@ -267,6 +265,16 @@ void ReportsWidgetHealthcheck::calculateHealth()
continue; continue;
} }
if (m_ui->showWeakOnly->isChecked()) {
switch (item->entry->passwordHealth()->quality()) {
case PasswordHealth::Quality::Good:
case PasswordHealth::Quality::Excellent:
continue;
default:
break;
}
}
// Show the entry in the report // Show the entry in the report
addHealthRow(item->health, item->group, item->entry, item->exclude); addHealthRow(item->health, item->group, item->entry, item->exclude);
} }

10
src/gui/reports/ReportsWidgetHealthcheck.ui
View file

@ -54,6 +54,16 @@
</attribute> </attribute>
</widget> </widget>
</item> </item>
<item>
<widget class="QCheckBox" name="showWeakOnly">
<property name="text">
<string>Show weak passwords only</string>
</property>
<property name="checked">
<bool>true</bool>
</property>
</widget>
</item>
<item> <item>
<widget class="QCheckBox" name="showExpired"> <widget class="QCheckBox" name="showExpired">
<property name="text"> <property name="text">

8
tests/TestPasswordHealth.cpp
View file

@ -54,13 +54,13 @@ void TestPasswordHealth::testNoDb()
QCOMPARE(good.score(), 78); QCOMPARE(good.score(), 78);
QCOMPARE(int(good.entropy()), 78); QCOMPARE(int(good.entropy()), 78);
QCOMPARE(good.quality(), PasswordHealth::Quality::Good); QCOMPARE(good.quality(), PasswordHealth::Quality::Good);
QVERIFY(good.scoreReason().isEmpty()); QVERIFY(!good.scoreReason().isEmpty());
QVERIFY(good.scoreDetails().isEmpty()); QVERIFY(!good.scoreDetails().isEmpty());
const auto excellent = PasswordHealth("prompter-ream-oversleep-step-extortion-quarrel-reflected-prefix"); const auto excellent = PasswordHealth("prompter-ream-oversleep-step-extortion-quarrel-reflected-prefix");
QCOMPARE(excellent.score(), 164); QCOMPARE(excellent.score(), 164);
QCOMPARE(int(excellent.entropy()), 164); QCOMPARE(int(excellent.entropy()), 164);
QCOMPARE(excellent.quality(), PasswordHealth::Quality::Excellent); QCOMPARE(excellent.quality(), PasswordHealth::Quality::Excellent);
QVERIFY(excellent.scoreReason().isEmpty()); QVERIFY(!excellent.scoreReason().isEmpty());
QVERIFY(excellent.scoreDetails().isEmpty()); QVERIFY(!excellent.scoreDetails().isEmpty());
} }