Minor documentation and script cleanups (#6868)

* Remove mention of no longer used IRC network

Channels exist on matrix, and on libera.chat now.

* Correctly match only files with .png extension

The current search would match files such as 'createpng'.

* Fix comparison in script

The result was always false, due to comparing a literal string instead of a variable.

* Use correct license files from upstream

Correct license files obtained from:
https://www.gnu.org/licenses/old-licenses/gpl-2.0.txt
https://www.gnu.org/licenses/gpl-3.0.txt
https://www.gnu.org/licenses/old-licenses/lgpl-2.1.txt
https://www.gnu.org/licenses/lgpl-3.0.txt

* Refresh several shell scripts

This fixes several shellcheck warnings, as well as makes the code more
robust and have consistent codestyle between all the files.

* Trim excess whitespace

share/icons/minify.sh

@@ -18,4 +18,4 @@ minify -o icons/database --match=.svg icons/database
 
 # Crush PNG's
 echo "Crushing PNG's..."
-find "." -iname '*png' -exec pngcrush -ow -brute {} \;
+find . -iname '*.png' -exec pngcrush -ow -brute {} \;

share/translations/update.sh

@@ -16,23 +16,23 @@
 # along with this program.  If not, see <http://www.gnu.org/licenses/>.
 #
 
-BASEDIR="$(dirname $0)"
+BASEDIR=$(dirname "$0")
 
 PUSH=true
 PULL=true
 UPDATE=true
 
-if [ "$1" == "push" ]; then
+if [[ $1 == "push" ]]; then
     PULL=false
-elif [ "$1" == "pull" ]; then
+elif [[ $1 == "pull" ]]; then
     PUSH=false
     UPDATE=false
-elif [ "$1" == "update" ]; then
+elif [[ $1 == "update" ]]; then
     PUSH=false
     PULL=false
-elif [ "$1" != "" ]; then
+elif [[ $1 != "" ]]; then
     echo "Unknown command '${1}'"
-    echo "Usage: $(basename $0) [update|pull|push] [additional tx options]"
+    echo "Usage: $(basename "$0") [update|pull|push] [additional tx options]"
     exit 1
 fi
 
@@ -45,7 +45,7 @@ if $UPDATE; then
 
     LUPDATE=lupdate-qt5
     command -v $LUPDATE > /dev/null
-    if [ $? -ne 0 ]; then
+    if [[ $? -ne 0 ]]; then
         LUPDATE=lupdate
     fi
     $LUPDATE -no-ui-lines -disable-heuristic similartext -locations none -no-obsolete src -ts share/translations/keepassx_en.ts

share/windows/create-ico.sh

@@ -4,28 +4,28 @@ NC='\033[0m'
 RED='\033[0;31m'
 YELLOW='\033[0;33m'
 
-if [[ -z "$1" ]]; then
+if [[ -z $1 ]]; then
   echo -e "${RED}You must include an SVG file to convert!${NC}"
   exit 1
 fi
 
 outfile=$2
-if [[ -z "outfile" ]]; then
+if [[ -z $outfile ]]; then
   outfile="logo.ico"
 fi
 
-if ! command -v "inkscape" &> /dev/null; then
+if ! command -v inkscape &> /dev/null; then
   echo -e "${YELLOW}Could not find inkscape; $outfile not built!${NC}"
   exit 0
 fi
 
 echo "Generating $outfile from $1..."
 size_list=(16 24 32 48 64 128 256)
-for size in ${size_list[@]}; do
-    inkscape -z -e $size.png -w $size -h $size "$1" >/dev/null 2>/dev/null
+for size in "${size_list[@]}"; do
+  inkscape -z -e $size.png -w $size -h $size "$1" >/dev/null 2>/dev/null
 done
 
-images=`printf "%s.png " "${size_list[@]}"`
+images=$(printf "%s.png " "${size_list[@]}")
 convert $images $outfile
 
 rm $images

share/windows/wix-template.xml

@@ -61,7 +61,7 @@
             <Directory Id="ProgramMenuFolder">
                 <Directory Id="ApplicationProgramsFolder" Name="KeePassXC">
                     <Component Id="ApplicationShortcuts" Guid="*">
-                        <Shortcut Id="ApplicationStartMenuShortcut" 
+                        <Shortcut Id="ApplicationStartMenuShortcut"
                             Name="KeePassXC"
                             Target="[#CM_FP_KeePassXC.exe]"
                             WorkingDirectory="INSTALL_ROOT"/>