Minor documentation and script cleanups (#6868)

* Remove mention of no longer used IRC network

Channels exist on matrix, and on libera.chat now.

* Correctly match only files with .png extension

The current search would match files such as 'createpng'.

* Fix comparison in script

The result was always false, due to comparing a literal string instead of a variable.

* Use correct license files from upstream

Correct license files obtained from:
https://www.gnu.org/licenses/old-licenses/gpl-2.0.txt
https://www.gnu.org/licenses/gpl-3.0.txt
https://www.gnu.org/licenses/old-licenses/lgpl-2.1.txt
https://www.gnu.org/licenses/lgpl-3.0.txt

* Refresh several shell scripts

This fixes several shellcheck warnings, as well as makes the code more
robust and have consistent codestyle between all the files.

* Trim excess whitespace

utils/keepassxc-cr-recovery/README.md

@@ -17,4 +17,4 @@ Then just run
 ```shell
 keepass-cr-recovery path-to-your-password-database path-of-the-new-keyfile
 ```
-It will prompt for the challenge-response secret. You will get a keyfile at the specified destination path. Then, to unlock your database in KeePassXC, you need to check "key file" instead of "challenge response" and load the file. 
+It will prompt for the challenge-response secret. You will get a keyfile at the specified destination path. Then, to unlock your database in KeePassXC, you need to check "key file" instead of "challenge response" and load the file.

utils/keepassxc-kdewallet

@@ -4,10 +4,10 @@
 ### change the path to suit your installation or set KDBX_SEARCH before calling ###
 : ${KDBX_SEARCH:=~/.KeePass/*.kdbx}
 
-PROG="${0##*/}"
+PROG=${0##*/}
 KEEPASSXC=$(which -a keepassxc | sed -e "\\,$0,d" -e 'q')
 
-function daemon_main {
+daemon_main() {
   # open kdewallet
   handle=$(qdbus org.kde.kwalletd5 /modules/kwalletd5 org.kde.KWallet.open kdewallet 0 "$PROG")
   while [[ true != $(qdbus org.kde.kwalletd5 /modules/kwalletd5 org.kde.KWallet.isOpen kdewallet) ]]; do
@@ -27,7 +27,7 @@ function daemon_main {
   qdbus org.kde.kwalletd5 /modules/kwalletd5 org.kde.KWallet.close "$handle" "false" "$PROG"
 }
 
-if [[ '-d' = "$1" ]]; then
+if [[ $1 == '-d' ]]; then
   exec >&~/tmp/$PROG.log
   set -vx
   daemon_main

utils/keepassxc-keychain

@@ -4,10 +4,10 @@
 ### change the path to suit your installation or set KDBX_SEARCH before calling ###
 : ${KDBX_SEARCH:=~/.KeePass/*.kdbx}
 
-PROG="$(basename $0)"
+PROG=$(basename "$0")
 KeePassXC=$(ls -f {/usr/local,/Applications}/KeePassXC.app/Contents/MacOS/KeePassXC 2>/dev/null | head -1)
 
-function daemon_main {
+daemon_main() {
   declare -A DBs
   for DBPATH in $KDBX_SEARCH; do
     DBs[$(python -c  "import os; print os.path.realpath('$DBPATH')")]=$(security find-generic-password -a $USER -s "${DBPATH##*/}" -w)
@@ -18,7 +18,7 @@ function daemon_main {
   $KeePassXC --pw-stdin "${!DBs[@]}" <<<"${DBs[*]}" &
 }
 
-if [[ '-d' = "$1" ]]; then
+if [[ $1 == '-d' ]]; then
   exec >&~/tmp/$PROG.log
   set -vx
   daemon_main

utils/keepassxc-snap-helper.sh

@@ -118,9 +118,9 @@ BROWSER=$(whiptail \
 clear
 
 exitstatus=$?
-if [ $exitstatus = 0 ]; then
+if [[ $exitstatus == 0 ]]; then
     # Configure settings for the chosen browser
-    case "$BROWSER" in
+    case $BROWSER in
         1) setupFirefox ;;
         2) setupChrome ;;
         3) setupChromium ;;
@@ -132,7 +132,7 @@ if [ $exitstatus = 0 ]; then
     # Install the JSON file
     cd ~
     mkdir -p "$INSTALL_DIR"
-    echo "$JSON_OUT" > ${INSTALL_DIR}/${INSTALL_FILE}
+    echo "$JSON_OUT" > "${INSTALL_DIR}/${INSTALL_FILE}"
 
     whiptail \
         --title "Installation Complete" \

utils/makeappicons.sh

@@ -42,22 +42,22 @@ NC='\033[0m'
 RED='\033[0;31m'
 YELLOW='\033[0;33m'
 
-if [ $# != 1 ];then
+if [[ $# != 1 ]]; then
     echo "Usage: $0 MATERIAL"
     echo "MATERIAL is the directory containing the material icons repository"
     echo "(git clone https://github.com/Templarian/MaterialDesign.git)".
     exit
 fi
 
-MATERIAL="$1"
-if [ ! -d "$MATERIAL" ];then
+MATERIAL=$1
+if [[ ! -d $MATERIAL ]]; then
     echo -e "${RED}Material Icons directory does not exist: ${MATERIAL}${NC}"
     exit 1
 fi
 
 # Check destination dir
 DSTDIR=share/icons/application
-if [ ! -d "$DSTDIR" ];then
+if [[ ! -d $DSTDIR ]]; then
     echo -e "${RED}Please invoke this script from the KeePassXC source root directory.${NC}"
     exit 1
 fi
@@ -69,7 +69,7 @@ fi
 # extension, e. g. "folder-plus") to stdout.
 # If the icon name is unknown, outputs nothing.
 map() {
-    case "$1" in
+    case $1 in
         application-exit)                   echo exit-run                       ;;
         auto-type)                          echo keyboard-variant               ;;
         bugreport)                          echo bug-outline                    ;;
@@ -148,27 +148,27 @@ map() {
 }
 
 # Now do the actual work
-find $DSTDIR -type f -name "*.svg" | while read -r DST;do
+find "$DSTDIR" -type f -name "*.svg" | while read -r DST; do
 
     # Find the icon name (base name without extender)
-    NAME=$(basename $DST .svg)
+    NAME=$(basename "$DST" .svg)
 
     # Find the base name of the svg file for this icon
-    MAT=$(map $NAME)
-    if [[ -z $MAT ]];then
+    MAT=$(map "$NAME")
+    if [[ -z $MAT ]]; then
         echo -e "${YELLOW}Warning: No MaterialDesign mapping for ${NAME}${NC}"
         continue
     fi
 
     # So the source file is:
     SRC="$MATERIAL/svg/$MAT.svg"
-    if [ ! -f "$SRC" ];then
+    if [[ ! -f $SRC ]]; then
         echo -e "${RED}Error: Source for ${NAME} doesn't exist: ${SRC}${NC}"
         continue
     fi
 
     # Replace the icon file with the source file
-    cp "$SRC" "$DST" || exit
+    cp -- "$SRC" "$DST" || exit
     echo "Copied icon for ${NAME}"
 
 done

utils/makedbicons.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 # Assemble database icons from the icons8 collection
 # by Wolfram Rösler 2020-04-30
 
@@ -7,7 +7,7 @@ RED='\033[0;31m'
 YELLOW='\033[0;33m'
 
 # Check parameters
-if [[ $# != 1 ]];then
+if [[ $# != 1 ]]; then
     echo "Usage: $0 ICONS8"
     echo "ICONS8 is the directory containing the Icons8 flat-color-icons repository"
     echo "(git clone https://github.com/icons8/flat-color-icons)".
@@ -15,15 +15,15 @@ if [[ $# != 1 ]];then
 fi
 
 # Check source directory
-SRCDIR="$1"
-if [ ! -d "$SRCDIR" ];then
+SRCDIR=$1
+if [[ ! -d $SRCDIR ]]; then
     echo -e "${RED}icons8 directory doesn't exist: ${SRCDIR}${NC}"
     exit 1
 fi
 
 # Check destination directory
 DSTDIR=share/icons/database
-if [ ! -d "$DSTDIR" ];then
+if [[ ! -d $DSTDIR ]]; then
     echo -e "${RED}Please invoke this script from the KeePassXC source root directory.${NC}"
     exit 1
 fi
@@ -39,7 +39,7 @@ fi
 copy() {
     # The source file is:
     SRC="${SRCDIR}/svg/${1}.svg"
-    if [ ! -f "$SRC" ];then
+    if [[ ! -f $SRC ]]; then
         echo -e "${RED}Cannot find source icon for ${2} (${SRC})${NC}"
         return
     fi
@@ -47,7 +47,7 @@ copy() {
     # Copy the source file to the destination, keeping
     # the source file's extension
     DST="$DSTDIR/${2}.svg"
-    cp $SRC $DST
+    cp -- "$SRC" "$DST"
     echo "Copied icon for ${1} to ${DST}"
 }