mirrors/keepassxc
1
0
Fork 0
mirror of https://github.com/keepassxreboot/keepassxc.git synced 2025-04-03 20:47:37 +03:00
Code Issues Projects Releases Packages Wiki Activity

Add Proton Pass importer

Browse source 
* Closes #10465
This commit is contained in:
Jonathan White 2024-08-25 08:17:16 -04:00
parent 9e29b5c7b6
commit edab0faa94
16 changed files with 587 additions and 38 deletions
Download patch file Download diff file Expand all files Collapse all files

56
tests/TestImports.cpp
View file

@ -25,6 +25,7 @@
#include "format/BitwardenReader.h"
#include "format/OPUXReader.h"
#include "format/OpVaultReader.h"
#include "format/ProtonPassReader.h"
#include <QJsonObject>
#include <QList>
@ -315,3 +316,58 @@ void TestImports::testBitwardenPasskey()
QCOMPARE(attr->value(EntryAttributes::KPEX_PASSKEY_USER_HANDLE),
QStringLiteral("aTFtdmFnOHYtS2dxVEJ0by1rSFpLWGg0enlTVC1iUVJReDZ5czJXa3c2aw"));
}
void TestImports::testProtonPass()
{
auto protonPassPath =
QStringLiteral("%1/%2").arg(KEEPASSX_TEST_DATA_DIR, QStringLiteral("/protonpass_export.json"));
ProtonPassReader reader;
auto db = reader.convert(protonPassPath);
QVERIFY2(!reader.hasError(), qPrintable(reader.errorString()));
QVERIFY(db);
// Confirm Login fields
auto entry = db->rootGroup()->findEntryByPath("/Personal/Test Login");
QVERIFY(entry);
QCOMPARE(entry->title(), QStringLiteral("Test Login"));
QCOMPARE(entry->username(), QStringLiteral("Username"));
QCOMPARE(entry->password(), QStringLiteral("Password"));
QCOMPARE(entry->url(), QStringLiteral("https://example.com/"));
QCOMPARE(entry->notes(), QStringLiteral("My login secure note."));
// Check extra URL's
QCOMPARE(entry->attribute("KP2A_URL_1"), QStringLiteral("https://example2.com/"));
// Check TOTP
QVERIFY(entry->hasTotp());
// Check attributes
auto attr = entry->attributes();
QVERIFY(attr->isProtected("hidden field"));
QCOMPARE(attr->value("second 2fa secret"), QStringLiteral("TOTPCODE"));
// NOTE: Proton Pass does not export attachments
// NOTE: Proton Pass does not export expiration dates
// Confirm Secure Note
entry = db->rootGroup()->findEntryByPath("/Personal/My Secure Note");
QVERIFY(entry);
QCOMPARE(entry->notes(), QStringLiteral("Secure note contents."));
// Confirm Credit Card
entry = db->rootGroup()->findEntryByPath("/Personal/Test Card");
QVERIFY(entry);
QCOMPARE(entry->username(), QStringLiteral("1234222233334444"));
QCOMPARE(entry->password(), QStringLiteral("333"));
attr = entry->attributes();
QCOMPARE(attr->value("card_cardholderName"), QStringLiteral("Test name"));
QCOMPARE(attr->value("card_expirationDate"), QStringLiteral("2025-01"));
QCOMPARE(attr->value("card_pin"), QStringLiteral("1234"));
QVERIFY(attr->isProtected("card_pin"));
// Confirm Expired (deleted) entry
entry = db->rootGroup()->findEntryByPath("/Personal/My Deleted Note");
QVERIFY(entry);
QTRY_VERIFY(entry->isExpired());
// Confirm second group (vault)
entry = db->rootGroup()->findEntryByPath("/Test/Other vault login");
QVERIFY(entry);
}

1
tests/TestImports.h
View file

@ -31,6 +31,7 @@ private slots:
void testBitwarden();
void testBitwardenEncrypted();
void testBitwardenPasskey();
void testProtonPass();
};
#endif /* TEST_IMPORTS_H */

173
tests/data/protonpass_export.json Normal file
View file

@ -0,0 +1,173 @@
{
"version": "1.21.2",
"userId": "USER_ID",
"encrypted": false,
"vaults": {
"VAULT_A": {
"name": "Personal",
"description": "Personal vault",
"display": {
"color": 0,
"icon": 0
},
"items": [
{
"itemId": "yZENmDjtmZGODNy3Q_CZiPAF_IgINq8w-R-qazrOh-Nt9YJeVF3gu07ovzDS4jhYHoMdOebTw5JkYPGgIL1mwQ==",
"shareId": "SN5uWo4WZF2uT5wIDqtbdpkjuxCbNTOIdf-JQ_DYZcKYKURHiZB5csS1a1p9lklvju9ni42l08IKzwQG0B2ySg==",
"data": {
"metadata": {
"name": "Test Login",
"note": "My login secure note.",
"itemUuid": "e8ee1a0c"
},
"extraFields": [
{
"fieldName": "non-hidden field",
"type": "text",
"data": {
"content": "non-hidden field content"
}
},
{
"fieldName": "hidden field",
"type": "hidden",
"data": {
"content": "hidden field content"
}
},
{
"fieldName": "second 2fa secret",
"type": "totp",
"data": {
"totpUri": "TOTPCODE"
}
}
],
"type": "login",
"content": {
"itemEmail": "Email",
"password": "Password",
"urls": [
"https://example.com/",
"https://example2.com/"
],
"totpUri": "otpauth://totp/Test%20Login%20-%20Personal%20Vault:Username?issuer=Test%20Login%20-%20Personal%20Vault&secret=TOTPCODE&algorithm=SHA1&digits=6&period=30",
"passkeys": [],
"itemUsername": "Username"
}
},
"state": 1,
"aliasEmail": null,
"contentFormatVersion": 1,
"createTime": 1689182868,
"modifyTime": 1689182868,
"pinned": true
},
{
"itemId": "xqq_Bh8RxNMBerkiMvRdH427yswZznjYwps-f6C5D8tmKiPgMxCSPNz1BOd4nRJ309gciDiPhXcCVWOyfJ66ZA==",
"shareId": "SN5uWo4WZF2uT5wIDqtbdpkjuxCbNTOIdf-JQ_DYZcKYKURHiZB5csS1a1p9lklvju9ni42l08IKzwQG0B2ySg==",
"data": {
"metadata": {
"name": "My Secure Note",
"note": "Secure note contents.",
"itemUuid": "ad618070"
},
"extraFields": [],
"type": "note",
"content": {}
},
"state": 1,
"aliasEmail": null,
"contentFormatVersion": 1,
"createTime": 1689182908,
"modifyTime": 1689182908,
"pinned": false
},
{
"itemId": "ZmGzd-HNQYTr6wmfWlSfiStXQLqGic_PYB2Q2T_hmuRM2JIA4pKAPJcmFafxJrDpXxLZ2EPjgD6Noc9a0U6AVQ==",
"shareId": "SN5uWo4WZF2uT5wIDqtbdpkjuxCbNTOIdf-JQ_DYZcKYKURHiZB5csS1a1p9lklvju9ni42l08IKzwQG0B2ySg==",
"data": {
"metadata": {
"name": "Test Card",
"note": "Credit Card Note",
"itemUuid": "d8f45370"
},
"extraFields": [],
"type": "creditCard",
"content": {
"cardholderName": "Test name",
"cardType": 0,
"number": "1234222233334444",
"verificationNumber": "333",
"expirationDate": "2025-01",
"pin": "1234"
}
},
"state": 1,
"aliasEmail": null,
"contentFormatVersion": 1,
"createTime": 1691001643,
"modifyTime": 1691001643,
"pinned": true
},
{
"itemId": "xqq_Bh8RxNMBerkiMvRdH427yswZznjYwps-f6C5D8tmKiPgMxCSPNz1BOd4nRJ309gciDiPhXcCVWOyfJ66ZA==",
"shareId": "SN5uWo4WZF2uT5wIDqtbdpkjuxCbNTOIdf-JQ_DYZcKYKURHiZB5csS1a1p9lklvju9ni42l08IKzwQG0B2ySg==",
"data": {
"metadata": {
"name": "My Deleted Note",
"note": "Secure note contents.",
"itemUuid": "ad618070"
},
"extraFields": [],
"type": "note",
"content": {}
},
"state": 2,
"aliasEmail": null,
"contentFormatVersion": 1,
"createTime": 1689182908,
"modifyTime": 1689182908,
"pinned": false
}
]
},
"VAULT_B": {
"name": "Test",
"description": "",
"display": {
"color": 4,
"icon": 2
},
"items": [
{
"itemId": "U_J8-eUR15sC-PjUhjVcixDcayhjGuoerUZCr560RlAi0ZjBNkSaSKAytVzZn4E0hiFX1_y4qZbUetl6jO3aJw==",
"shareId": "OJz-4MnPqAuYnyemhctcGDlSLJrzsTnf2FnFSwxh1QP_oth9xyGDc2ZAqCv5FnqkVgTNHT5aPj62zcekNemfNw==",
"data": {
"metadata": {
"name": "Other vault login",
"note": "",
"itemUuid": "f3429d44"
},
"extraFields": [],
"type": "login",
"content": {
"itemEmail": "other vault username",
"password": "other vault password",
"urls": [],
"totpUri": "JBSWY3DPEHPK3PXP",
"passkeys": [],
"itemUsername": ""
}
},
"state": 1,
"aliasEmail": null,
"contentFormatVersion": 1,
"createTime": 1689182949,
"modifyTime": 1689182949,
"pinned": false
}
]
}
}
}

45
tests/gui/TestGui.cpp
View file

@ -489,35 +489,38 @@ void TestGui::testOpenRemoteDatabase()
QTest::mouseClick(openRemoteButton, Qt::LeftButton);
QApplication::processEvents();
TEST_MODAL_NO_WAIT(
ImportWizard * wizard; QTRY_VERIFY(wizard = m_tabWidget->findChild<ImportWizard*>());
TEST_MODAL_NO_WAIT(ImportWizard * wizard; QTRY_VERIFY(wizard = m_tabWidget->findChild<ImportWizard*>());
auto* importTypeList = wizard->currentPage()->findChild<QListWidget*>("importTypeList");
QVERIFY(importTypeList);
importTypeList->scrollToBottom();
auto* importTypeList = wizard->currentPage()->findChild<QListWidget*>("importTypeList");
QVERIFY(importTypeList);
QListWidgetItem* remoteOption = importTypeList->item(importTypeList->count() - 1);
QRect remoteOptionRect = importTypeList->visualItemRect(remoteOption);
QTest::mouseClick(importTypeList->viewport(), Qt::LeftButton, nullptr, remoteOptionRect.center());
for (int i = 0; i < importTypeList->count(); ++i) {
auto item = importTypeList->item(i);
if (item->data(Qt::UserRole) == ImportWizard::IMPORT_REMOTE) {
importTypeList->setCurrentItem(item);
break;
}
}
auto* downloadCommandEdit = wizard->currentPage()->findChild<QLineEdit*>("downloadCommand");
QVERIFY(downloadCommandEdit);
QTest::keyClicks(downloadCommandEdit, sourceToSync);
auto* downloadCommandEdit = wizard->currentPage()->findChild<QLineEdit*>("downloadCommand");
QVERIFY(downloadCommandEdit);
QTest::keyClicks(downloadCommandEdit, sourceToSync);
auto* temporaryDatabaseRadio = wizard->currentPage()->findChild<QRadioButton*>("temporaryDatabaseRadio");
QVERIFY(temporaryDatabaseRadio);
QTest::mouseClick(temporaryDatabaseRadio, Qt::LeftButton);
auto* temporaryDatabaseRadio =
wizard->currentPage()->findChild<QRadioButton*>("temporaryDatabaseRadio");
QVERIFY(temporaryDatabaseRadio);
QTest::mouseClick(temporaryDatabaseRadio, Qt::LeftButton);
auto* passwordEdit = wizard->currentPage()->findChild<QLineEdit*>("passwordEdit");
QVERIFY(passwordEdit);
QTest::keyClicks(passwordEdit, "a");
QTest::keyClick(passwordEdit, Qt::Key_Enter);
auto* passwordEdit = wizard->currentPage()->findChild<QLineEdit*>("passwordEdit");
QVERIFY(passwordEdit);
QTest::keyClicks(passwordEdit, "a");
QTest::keyClick(passwordEdit, Qt::Key_Enter);
QApplication::processEvents();
QApplication::processEvents();
QVERIFY(wizard->currentPage()->findChildren<QTableWidget*>().count() > 0);
QVERIFY(wizard->currentPage()->findChildren<QTableWidget*>().count() > 0);
QTest::keyClick(passwordEdit, Qt::Key_Enter););
QTest::keyClick(passwordEdit, Qt::Key_Enter););
// remote database has been opened
QTRY_COMPARE(m_tabWidget->tabText(m_tabWidget->currentIndex()), QString("SyncDatabase [Temporary]"));