mirrors/keepassxc
1
0
Fork 0
mirror of https://github.com/keepassxreboot/keepassxc.git synced 2025-04-04 04:57:39 +03:00
Code Issues Projects Releases Packages Wiki Activity
keepassxc/src/gui
History
Janek Bevendorff d612cad09a
Refactor Database and Database widgets (#2491) 
The Database, DatabaseWidget, and DatabaseTabWidget classes share many responsibilities in inconsistent ways resulting in impenetrable and unmaintainable code and a diverse set of bugs and architecture restrictions. This patch reworks the architecture, responsibilities of, and dependencies between these classes.

The core changes are:

* Move loading and saving logic from widgets into the Database class
* Get rid of the DatabaseManagerStruct and move all the information contained in it into the Database
* Let database objects keep track of modifications and dirty/clean state instead of handing this to external widgets
* Move GUI interactions for loading and saving from the DatabaseTabWidget into the DatabaseWidget (resolves #2494 as a side-effect)
* Heavily clean up DatabaseTabWidget and degrade it to a slightly glorified QTabWidget
* Use QSharedPointers for all Database objects
* Remove the modifiedImmediate signal and replace it with a markAsModified() method
* Implement proper tabName() method instead of reading back titles from GUI widgets (resolves #1389 and its duplicates #2146 #855)
* Fix unwanted AES-KDF downgrade if database uses Argon2 and has CustomData
* Improve code

This patch is also the first major step towards solving issues #476 and #2322.
2018-11-22 11:47:31 +01:00
..
csvImport Refactor Database and Database widgets (#2491) 2018-11-22 11:47:31 +01:00
dbsettings Refactor Database and Database widgets (#2491) 2018-11-22 11:47:31 +01:00
entry Refactor Database and Database widgets (#2491) 2018-11-22 11:47:31 +01:00
group Refactor Database and Database widgets (#2491) 2018-11-22 11:47:31 +01:00
masterkey Add search help pop-up 2018-11-17 09:04:15 -05:00
settings Add a new database settings wizard 2018-09-25 21:12:47 +02:00
widgets Refactor Database and Database widgets (#2491) 2018-11-22 11:47:31 +01:00
wizard Refactor Database and Database widgets (#2491) 2018-11-22 11:47:31 +01:00
AboutDialog.cpp Reduce function call overhead 2018-10-31 14:23:06 +01:00
AboutDialog.h Formatting the code. 2018-03-31 16:01:30 -04:00
AboutDialog.ui Enhancements to About dialog and add settings button to toolbar 2018-08-20 21:27:37 -04:00
Application.cpp Add search help pop-up 2018-11-17 09:04:15 -05:00
Application.h Add search help pop-up 2018-11-17 09:04:15 -05:00
ApplicationSettingsWidget.cpp Replace old for-loops with range-based for-loops 2018-10-31 14:23:06 +01:00
ApplicationSettingsWidget.h Add a new database settings wizard 2018-09-25 21:12:47 +02:00
ApplicationSettingsWidgetGeneral.ui Multiple fixes to MainWindow and some cleanup 2018-10-20 15:30:48 +02:00
ApplicationSettingsWidgetSecurity.ui Fix multiple issues with entries and keyboard shortcuts (#2431) 2018-11-16 10:00:59 -05:00
CategoryListWidget.cpp Normalize signature of SIGNAL() and SLOT() 2018-10-31 15:16:04 +01:00
CategoryListWidget.h Improve readability and type-safety 2018-10-31 15:16:04 +01:00
CategoryListWidget.ui Make widget scalable and set minimum width based on the widget text 2017-02-22 03:39:13 +01:00
Clipboard.cpp Replace deprecated parts of the code (#2419) 2018-10-26 15:19:04 +02:00
Clipboard.h Replace deprecated parts of the code (#2419) 2018-10-26 15:19:04 +02:00
CloneDialog.cpp Formatting the code. 2018-03-31 16:01:30 -04:00
CloneDialog.h Formatting the code. 2018-03-31 16:01:30 -04:00
CloneDialog.ui Fix clone dialog text 2017-07-20 14:09:33 +02:00
DatabaseOpenWidget.cpp Refactor Database and Database widgets (#2491) 2018-11-22 11:47:31 +01:00
DatabaseOpenWidget.h Refactor Database and Database widgets (#2491) 2018-11-22 11:47:31 +01:00
DatabaseOpenWidget.ui Add a new database settings wizard 2018-09-25 21:12:47 +02:00
DatabaseTabWidget.cpp Refactor Database and Database widgets (#2491) 2018-11-22 11:47:31 +01:00
DatabaseTabWidget.h Refactor Database and Database widgets (#2491) 2018-11-22 11:47:31 +01:00
DatabaseWidget.cpp Refactor Database and Database widgets (#2491) 2018-11-22 11:47:31 +01:00
DatabaseWidget.h Refactor Database and Database widgets (#2491) 2018-11-22 11:47:31 +01:00
DatabaseWidgetStateSync.cpp Refactor Database and Database widgets (#2491) 2018-11-22 11:47:31 +01:00
DatabaseWidgetStateSync.h Create config file deprecation mechanism & rename Details->Preview (#2371) 2018-10-08 21:11:44 -04:00
DialogyWidget.cpp Replace old for-loops with range-based for-loops 2018-10-31 14:23:06 +01:00
DialogyWidget.h Coding style fixes. 2015-10-15 18:02:31 +02:00
DragTabBar.cpp Formatting the code. 2018-03-31 16:01:30 -04:00
DragTabBar.h Replace Q_EMIT, Q_SIGNALS and Q_SLOTS macros with MOC keywords 2017-03-10 16:12:02 +01:00
EditWidget.cpp Refactor Database and Database widgets (#2491) 2018-11-22 11:47:31 +01:00
EditWidget.h Disable apply button when creating new entry/group 2018-08-18 10:31:40 -04:00
EditWidget.ui Add "Apply" button to entry and group edit windows (#624) 2017-06-13 20:55:53 -04:00
EditWidgetIcons.cpp Refactor Database and Database widgets (#2491) 2018-11-22 11:47:31 +01:00
EditWidgetIcons.h Refactor Database and Database widgets (#2491) 2018-11-22 11:47:31 +01:00
EditWidgetIcons.ui Pixel-perfect entry edit widgets 2017-02-16 10:35:39 +01:00
EditWidgetProperties.cpp Normalize signature of SIGNAL() and SLOT() 2018-10-31 15:16:04 +01:00
EditWidgetProperties.h Replaced Uuid with QUuid 2018-07-06 22:23:49 -04:00
EditWidgetProperties.ui Ask user before deleting custom plugin data and disable button if no data selected 2018-02-21 13:23:14 +01:00
EntryPreviewWidget.cpp Refactor Database and Database widgets (#2491) 2018-11-22 11:47:31 +01:00
EntryPreviewWidget.h Fix multiple issues with entries and keyboard shortcuts (#2431) 2018-11-16 10:00:59 -05:00
EntryPreviewWidget.ui Fix multiple issues with entries and keyboard shortcuts (#2431) 2018-11-16 10:00:59 -05:00
FileDialog.cpp Reduce number of unneeded copies 2018-10-31 15:16:04 +01:00
FileDialog.h Reduce number of unneeded copies 2018-10-31 15:16:04 +01:00
Font.cpp Refactor fixed font selection into Font class 2017-12-16 09:59:51 +02:00
Font.h Formatting the code. 2018-03-31 16:01:30 -04:00
IconModels.cpp Fixed issues with initial commit 2018-07-06 22:23:52 -04:00
IconModels.h Replaced Uuid with QUuid 2018-07-06 22:23:49 -04:00
KeePass1OpenWidget.cpp Refactor Database and Database widgets (#2491) 2018-11-22 11:47:31 +01:00
KeePass1OpenWidget.h Make C++11 mandatory. 2015-09-12 13:55:50 +02:00
KMessageWidget.cpp Improve readability and type-safety 2018-10-31 15:16:04 +01:00
KMessageWidget.h Replace Q_EMIT, Q_SIGNALS and Q_SLOTS macros with MOC keywords 2017-03-10 16:12:02 +01:00
LineEdit.cpp Fix icons not using default theme 2018-09-22 21:29:09 +02:00
LineEdit.h Replace Q_EMIT, Q_SIGNALS and Q_SLOTS macros with MOC keywords 2017-03-10 16:12:02 +01:00
MainWindow.cpp Refactor Database and Database widgets (#2491) 2018-11-22 11:47:31 +01:00
MainWindow.h Refactor Database and Database widgets (#2491) 2018-11-22 11:47:31 +01:00
MainWindow.ui Fix multiple issues with entries and keyboard shortcuts (#2431) 2018-11-16 10:00:59 -05:00
MainWindowAdaptor.cpp add function for locking DBs from DBus, fix #687 2018-01-25 23:48:58 +01:00
MainWindowAdaptor.h add function for locking DBs from DBus, fix #687 2018-01-25 23:48:58 +01:00
MessageBox.cpp Formatting the code. 2018-03-31 16:01:30 -04:00
MessageBox.h Formatting the code. 2018-03-31 16:01:30 -04:00
MessageWidget.cpp Formatting the code. 2018-03-31 16:01:30 -04:00
MessageWidget.h Improve readability and type-safety 2018-10-31 15:16:04 +01:00
org.keepassxc.KeePassXC.MainWindow.xml add function for locking DBs from DBus, fix #687 2018-01-25 23:48:58 +01:00
PasswordEdit.cpp Reduce number of unneeded copies 2018-10-31 15:16:04 +01:00
PasswordEdit.h Reduce number of unneeded copies 2018-10-31 15:16:04 +01:00
PasswordGeneratorWidget.cpp Use length of existing password for the password generator (#2318) 2018-09-25 20:44:19 -04:00
PasswordGeneratorWidget.h Use length of existing password for the password generator (#2318) 2018-09-25 20:44:19 -04:00
PasswordGeneratorWidget.ui Add a new database settings wizard 2018-09-25 21:12:47 +02:00
SearchHelpWidget.ui Add search help pop-up 2018-11-17 09:04:15 -05:00
SearchWidget.cpp Refactor Database and Database widgets (#2491) 2018-11-22 11:47:31 +01:00
SearchWidget.h Add search help pop-up 2018-11-17 09:04:15 -05:00
SearchWidget.ui Add search help pop-up 2018-11-17 09:04:15 -05:00
SortFilterHideProxyModel.cpp Adapt to setSupportedDragActions() begin removed. 2015-09-12 13:51:49 +02:00
SortFilterHideProxyModel.h Make C++11 mandatory. 2015-09-12 13:55:50 +02:00
SquareSvgWidget.cpp Add QR code generator for TOTP export (#1167) 2018-10-19 14:42:49 -04:00
SquareSvgWidget.h Add QR code generator for TOTP export (#1167) 2018-10-19 14:42:49 -04:00
TotpDialog.cpp Introduce synchronize merge method 2018-09-30 09:36:39 -04:00
TotpDialog.h Complete refactor of TOTP integration 2018-09-15 12:10:26 -04:00
TotpDialog.ui Add TOTP support 2017-05-03 20:55:14 -03:00
TotpExportSettingsDialog.cpp Add QR code generator for TOTP export (#1167) 2018-10-19 14:42:49 -04:00
TotpExportSettingsDialog.h Add QR code generator for TOTP export (#1167) 2018-10-19 14:42:49 -04:00
TotpSetupDialog.cpp Complete refactor of TOTP integration 2018-09-15 12:10:26 -04:00
TotpSetupDialog.h Complete refactor of TOTP integration 2018-09-15 12:10:26 -04:00
TotpSetupDialog.ui Complete refactor of TOTP integration 2018-09-15 12:10:26 -04:00
UnlockDatabaseDialog.cpp Refactor Database and Database widgets (#2491) 2018-11-22 11:47:31 +01:00
UnlockDatabaseDialog.h Refactor Database and Database widgets (#2491) 2018-11-22 11:47:31 +01:00
UnlockDatabaseWidget.cpp Formatting the code. 2018-03-31 16:01:30 -04:00
UnlockDatabaseWidget.h Clear database open dialog before and after merging a database (#958) 2017-09-23 11:43:29 -04:00
WelcomeWidget.cpp Implement review feedback 2018-10-19 22:16:44 +02:00
WelcomeWidget.h Formatting the code. 2018-03-31 16:01:30 -04:00
WelcomeWidget.ui Make 'Welcome to KeePassXC $VERSION' string properly translatable, resolves #1236 2018-01-28 16:44:36 +01:00