mirrors/maddy
1
0
Fork 0
mirror of https://github.com/foxcpp/maddy.git synced 2025-04-06 06:27:38 +03:00
Code Issues Projects Releases Packages Wiki Activity

table: Fix use of numbered argument placeholders

Browse source 
go-sqlite3 does not implement them properly (in fact, the proper support
was just removed, wtf, mattn). Additionally, go-sqlite3 does not handle
$name or @name properly despite these being supported by SQLite, only
:name works.

Closes #241.
This commit is contained in:
fox.cpp 2020-06-19 14:09:48 +03:00
parent 3fc8a54924
commit 071d06dbff
No known key found for this signature in database
GPG key ID: 5B991F6215D2FCC0
4 changed files with 12 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

6
internal/table/sql_query.go
View file

@ -150,7 +150,7 @@ func (s *SQL) RemoveKey(k string) error {
return fmt.Errorf("%s: table is not mutable (no 'del' query)", s.modName)
}
_, err := s.del.Exec(k)
_, err := s.del.Exec(sql.Named("key", k))
if err != nil {
return fmt.Errorf("%s: del %s: %w", s.modName, k, err)
}
@ -165,8 +165,8 @@ func (s *SQL) SetKey(k, v string) error {
return fmt.Errorf("%s: table is not mutable (no 'add' query)", s.modName)
}
if _, err := s.add.Exec(k, v); err != nil {
if _, err := s.set.Exec(k, v); err != nil {
if _, err := s.add.Exec(sql.Named("key", k), sql.Named("value", v)); err != nil {
if _, err := s.set.Exec(sql.Named("key", k), sql.Named("value", v)); err != nil {
return fmt.Errorf("%s: add %s: %w", s.modName, k, err)
}
return nil