mirrors/maddy
1
0
Fork 0
mirror of https://github.com/foxcpp/maddy.git synced 2025-04-05 22:17:39 +03:00
Code Issues Projects Releases Packages Wiki Activity

storage/blob/s3: Fix PutObject goroutines leaking if message write is aborted

Browse source 
See #395.
This commit is contained in:
fox.cpp 2021-08-27 11:53:59 +03:00
parent 34a8c6864d
commit 07c8495ee4
No known key found for this signature in database
GPG key ID: 5B991F6215D2FCC0
1 changed files with 7 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

8
internal/storage/blob/s3/s3.go
View file

@ -105,6 +105,9 @@ func (b *s3blob) Write(p []byte) (n int, err error) {
} }
func (b *s3blob) Close() error { func (b *s3blob) Close() error {
if !b.didSync {
b.pw.CloseWithError(fmt.Errorf("storage.blob.s3: blob closed without Sync"))
}
return nil return nil
} }
@ -120,7 +123,10 @@ func (s *Store) Create(key string) (module.Blob, error) {
errCh <- err errCh <- err
}() }()
return &s3blob{pw: pw, errCh: errCh}, nil return &s3blob{
pw: pw,
errCh: errCh,
}, nil
} }
func (s *Store) Open(key string) (io.ReadCloser, error) { func (s *Store) Open(key string) (io.ReadCloser, error) {