Extract mapping lookup from loop

This commit is contained in:
Arisu Desu 2023-01-28 14:10:45 +03:00
parent 9a87d73383
commit 1a603a4e53

View file

@ -9,28 +9,28 @@ import (
) )
func AuthorizeEmailUse(ctx context.Context, username string, addrs []string, mapping module.Table) (bool, error) { func AuthorizeEmailUse(ctx context.Context, username string, addrs []string, mapping module.Table) (bool, error) {
var validEmails []string
if multi, ok := mapping.(module.MultiTable); ok {
validEmails, err = multi.LookupMulti(ctx, username)
if err != nil {
return false, fmt.Errorf("authz: %w", err)
}
} else {
validEmail, ok, err := mapping.Lookup(ctx, username)
if err != nil {
return false, fmt.Errorf("authz: %w", err)
}
if ok {
validEmails = []string{validEmail}
}
}
for _, addr := range addrs { for _, addr := range addrs {
_, domain, err := address.Split(addr) _, domain, err := address.Split(addr)
if err != nil { if err != nil {
return false, fmt.Errorf("authz: %w", err) return false, fmt.Errorf("authz: %w", err)
} }
var validEmails []string
if multi, ok := mapping.(module.MultiTable); ok {
validEmails, err = multi.LookupMulti(ctx, username)
if err != nil {
return false, fmt.Errorf("authz: %w", err)
}
} else {
validEmail, ok, err := mapping.Lookup(ctx, username)
if err != nil {
return false, fmt.Errorf("authz: %w", err)
}
if ok {
validEmails = []string{validEmail}
}
}
for _, ent := range validEmails { for _, ent := range validEmails {
if ent == domain || ent == "*" || ent == addr { if ent == domain || ent == "*" || ent == addr {
return true, nil return true, nil