From cf72b11c7607c247110c70c645d700c9f918ded6 Mon Sep 17 00:00:00 2001
From: "fox.cpp" <fox.cpp@disroot.org>
Date: Sun, 6 Dec 2020 14:51:03 +0300
Subject: [PATCH] Fix/silence a couple of linter warnings

---
 framework/dns/dnssec.go              | 1 -
 framework/dns/dnssec_test.go         | 6 ++++--
 internal/endpoint/smtp/submission.go | 2 +-
 internal/target/remote/security.go   | 2 +-
 4 files changed, 6 insertions(+), 5 deletions(-)

diff --git a/framework/dns/dnssec.go b/framework/dns/dnssec.go
index 4a620a3..f2579c3 100644
--- a/framework/dns/dnssec.go
+++ b/framework/dns/dnssec.go
@@ -283,7 +283,6 @@ func (e ExtResolver) AuthLookupIPAddr(ctx context.Context, host string) (ad bool
 	)
 	if err != nil {
 		// Disregard the error for AAAA lookups.
-		resp = &dns.Msg{}
 		aaaaFailed = true
 		log.DefaultLogger.Error("Network I/O error during AAAA lookup", err, "host", host)
 	} else {
diff --git a/framework/dns/dnssec_test.go b/framework/dns/dnssec_test.go
index 68e31cd..731ce47 100644
--- a/framework/dns/dnssec_test.go
+++ b/framework/dns/dnssec_test.go
@@ -52,7 +52,7 @@ func (s *IPAddrTestServer) Run() {
 	}
 	s.udpServ.PacketConn = pconn
 	s.udpServ.Handler = s
-	go s.udpServ.ActivateAndServe()
+	go s.udpServ.ActivateAndServe() //nolint:errcheck
 }
 
 func (s *IPAddrTestServer) Close() {
@@ -117,7 +117,9 @@ func (s *IPAddrTestServer) ServeDNS(w dns.ResponseWriter, m *dns.Msg) {
 		}
 	}
 
-	w.WriteMsg(reply)
+	if err := w.WriteMsg(reply); err != nil {
+		panic(err)
+	}
 }
 
 func TestExtResolver_AuthLookupIPAddr(t *testing.T) {
diff --git a/internal/endpoint/smtp/submission.go b/internal/endpoint/smtp/submission.go
index 9ac9704..316c8b6 100644
--- a/internal/endpoint/smtp/submission.go
+++ b/internal/endpoint/smtp/submission.go
@@ -103,7 +103,7 @@ func (s *Session) submissionPrepare(msgMeta *module.MsgMetadata, header *textpro
 		return &exterrors.SMTPError{
 			Code:         554,
 			EnhancedCode: exterrors.EnhancedCode{5, 6, 0},
-			Message:      fmt.Sprintf("Invalid address in From"),
+			Message:      "Invalid address in From",
 			Misc: map[string]interface{}{
 				"modifier": "submission_prepare",
 				"addr":     header.Get("From"),
diff --git a/internal/target/remote/security.go b/internal/target/remote/security.go
index 459e70d..b490c62 100644
--- a/internal/target/remote/security.go
+++ b/internal/target/remote/security.go
@@ -399,7 +399,7 @@ func (c *daneDelivery) discoverTLSA(ctx context.Context, mx string) ([]dns.TLSA,
 		return nil, err
 	}
 	if rname == "" {
-		// No A/AAAA records, short-circut discovery instead of doing useless
+		// No A/AAAA records, short-circuit discovery instead of doing useless
 		// queries.
 		return nil, errors.New("no address associated with the host")
 	}