mirrors/maddy
1
0
Fork 0
mirror of https://github.com/foxcpp/maddy.git synced 2025-04-05 14:07:38 +03:00
Code Issues Projects Releases Packages Wiki Activity

storage/blob/s3: Force a smaller PartSize when blob size is unknown

Browse source 
Blob size would be unknown ahead of time if message store compression is used (e.g. in imapsql).

Part of #395 fix
This commit is contained in:
fox.cpp 2021-08-28 15:24:35 +03:00
parent 14a441f595
commit fc00133ee3
No known key found for this signature in database
GPG key ID: 5B991F6215D2FCC0
1 changed files with 10 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

11
internal/storage/blob/s3/s3.go
View file

@ -116,7 +116,16 @@ func (s *Store) Create(ctx context.Context, key string, blobSize int64) (module.
errCh := make(chan error, 1)
go func() {
_, err := s.cl.PutObject(ctx, s.bucketName, s.objectPrefix+key, pr, blobSize, minio.PutObjectOptions{})
partSize := uint64(0)
if blobSize == module.UnknownBlobSize {
// Without this, minio-go will allocate 500 MiB buffer which
// is a little too much.
// https://github.com/minio/minio-go/issues/1478
partSize = 1 * 1024 * 1024 /* 1 MiB */
}
_, err := s.cl.PutObject(ctx, s.bucketName, s.objectPrefix+key, pr, blobSize, minio.PutObjectOptions{
PartSize: partSize,
})
if err != nil {
pr.CloseWithError(fmt.Errorf("s3 PutObject: %w", err))
}