From ff584bb5a39d491be7f5d937cce7198fd2c2615c Mon Sep 17 00:00:00 2001 From: "fox.cpp" Date: Mon, 9 Aug 2021 13:02:21 +0300 Subject: [PATCH] storage/blob/s3: Add missing didSync check --- internal/storage/blob/s3/s3.go | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/internal/storage/blob/s3/s3.go b/internal/storage/blob/s3/s3.go index a4d23b5..7063a38 100644 --- a/internal/storage/blob/s3/s3.go +++ b/internal/storage/blob/s3/s3.go @@ -89,10 +89,14 @@ type s3blob struct { func (b *s3blob) Sync() error { // We do this in Sync instead of Close because // backend may not actually check the error of Close. - // The problematic restriction is that Sync can now be called // only once. + if b.didSync { + panic("storage.blob.s3: Sync called twice for a blob object") + } + b.pw.Close() + b.didSync = true return <-b.errCh }