Now imapsql module does not handle authentication. (it was not doing it so well
anyway)
sql_table module was introduced and used in the default configuration as
a replacement for functionality that was implemented by imapsql before.
Parts of maddyctl code were rewritten to make it work transparently with
any IMAP backend or credentials store.
Closes#212.
There is abstraction 'updates pipe' defined for future use with
configuration involving IMAP data replication (e.g. multiple nodes with
maddy instances + PostgreSQL replicas + S3 bucket for messages).
However, for the case of local SQLite3 DB, limited UDS-based
implementation is provided. It solves the problem of maddyctl not being
able to tell the server about modifications it makes. Alternative to
this approach would be to have server actually perform operations and
maddyctl being a dumb API client, but this requires a lot more complex
IPC interface and will not work when the server is down.
While using maddyctl with non-standard directories, users always have to
specify them using command-line arguments, which is inconvenient. This
commit allows maddyctl to read these values from the configuration,
requiring only the path to the configuration file to be specified.
To ensure consistency and avoid confusion, paths specified in
the configuration are required to be absolute.
Due to inability to set MADDYSTATE, MADDYRUNTIME, etc before reading the
configuration, these environment variables were removed.
Some fixed warnings are not actual problems. I just want output
golangci-run to be smaller. Otherwise it is problematic to see
actual problems found by linters due to amount of noise.
testutils, ctl/maddyctl: Remove quite a lot of unused entities.
msgpipeline: Fix typo in log message.
msgpipeline: Add missing 'case 0' for 'reject' directive parsing
msgpipeline: Preallocate slice in parseChecksGroup
Check errors in some places in tests.
smtp_upstream: Move DATA command use into Commit
target/queue: Avoid copying sync.Mutex
Not a problem since it is not used after copying, but I just want
govet to shut up.
Now it is not tied go-imap-sql details (with the exception of special
features), allowing it to be used with other storage backends that will
be added in the future.
--unsafe flag is removed and now maddyctl explicitly asks for
confirmation in cases where transaction may be unsafe for connected
clients. --yes flag disables that. In the future, maddy can be
extended with IPC interface to push updates so it this restriction
can be lifted altogether.
