The intention is to keep to repo root clean while the list of packages
is slowly growing.
Additionally, a bunch of small (~30 LoC) files in the repo root is
merged into a single maddy.go file, for the same reason.
Most of the internal code is moved into the internal/ directory. Go
toolchain will make it impossible to import these packages from external
applications.
Some packages are renamed and moved into the pkg/ directory in the root.
According to https://github.com/golang-standards/project-layout this is
the de-facto standard to place "library code that's ok to use by
external applications" in.
To clearly define the purpose of top-level directories, README.md files
are added to each.
It was used only in queue tests and so was moved there. This fixes
-tests.debuglog command line flag being present in the maddy executable
as a side effect of testutils package import.
While at it, simplify the TimeWheel code to be callback-based rather
than a channel-based. This allows to get rid of second goroutine
(dispatch) to make shutdown logic simplier.
Change the order of operations to close the TimeWheel before waiting for
goroutines to stop. This prevents starting of new goroutines.
Make operations on closed TimeWheel no-op. Otherwise it will cause panics
when the TimeWheel is already closed. No-op behavior is fine, we are
about to discard TimeWheel state anyway and the TimeWheel caller already
saved meta-data needed to restore it on the next start-up to the disk.
Use correct enhanced codes in Status fields.
Use null return-path in MAIL FROM, as required by RFC 5321.
Don't generate DSNs for messages with null return-path.
Add tests.
Previous error reporting code was inconsistent in terms of what is
logged, when and by whom. This caused several problems such as: logs
missing important error context, duplicated error messages, too verbose
messages, etc.
Instead of logging all generated errors, module should log
only errors it 'handles' somehow and does not simply pass it to the
caller. This removes duplication, however, also it removes context
information. To fix this, exterrors package was extended to provide
utilities for error wrapping. These utilities provide ability to
'attach' arbitrary key-value ('fields') pairs to any error object while
preserving the original value (using to Go 1.13 error handling
primitives).
In additional to solving problems described above this commit makes logs
machine-readable, creating the possibility for automated analysis.
Three new functions were added to the Logger object, providing
loosely-typed structured logging. However, they do not completely
replace plain logging and are used only where they are useful (to allow
automated analysis of message processing logs).
So, basically, instead of being logged god knows where and when,
all context information is attached to the error object and then it is
passed up until it is handled somewhere, at this point it is logged
together with all context information and then discarded.
Some fixed warnings are not actual problems. I just want output
golangci-run to be smaller. Otherwise it is problematic to see
actual problems found by linters due to amount of noise.
testutils, ctl/maddyctl: Remove quite a lot of unused entities.
msgpipeline: Fix typo in log message.
msgpipeline: Add missing 'case 0' for 'reject' directive parsing
msgpipeline: Preallocate slice in parseChecksGroup
Check errors in some places in tests.
smtp_upstream: Move DATA command use into Commit
target/queue: Avoid copying sync.Mutex
Not a problem since it is not used after copying, but I just want
govet to shut up.
New name more precisely describes what it is doing now. It was initally
meant to be more generic and usable for other purposes, but I don't
think we will need that flexibility.
Due to .gitignore, target/queue directory got ignored and was not
commited.
This commit makes problematic ignore filter more strict and adds
accidentally removed directory.
