smtp.ConnectionState is no longer a thing and sessions are initialized
early so we can move more processing early. One such change is
in DNSBL - run the check before EHLO completes. Some further optimizations
are possible there - e.g. start DNSBL check once we get EHLO and have
the result ready once we receive MAIL FROM and act accordingly.
- Only loop trough the `from` email address if UTF8 options is not enabled. This should avoid unnecessary loops for servers which has the UTF8 option enabled.
Hi!
I've removed some unused params. But if they where needed for e.g. interface type I've simply `_` them. Also I have to instances to fix tests params, whereby they were passed but not initialized at all, they are in`internal/target/remote/remote_test.go` and `internal/modify/dkim/dkim_test.go`. All test are still passing so it seems like I didn't break anything.
I might've refactored some code away that actually is used but wasn't implemented correctly, but as far as I see their is nothing wrong or erroring going on.
Regressed in 1c42a70533.
It truncates messages to I/O buffer size (4096 bytes).
If first 4096 bytes cover head then it causes "unexpected EOF" (see
#300), otherwise it silently breaks the message.
Several comments were removed since they are not worth the trouble.
A few minor issues were addressed.
Most of remaining comments got corresponding GitHub issues assigned.
