Previous error reporting code was inconsistent in terms of what is
logged, when and by whom. This caused several problems such as: logs
missing important error context, duplicated error messages, too verbose
messages, etc.
Instead of logging all generated errors, module should log
only errors it 'handles' somehow and does not simply pass it to the
caller. This removes duplication, however, also it removes context
information. To fix this, exterrors package was extended to provide
utilities for error wrapping. These utilities provide ability to
'attach' arbitrary key-value ('fields') pairs to any error object while
preserving the original value (using to Go 1.13 error handling
primitives).
In additional to solving problems described above this commit makes logs
machine-readable, creating the possibility for automated analysis.
Three new functions were added to the Logger object, providing
loosely-typed structured logging. However, they do not completely
replace plain logging and are used only where they are useful (to allow
automated analysis of message processing logs).
So, basically, instead of being logged god knows where and when,
all context information is attached to the error object and then it is
passed up until it is handled somewhere, at this point it is logged
together with all context information and then discarded.
Some fixed warnings are not actual problems. I just want output
golangci-run to be smaller. Otherwise it is problematic to see
actual problems found by linters due to amount of noise.
testutils, ctl/maddyctl: Remove quite a lot of unused entities.
msgpipeline: Fix typo in log message.
msgpipeline: Add missing 'case 0' for 'reject' directive parsing
msgpipeline: Preallocate slice in parseChecksGroup
Check errors in some places in tests.
smtp_upstream: Move DATA command use into Commit
target/queue: Avoid copying sync.Mutex
Not a problem since it is not used after copying, but I just want
govet to shut up.
New name more precisely describes what it is doing now. It was initally
meant to be more generic and usable for other purposes, but I don't
think we will need that flexibility.
Log successfull delivery to each recipient.
Log permanent failures separately for each recipients. It makes it
easier to process log in scripts.
Add list of recipients that will be retried to the "will retry"
message.
Most previously existing ways to specify Config/State/Libexec
directories are removed. Now they can be set only using
command line flags. Generally, having multiple ways to set these
values can be confusing and also believed to be unnecessary.
All relative paths in the configuration are now interpreted
relatively to the State directory.
Additionally, new value is added: Runtime directory. It will used
in the future for temporary files.
All directories that should be writable will be created on startup
if possible and checked for writebility.
It makes sense to allow having default of bool flag to true and
allow writing 'name no' to disable it. This allows getting rid of
"dont", "no" etc in names or certain directives which are meant to be
enabled by default. IMO 'do_x no' looks better than 'dont_do_x'
Due to .gitignore, target/queue directory got ignored and was not
commited.
This commit makes problematic ignore filter more strict and adds
accidentally removed directory.
