First issue: check.spf CheckBody deadlocks if CheckConnection skipped
the message due to it being locally generated (the case for DSNs).
Second issue: msgpipeline does not call CheckConnection at all
if MAIL FROM is an empty string (which is also the case for DSNs).
tests/issue327_test.go is added based on symptoms from the original
bug report.
See #237.
This is a double-edged sword though as blind panic recovery
can lead to consistency issues in program state.
In particular, halting imapsql update push due to panic can lead
to a deadlock in IMAP code.
Panic in MTA-STS cache maintenance routine can lead to degraded
security.
It is useful to define background tasks lifetimes more precisely,
especially involving timeouts and other cancellation methods.
On top of that, several tracing facilities are context-based (e.g.
runtime/trace), so it is possible to use them now.
The intention is to keep to repo root clean while the list of packages
is slowly growing.
Additionally, a bunch of small (~30 LoC) files in the repo root is
merged into a single maddy.go file, for the same reason.
Most of the internal code is moved into the internal/ directory. Go
toolchain will make it impossible to import these packages from external
applications.
Some packages are renamed and moved into the pkg/ directory in the root.
According to https://github.com/golang-standards/project-layout this is
the de-facto standard to place "library code that's ok to use by
external applications" in.
To clearly define the purpose of top-level directories, README.md files
are added to each.
2019-12-06 01:35:12 +03:00
Renamed from msgpipeline/check_runner.go (Browse further)
