mirrors/navidrome
1
0
Fork 0
mirror of https://github.com/navidrome/navidrome.git synced 2025-04-03 04:27:37 +03:00
Code Issues Projects Releases Packages Wiki Activity

Fix image stuttering (#3035)

Browse source 
* Fix image stuttering.

* Fix docker publishing for PRs

* Write tests for new square parameter.

* Simplify code for createImage.

---------

Co-authored-by: Deluan Quintão <deluan@navidrome.org>
This commit is contained in:
Caio Cotts 2024-05-24 20:19:26 -04:00 • committed by GitHub
parent 61903facdf
commit 0488fb92cb
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
11 changed files with 123 additions and 46 deletions
Download patch file Download diff file Expand all files Collapse all files

2
server/public/handle_images.go
View file

@ -36,7 +36,7 @@ func (pub *Router) handleImages(w http.ResponseWriter, r *http.Request) {
}
size := p.IntOr("size", 0)
imgReader, lastUpdate, err := pub.artwork.Get(ctx, artId, size)
imgReader, lastUpdate, err := pub.artwork.Get(ctx, artId, size, false)
switch {
case errors.Is(err, context.Canceled):
return

3
server/subsonic/media_retrieval.go
View file

@ -64,8 +64,9 @@ func (api *Router) GetCoverArt(w http.ResponseWriter, r *http.Request) (*respons
p := req.Params(r)
id, _ := p.String("id")
size := p.IntOr("size", 0)
square := p.BoolOr("square", false)
imgReader, lastUpdate, err := api.artwork.GetOrPlaceholder(ctx, id, size)
imgReader, lastUpdate, err := api.artwork.GetOrPlaceholder(ctx, id, size, square)
w.Header().Set("cache-control", "public, max-age=315360000")
w.Header().Set("last-modified", lastUpdate.Format(time.RFC1123))

2
server/subsonic/media_retrieval_test.go
View file

@ -257,7 +257,7 @@ type fakeArtwork struct {
recvSize int
}
func (c *fakeArtwork) GetOrPlaceholder(_ context.Context, id string, size int) (io.ReadCloser, time.Time, error) {
func (c *fakeArtwork) GetOrPlaceholder(_ context.Context, id string, size int, square bool) (io.ReadCloser, time.Time, error) {
if c.err != nil {
return nil, time.Time{}, c.err
}