mirrors/navidrome
1
0
Fork 0
mirror of https://github.com/navidrome/navidrome.git synced 2025-04-04 21:17:37 +03:00
Code Issues Projects Releases Packages Wiki Activity

remove reflection

Browse source 
Signed-off-by: Deluan <deluan@navidrome.org>
This commit is contained in:
Deluan 2025-03-29 16:17:19 -04:00
parent d5c598d94a
commit 0fec41fb0e
1 changed files with 10 additions and 24 deletions
Download patch file Download diff file Expand all files Collapse all files

34
core/extdata/provider_test.go
View file

@ -69,31 +69,20 @@ func setAgentField(obj interface{}, fieldName string, value interface{}) {
rf.Set(reflect.ValueOf(value))
}
// Gets unexported field value from a struct using reflection and unsafe package
func getField(obj interface{}, fieldName string) interface{} {
v := reflect.ValueOf(obj).Elem()
f := v.FieldByName(fieldName)
rf := reflect.NewAt(f.Type(), unsafe.Pointer(f.UnsafeAddr())).Elem()
return rf.Interface()
}
// Extended MockArtistRepo with GetAll query behavior needed for tests
type testArtistRepo struct {
*tests.MockArtistRepo
}
func (m *testArtistRepo) GetAll(options ...model.QueryOptions) (model.Artists, error) {
// Get the error state using reflection
if getField(m.MockArtistRepo, "Err").(bool) {
// Check the error state
if m.MockArtistRepo.Err {
return nil, errors.New("error")
}
// Get the data using reflection
dataMap := getField(m.MockArtistRepo, "Data").(map[string]*model.Artist)
// Convert map to slice
artists := make(model.Artists, 0, len(dataMap))
for _, a := range dataMap {
// Convert data map to slice
artists := make(model.Artists, 0, len(m.MockArtistRepo.Data))
for _, a := range m.MockArtistRepo.Data {
artists = append(artists, *a)
}
@ -144,17 +133,14 @@ type testMediaFileRepo struct {
}
func (m *testMediaFileRepo) GetAll(options ...model.QueryOptions) (model.MediaFiles, error) {
// Get the error state using reflection
if getField(m.MockMediaFileRepo, "Err").(bool) {
// Check the error state
if m.MockMediaFileRepo.Err {
return nil, errors.New("error")
}
// Get the data using reflection
dataMap := getField(m.MockMediaFileRepo, "Data").(map[string]*model.MediaFile)
// Convert map to slice
mediaFiles := make(model.MediaFiles, 0, len(dataMap))
for _, mf := range dataMap {
// Convert data map to slice
mediaFiles := make(model.MediaFiles, 0, len(m.MockMediaFileRepo.Data))
for _, mf := range m.MockMediaFileRepo.Data {
mediaFiles = append(mediaFiles, *mf)
}