Don't expose Last.fm API Key in the index.html

ui/src/authProvider.js

@@ -21,6 +21,7 @@ function storeAuthenticationInfo(authInfo) {
   localStorage.setItem('role', authInfo.isAdmin ? 'admin' : 'regular')
   localStorage.setItem('subsonic-salt', authInfo.subsonicSalt)
   localStorage.setItem('subsonic-token', authInfo.subsonicToken)
+  localStorage.setItem('lastfm-apikey', authInfo.lastFMApiKey)
   localStorage.setItem('is-authenticated', 'true')
 }
 
@@ -102,6 +103,7 @@ const removeItems = () => {
   localStorage.removeItem('role')
   localStorage.removeItem('subsonic-salt')
   localStorage.removeItem('subsonic-token')
+  localStorage.removeItem('lastfm-apikey')
   localStorage.removeItem('is-authenticated')
 }
 

ui/src/config.js

@@ -25,7 +25,6 @@ const defaultConfig = {
   defaultDownloadableShare: true,
   devSidebarPlaylists: true,
   lastFMEnabled: true,
-  lastFMApiKey: '9b94a5515ea66b2da3ec03c12300327e',
   listenBrainzEnabled: true,
   enableExternalServices: true,
   enableCoverAnimation: true,

ui/src/personal/LastfmScrobbleToggle.js

@@ -7,7 +7,6 @@ import {
   Switch,
 } from '@material-ui/core'
 import { useInterval } from '../common'
-import config from '../config'
 import { baseUrl, openInNewTab } from '../utils'
 import { httpClient } from '../dataProvider'
 
@@ -24,7 +23,7 @@ const Progress = (props) => {
     )
     const callbackUrl = `${window.location.origin}${callbackEndpoint}`
     openedTab.current = openInNewTab(
-      `https://www.last.fm/api/auth/?api_key=${config.lastFMApiKey}&cb=${callbackUrl}`,
+      `https://www.last.fm/api/auth/?api_key=${localStorage.getItem('lastfm-apikey')}&cb=${callbackUrl}`,
     )
   }, [])