mirrors/navidrome
1
0
Fork 0
mirror of https://github.com/navidrome/navidrome.git synced 2025-04-05 05:27:37 +03:00
Code Issues Projects Releases Packages Wiki Activity

Add comment tag, still missing multiline comments

Browse source
This commit is contained in:
Deluan 2020-01-21 10:05:00 -05:00
parent 22a0b7e170
commit 3a44f37622
2 changed files with 57 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

1
scanner/metadata_ffmpeg.go
View file

@ -33,6 +33,7 @@ func (m *Metadata) Year() int { return m.parseInt("year") }
func (m *Metadata) TrackNumber() (int, int) { return m.parseTuple("trackNum") } func (m *Metadata) TrackNumber() (int, int) { return m.parseTuple("trackNum") }
func (m *Metadata) DiscNumber() (int, int) { return m.parseTuple("discNum") } func (m *Metadata) DiscNumber() (int, int) { return m.parseTuple("discNum") }
func (m *Metadata) HasPicture() bool { return m.tags["hasPicture"] == "Video" } func (m *Metadata) HasPicture() bool { return m.tags["hasPicture"] == "Video" }
func (m *Metadata) Comment() string { return m.tags["comment"] }
func (m *Metadata) Compilation() bool { return m.parseBool("compilation") } func (m *Metadata) Compilation() bool { return m.parseBool("compilation") }
func (m *Metadata) Duration() int { return m.parseDuration("duration") } func (m *Metadata) Duration() int { return m.parseDuration("duration") }
func (m *Metadata) BitRate() int { return m.parseInt("bitrate") } func (m *Metadata) BitRate() int { return m.parseInt("bitrate") }

59
scanner/metadata_test.go
View file

@ -54,7 +54,8 @@ var _ = Describe("Metadata", func() {
}) })
Context("extractMetadata", func() { Context("extractMetadata", func() {
const outputWithOverlappingTitleTag = ` It("parses correct the title without overlapping with the stream tag", func() {
const outputWithOverlappingTitleTag = `
Input #0, mp3, from 'groovin.mp3': Input #0, mp3, from 'groovin.mp3':
Metadata: Metadata:
title : Groovin' (feat. Daniel Sneijers, Susanne Alt) title : Groovin' (feat. Daniel Sneijers, Susanne Alt)
@ -75,10 +76,62 @@ Input #0, mp3, from 'groovin.mp3':
title : cover title : cover
comment : Cover (front) comment : Cover (front)
At least one output file must be specified` At least one output file must be specified`
It("parses correct the title without overlapping with the stream tag", func() {
md, _ := extractMetadata("groovin.mp3", outputWithOverlappingTitleTag) md, _ := extractMetadata("groovin.mp3", outputWithOverlappingTitleTag)
Expect(md.Title()).To(Equal("Groovin' (feat. Daniel Sneijers, Susanne Alt)")) Expect(md.Title()).To(Equal("Groovin' (feat. Daniel Sneijers, Susanne Alt)"))
}) })
// TODO Handle multiline tags
XIt("parses multiline tags", func() {
const outputWithMultilineComment = `
Input #0, mov,mp4,m4a,3gp,3g2,mj2, from 'modulo.m4a':
Metadata:
major_brand : mp42
minor_version : 0
compatible_brands: M4A mp42isom
creation_time : 2014-05-10T21:11:57.000000Z
iTunSMPB : 00000000 00000920 000000E0 00000000021CA200 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
encoder : Nero AAC codec / 1.5.4.0
title : Módulo Especial
artist : Saara Saara
comment : https://www.mixcloud.com/codigorock/30-minutos-com-saara-saara/
:
: Tracklist:
:
: 01. Saara Saara
: 02. Carta Corrente
: 03. X
: 04. Eclipse Lunar
: 05. Vírus de Sírius
: 06. Doktor Fritz
: 07. Wunderbar
: 08. Quarta Dimensão
album : Módulo Especial
genre : Electronic
track : 1
Duration: 00:26:46.96, start: 0.052971, bitrate: 69 kb/s
Chapter #0:0: start 0.105941, end 1607.013149
Metadata:
title :
Stream #0:0(und): Audio: aac (HE-AAC) (mp4a / 0x6134706D), 44100 Hz, stereo, fltp, 69 kb/s (default)
Metadata:
creation_time : 2014-05-10T21:11:57.000000Z
handler_name : Sound Media Handler
At least one output file must be specified`
const expectedComment = `https://www.mixcloud.com/codigorock/30-minutos-com-saara-saara/
Tracklist:
01. Saara Saara
02. Carta Corrente
03. X
04. Eclipse Lunar
05. Vírus de Sírius
06. Doktor Fritz
07. Wunderbar
08. Quarta Dimensão
`
md, _ := extractMetadata("modulo.mp3", outputWithMultilineComment)
Expect(md.Comment()).To(Equal(expectedComment))
})
}) })
}) })