feat(ui): hide absolute paths from regular users

Signed-off-by: Deluan <deluan@navidrome.org>

ui/src/common/PathField.jsx

@@ -1,24 +1,22 @@
 import PropTypes from 'prop-types'
 import React from 'react'
-import { useRecordContext } from 'react-admin'
+import { usePermissions, useRecordContext } from 'react-admin'
 import config from '../config'
 
 export const PathField = (props) => {
   const record = useRecordContext(props)
-  return (
+  const { permissions } = usePermissions()
-    <span>
+  let path = permissions === 'admin' ? record.libraryPath : ''
-      {record.libraryPath}
+
-      {config.separator}
+  if (path && path.endsWith(config.separator)) {
-      {record.path}
+    path = `${path}${record.path}`
-    </span>
+  } else {
-  )
+    path = path ? `${path}${config.separator}${record.path}` : record.path
+  }
+
+  return <span>{path}</span>
 }
 
 PathField.propTypes = {
-  label: PropTypes.string,
   record: PropTypes.object,
 }
-
-PathField.defaultProps = {
-  addLabel: true,
-}

ui/src/common/PathField.test.jsx

@@ -0,0 +1,86 @@
+import React from 'react'
+import { render } from '@testing-library/react'
+import { PathField } from './PathField'
+import { usePermissions, useRecordContext } from 'react-admin'
+import config from '../config'
+
+// Mock react-admin hooks
+vi.mock('react-admin', () => ({
+  usePermissions: vi.fn(),
+  useRecordContext: vi.fn(),
+}))
+
+// Mock config
+vi.mock('../config', () => ({
+  default: {
+    separator: '/',
+  },
+}))
+
+describe('PathField', () => {
+  beforeEach(() => {
+    vi.clearAllMocks()
+  })
+
+  it('renders path without libraryPath for non-admin users', () => {
+    // Setup
+    usePermissions.mockReturnValue({ permissions: 'user' })
+    useRecordContext.mockReturnValue({
+      path: 'music/song.mp3',
+      libraryPath: '/data/media',
+    })
+
+    // Act
+    const { container } = render(<PathField />)
+
+    // Assert
+    expect(container.textContent).toBe('music/song.mp3')
+    expect(container.textContent).not.toContain('/data/media')
+  })
+
+  it('renders combined path for admin users when libraryPath does not end with separator', () => {
+    // Setup
+    usePermissions.mockReturnValue({ permissions: 'admin' })
+    useRecordContext.mockReturnValue({
+      path: 'music/song.mp3',
+      libraryPath: '/data/media',
+    })
+
+    // Act
+    const { container } = render(<PathField />)
+
+    // Assert
+    expect(container.textContent).toBe('/data/media/music/song.mp3')
+  })
+
+  it('renders combined path for admin users when libraryPath ends with separator', () => {
+    // Setup
+    usePermissions.mockReturnValue({ permissions: 'admin' })
+    useRecordContext.mockReturnValue({
+      path: 'music/song.mp3',
+      libraryPath: '/data/media/',
+    })
+
+    // Act
+    const { container } = render(<PathField />)
+
+    // Assert
+    expect(container.textContent).toBe('/data/media/music/song.mp3')
+  })
+
+  it('works with a different separator from config', () => {
+    // Setup
+    config.separator = '\\'
+    usePermissions.mockReturnValue({ permissions: 'admin' })
+    useRecordContext.mockReturnValue({
+      path: 'music\\song.mp3',
+      libraryPath: 'C:\\data',
+    })
+
+    // Act
+    const { container } = render(<PathField />)
+
+    // Assert
+    expect(container.textContent).toBe('C:\\data\\music\\song.mp3')
+  })
+})