mirrors/navidrome
1
0
Fork 0
mirror of https://github.com/navidrome/navidrome.git synced 2025-04-03 04:27:37 +03:00
Code Issues Projects Releases Packages Wiki Activity

Fix logging when first arg is a context.Context without a logger

Browse source
This commit is contained in:
Deluan 2020-04-26 19:33:57 -04:00
parent b44218fdcc
commit 46f1b33812
2 changed files with 3 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

1
log/log.go
View file

@ -180,6 +180,7 @@ func extractLogger(ctx interface{}) (*logrus.Entry, error) {
if logger != nil {
return logger.(*logrus.Entry), nil
}
return extractLogger(NewContext(ctx))
case *http.Request:
return extractLogger(ctx.Context())
}

4
log/log_test.go
View file

@ -41,8 +41,8 @@ var _ = Describe("Logger", func() {
Expect(hook.LastEntry().Data).To(BeEmpty())
})
XIt("Empty context", func() {
Error(context.Background(), "Simple Message")
It("Empty context", func() {
Error(context.TODO(), "Simple Message")
Expect(hook.LastEntry().Message).To(Equal("Simple Message"))
Expect(hook.LastEntry().Data).To(BeEmpty())
})