mirrors/navidrome
1
0
Fork 0
mirror of https://github.com/navidrome/navidrome.git synced 2025-04-04 21:17:37 +03:00
Code Issues Projects Releases Packages Wiki Activity

Fix DiscTitle OpenSubsonic compatibility. Closes #2929

Browse source
This commit is contained in:
Deluan 2024-04-08 19:05:36 -04:00
parent 81770351de
commit 4865d04ec6
4 changed files with 8 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

4
server/subsonic/responses/.snapshots/Responses AlbumWithSongsID3 with data should match .JSON
View file

@ -29,6 +29,10 @@
{ {
"disc": 2, "disc": 2,
"title": "disc 2" "title": "disc 2"
},
{
"disc": 3,
"title": ""
} }
], ],
"originalReleaseDate": { "originalReleaseDate": {

1
server/subsonic/responses/.snapshots/Responses AlbumWithSongsID3 with data should match .XML
View file

@ -4,6 +4,7 @@
<genres name="progressive"></genres> <genres name="progressive"></genres>
<discTitles disc="1" title="disc 1"></discTitles> <discTitles disc="1" title="disc 1"></discTitles>
<discTitles disc="2" title="disc 2"></discTitles> <discTitles disc="2" title="disc 2"></discTitles>
<discTitles disc="3" title=""></discTitles>
<originalReleaseDate year="1994" month="2" day="4"></originalReleaseDate> <originalReleaseDate year="1994" month="2" day="4"></originalReleaseDate>
<releaseDate year="2000" month="5" day="10"></releaseDate> <releaseDate year="2000" month="5" day="10"></releaseDate>
<song id="1" isDir="true" title="title" album="album" artist="artist" track="1" year="1985" genre="Rock" coverArt="1" size="8421341" contentType="audio/flac" suffix="flac" starred="2016-03-02T20:30:00Z" transcodedContentType="audio/mpeg" transcodedSuffix="mp3" duration="146" bitRate="320" isVideo="false" bpm="127" comment="a comment" sortName="sorted song" mediaType="song" musicBrainzId="4321"> <song id="1" isDir="true" title="title" album="album" artist="artist" track="1" year="1985" genre="Rock" coverArt="1" size="8421341" contentType="audio/flac" suffix="flac" starred="2016-03-02T20:30:00Z" transcodedContentType="audio/mpeg" transcodedSuffix="mp3" duration="146" bitRate="320" isVideo="false" bpm="127" comment="a comment" sortName="sorted song" mediaType="song" musicBrainzId="4321">

4
server/subsonic/responses/responses.go
View file

@ -501,8 +501,8 @@ type ReplayGain struct {
} }
type DiscTitle struct { type DiscTitle struct {
Disc int `xml:"disc,attr,omitempty" json:"disc,omitempty"` Disc int `xml:"disc,attr" json:"disc"`
Title string `xml:"title,attr,omitempty" json:"title,omitempty"` Title string `xml:"title,attr" json:"title"`
} }
type DiscTitles []DiscTitle type DiscTitles []DiscTitle

2
server/subsonic/responses/responses_test.go
View file

@ -176,7 +176,7 @@ var _ = Describe("Responses", func() {
Id: "1", Name: "album", Artist: "artist", Genre: "rock", Id: "1", Name: "album", Artist: "artist", Genre: "rock",
Genres: []ItemGenre{{Name: "rock"}, {Name: "progressive"}}, Genres: []ItemGenre{{Name: "rock"}, {Name: "progressive"}},
MusicBrainzId: "1234", IsCompilation: true, SortName: "sorted album", MusicBrainzId: "1234", IsCompilation: true, SortName: "sorted album",
DiscTitles: DiscTitles{{Disc: 1, Title: "disc 1"}, {Disc: 2, Title: "disc 2"}}, DiscTitles: DiscTitles{{Disc: 1, Title: "disc 1"}, {Disc: 2, Title: "disc 2"}, {Disc: 3}},
OriginalReleaseDate: ItemDate{Year: 1994, Month: 2, Day: 4}, OriginalReleaseDate: ItemDate{Year: 1994, Month: 2, Day: 4},
ReleaseDate: ItemDate{Year: 2000, Month: 5, Day: 10}, ReleaseDate: ItemDate{Year: 2000, Month: 5, Day: 10},
} }