mirrors/navidrome
1
0
Fork 0
mirror of https://github.com/navidrome/navidrome.git synced 2025-04-05 05:27:37 +03:00
Code Issues Projects Releases Packages Wiki Activity

Smarter cache of external info calls (last.fm / spotify)

Browse source
This commit is contained in:
Deluan 2021-11-03 14:13:50 -04:00
parent 9e48d87f84
commit 68a84ec832
2 changed files with 13 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

2
consts/consts.go
View file

@ -41,7 +41,7 @@ const (
RequestThrottleBacklogLimit = 100 RequestThrottleBacklogLimit = 100
RequestThrottleBacklogTimeout = time.Minute RequestThrottleBacklogTimeout = time.Minute
ArtistInfoTimeToLive = 3 * 24 * time.Hour ArtistInfoTimeToLive = 24 * time.Hour
I18nFolder = "i18n" I18nFolder = "i18n"
SkipScanFile = ".ndignore" SkipScanFile = ".ndignore"

22
core/external_metadata.go
View file

@ -83,8 +83,18 @@ func (e *externalMetadata) UpdateArtistInfo(ctx context.Context, id string, simi
return nil, err return nil, err
} }
// If we have fresh info, just return it and trigger a refresh in the background // If we don't have any info, retrieves it now
if time.Since(artist.ExternalInfoUpdatedAt) < consts.ArtistInfoTimeToLive { if artist.ExternalInfoUpdatedAt.IsZero() {
log.Debug(ctx, "ArtistInfo not cached. Retrieving it now", "updatedAt", artist.ExternalInfoUpdatedAt, "id", id, "name", artist.Name)
err = e.refreshArtistInfo(ctx, artist)
if err != nil {
return nil, err
}
}
// If info is expired, trigger a refresh in the background
if time.Since(artist.ExternalInfoUpdatedAt) > consts.ArtistInfoTimeToLive {
log.Debug("Found expired cached ArtistInfo, refreshing in the background", "updatedAt", artist.ExternalInfoUpdatedAt, "name", artist.Name)
go func() { go func() {
ctx, cancel := context.WithTimeout(context.Background(), time.Minute) ctx, cancel := context.WithTimeout(context.Background(), time.Minute)
defer cancel() defer cancel()
@ -93,16 +103,8 @@ func (e *externalMetadata) UpdateArtistInfo(ctx context.Context, id string, simi
log.Error("Error refreshing ArtistInfo", "id", id, "name", artist.Name, err) log.Error("Error refreshing ArtistInfo", "id", id, "name", artist.Name, err)
} }
}() }()
log.Debug("Found cached ArtistInfo, refreshing in the background", "updatedAt", artist.ExternalInfoUpdatedAt, "name", artist.Name)
err := e.loadSimilar(ctx, artist, similarCount, includeNotPresent)
return &artist.Artist, err
} }
log.Debug(ctx, "ArtistInfo not cached or expired", "updatedAt", artist.ExternalInfoUpdatedAt, "id", id, "name", artist.Name)
err = e.refreshArtistInfo(ctx, artist)
if err != nil {
return nil, err
}
err = e.loadSimilar(ctx, artist, similarCount, includeNotPresent) err = e.loadSimilar(ctx, artist, similarCount, includeNotPresent)
return &artist.Artist, err return &artist.Artist, err
} }