mirrors/navidrome
1
0
Fork 0
mirror of https://github.com/navidrome/navidrome.git synced 2025-04-03 12:37:37 +03:00
Code Issues Projects Releases Packages Wiki Activity

fix(insights): better status

Browse source 
Signed-off-by: Deluan <deluan@navidrome.org>
This commit is contained in:
Deluan 2024-12-19 17:21:08 -05:00
parent 04f296cc73
commit 6bc4c0317f
5 changed files with 29 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

12
core/metrics/insights.go
View file

@ -10,6 +10,7 @@ import (
"runtime"
"runtime/debug"
"sync"
"sync/atomic"
"time"
"github.com/Masterminds/squirrel"
@ -34,8 +35,8 @@ var (
type insightsCollector struct {
ds model.DataStore
lastRun time.Time
lastStatus bool
lastRun atomic.Int64
lastStatus atomic.Bool
}
func GetInstance(ds model.DataStore) Insights {
@ -68,7 +69,8 @@ func (c *insightsCollector) Run(ctx context.Context) {
}
func (c *insightsCollector) LastRun(context.Context) (timestamp time.Time, success bool) {
return c.lastRun, c.lastStatus
t := c.lastRun.Load()
return time.UnixMilli(t), c.lastStatus.Load()
}
func (c *insightsCollector) sendInsights(ctx context.Context) {
@ -102,8 +104,8 @@ func (c *insightsCollector) sendInsights(ctx context.Context) {
}
log.Info(ctx, "Sent Insights data (for details see http://navidrome.org/docs/getting-started/insights", "data",
string(data), "server", consts.InsightsEndpoint, "status", resp.Status)
c.lastRun = time.Now()
c.lastStatus = resp.StatusCode < 300
c.lastRun.Store(time.Now().UnixMilli())
c.lastStatus.Store(resp.StatusCode < 300)
resp.Body.Close()
}

2
core/metrics/insights/data.go
View file

@ -36,7 +36,7 @@ type Data struct {
Shares int64 `json:"shares"`
Radios int64 `json:"radios"`
ActiveUsers int64 `json:"activeUsers"`
ActivePlayers map[string]int64 `json:"activePlayers"`
ActivePlayers map[string]int64 `json:"activePlayers,omitempty"`
} `json:"library"`
Config struct {
LogLevel string `json:"logLevel,omitempty"`