fix(insights): better status

Signed-off-by: Deluan <deluan@navidrome.org>

core/metrics/insights.go

@@ -10,6 +10,7 @@ import (
 	"runtime"
 	"runtime/debug"
 	"sync"
+	"sync/atomic"
 	"time"
 
 	"github.com/Masterminds/squirrel"
@@ -34,8 +35,8 @@ var (
 
 type insightsCollector struct {
 	ds         model.DataStore
-	lastRun    time.Time
+	lastRun    atomic.Int64
-	lastStatus bool
+	lastStatus atomic.Bool
 }
 
 func GetInstance(ds model.DataStore) Insights {
@@ -68,7 +69,8 @@ func (c *insightsCollector) Run(ctx context.Context) {
 }
 
 func (c *insightsCollector) LastRun(context.Context) (timestamp time.Time, success bool) {
-	return c.lastRun, c.lastStatus
+	t := c.lastRun.Load()
+	return time.UnixMilli(t), c.lastStatus.Load()
 }
 
 func (c *insightsCollector) sendInsights(ctx context.Context) {
@@ -102,8 +104,8 @@ func (c *insightsCollector) sendInsights(ctx context.Context) {
 	}
 	log.Info(ctx, "Sent Insights data (for details see http://navidrome.org/docs/getting-started/insights", "data",
 		string(data), "server", consts.InsightsEndpoint, "status", resp.Status)
-	c.lastRun = time.Now()
+	c.lastRun.Store(time.Now().UnixMilli())
-	c.lastStatus = resp.StatusCode < 300
+	c.lastStatus.Store(resp.StatusCode < 300)
 	resp.Body.Close()
 }
 

core/metrics/insights/data.go

@@ -36,7 +36,7 @@ type Data struct {
 		Shares        int64            `json:"shares"`
 		Radios        int64            `json:"radios"`
 		ActiveUsers   int64            `json:"activeUsers"`
-		ActivePlayers map[string]int64 `json:"activePlayers"`
+		ActivePlayers map[string]int64 `json:"activePlayers,omitempty"`
 	} `json:"library"`
 	Config struct {
 		LogLevel                string `json:"logLevel,omitempty"`

resources/i18n/pt.json

@@ -436,7 +436,11 @@
             "homepage": "Website",
             "source": "Código fonte",
             "featureRequests": "Solicitar funcionalidade",
-            "lastInsightsCollection": "Última coleta de dados"
+            "lastInsightsCollection": "Última coleta de dados",
+            "insights": {
+                "disabled": "Desligado",
+                "waiting": "Aguardando"
+            }
         }
     },
     "activity": {

ui/src/dialogs/AboutDialog.jsx

@@ -55,6 +55,16 @@ const AboutDialog = ({ open, onClose }) => {
   const { permissions } = usePermissions()
   const { data, loading } = useGetOne('insights', 'insights_status')
 
+  const lastRun = !loading && data?.lastRun
+  let insightsStatus = 'N/A'
+  if (lastRun === 'disabled') {
+    insightsStatus = translate('about.links.insights.disabled')
+  } else if (lastRun && lastRun?.startsWith('1969-12-31')) {
+    insightsStatus = translate('about.links.insights.waiting')
+  } else if (lastRun) {
+    insightsStatus = lastRun
+  }
+
   return (
     <Dialog onClose={onClose} aria-labelledby="about-dialog-title" open={open}>
       <DialogTitle id="about-dialog-title" onClose={onClose}>
@@ -97,9 +107,7 @@ const AboutDialog = ({ open, onClose }) => {
                     {translate(`about.links.lastInsightsCollection`)}:
                   </TableCell>
                   <TableCell align="left">
-                    <Link href={INSIGHTS_DOC_URL}>
+                    <Link href={INSIGHTS_DOC_URL}>{insightsStatus}</Link>
-                      {(!loading && data?.lastRun) || 'N/A'}{' '}
-                    </Link>
                   </TableCell>
                 </TableRow>
               ) : null}

ui/src/i18n/en.json

@@ -438,7 +438,11 @@
       "homepage": "Home page",
       "source": "Source code",
       "featureRequests": "Feature requests",
-      "lastInsightsCollection": "Last insights collection"
+      "lastInsightsCollection": "Last insights collection",
+      "insights": {
+        "disabled": "Disabled",
+        "waiting": "Waiting"
+      }
     }
   },
   "activity": {