mirrors/navidrome
1
0
Fork 0
mirror of https://github.com/navidrome/navidrome.git synced 2025-04-04 13:07:36 +03:00
Code Issues Projects Releases Packages Wiki Activity

Fix race condition in external metadata retrieval

Browse source
This commit is contained in:
Deluan 2024-06-06 21:01:16 -04:00
parent 34678611c0
commit 6d526870b7
1 changed files with 7 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

14
core/external_metadata.go
View file

@ -43,8 +43,8 @@ type ExternalMetadata interface {
type externalMetadata struct { type externalMetadata struct {
ds model.DataStore ds model.DataStore
ag *agents.Agents ag *agents.Agents
artistQueue refreshQueue[*auxArtist] artistQueue refreshQueue[auxArtist]
albumQueue refreshQueue[*auxAlbum] albumQueue refreshQueue[auxAlbum]
} }
type auxAlbum struct { type auxAlbum struct {
@ -103,7 +103,7 @@ func (e *externalMetadata) UpdateAlbumInfo(ctx context.Context, id string) (*mod
// If info is expired, trigger a populateAlbumInfo in the background // If info is expired, trigger a populateAlbumInfo in the background
if time.Since(updatedAt) > conf.Server.DevAlbumInfoTimeToLive { if time.Since(updatedAt) > conf.Server.DevAlbumInfoTimeToLive {
log.Debug("Found expired cached AlbumInfo, refreshing in the background", "updatedAt", album.ExternalInfoUpdatedAt, "name", album.Name) log.Debug("Found expired cached AlbumInfo, refreshing in the background", "updatedAt", album.ExternalInfoUpdatedAt, "name", album.Name)
e.albumQueue.enqueue(album) e.albumQueue.enqueue(*album)
} }
return &album.Album, nil return &album.Album, nil
@ -206,7 +206,7 @@ func (e *externalMetadata) refreshArtistInfo(ctx context.Context, id string) (*a
// If info is expired, trigger a populateArtistInfo in the background // If info is expired, trigger a populateArtistInfo in the background
if time.Since(updatedAt) > conf.Server.DevArtistInfoTimeToLive { if time.Since(updatedAt) > conf.Server.DevArtistInfoTimeToLive {
log.Debug("Found expired cached ArtistInfo, refreshing in the background", "updatedAt", updatedAt, "name", artist.Name) log.Debug("Found expired cached ArtistInfo, refreshing in the background", "updatedAt", updatedAt, "name", artist.Name)
e.artistQueue.enqueue(artist) e.artistQueue.enqueue(*artist)
} }
return artist, nil return artist, nil
} }
@ -554,15 +554,15 @@ func (e *externalMetadata) loadSimilar(ctx context.Context, artist *auxArtist, c
type refreshQueue[T any] chan<- T type refreshQueue[T any] chan<- T
func newRefreshQueue[T any](ctx context.Context, processFn func(context.Context, T) error) refreshQueue[T] { func newRefreshQueue[T any](ctx context.Context, processFn func(context.Context, *T) error) refreshQueue[T] {
queue := make(chan T, refreshQueueLength) queue := make(chan T, refreshQueueLength)
go func() { go func() {
for { for {
time.Sleep(refreshDelay) time.Sleep(refreshDelay)
ctx, cancel := context.WithTimeout(ctx, refreshTimeout) ctx, cancel := context.WithTimeout(ctx, refreshTimeout)
select { select {
case a := <-queue: case item := <-queue:
_ = processFn(ctx, a) _ = processFn(ctx, &item)
cancel() cancel()
case <-ctx.Done(): case <-ctx.Done():
cancel() cancel()