mirrors/navidrome
1
0
Fork 0
mirror of https://github.com/navidrome/navidrome.git synced 2025-04-04 21:17:37 +03:00
Code Issues Projects Releases Packages Wiki Activity

Merge f0d493021d into 2b84c574ba

Browse source
This commit is contained in:
Kosuke Sando 2025-03-31 09:10:26 +02:00 • committed by GitHub
commit 74c24dcb9a
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
5 changed files with 43 additions and 18 deletions
Download patch file Download diff file Expand all files Collapse all files

4
core/agents/agents.go
View file

@ -160,7 +160,7 @@ func (a *Agents) GetSimilarArtists(ctx context.Context, id, name, mbid string, l
return nil, ErrNotFound return nil, ErrNotFound
} }
func (a *Agents) GetArtistImages(ctx context.Context, id, name, mbid string) ([]ExternalImage, error) { func (a *Agents) GetArtistImages(ctx context.Context, id, name, sortName, mbid string) ([]ExternalImage, error) {
switch id { switch id {
case consts.UnknownArtistID: case consts.UnknownArtistID:
return nil, ErrNotFound return nil, ErrNotFound
@ -176,7 +176,7 @@ func (a *Agents) GetArtistImages(ctx context.Context, id, name, mbid string) ([]
if !ok { if !ok {
continue continue
} }
images, err := agent.GetArtistImages(ctx, id, name, mbid) images, err := agent.GetArtistImages(ctx, id, name, sortName, mbid)
if len(images) > 0 && err == nil { if len(images) > 0 && err == nil {
log.Debug(ctx, "Got Images", "agent", ag.AgentName(), "artist", name, "images", images, "elapsed", time.Since(start)) log.Debug(ctx, "Got Images", "agent", ag.AgentName(), "artist", name, "images", images, "elapsed", time.Since(start))
return images, nil return images, nil

14
core/agents/agents_test.go
View file

@ -155,21 +155,21 @@ var _ = Describe("Agents", func() {
Describe("GetArtistImages", func() { Describe("GetArtistImages", func() {
It("returns on first match", func() { It("returns on first match", func() {
Expect(ag.GetArtistImages(ctx, "123", "test", "mb123")).To(Equal([]ExternalImage{{ Expect(ag.GetArtistImages(ctx, "123", "test", "test", "mb123")).To(Equal([]ExternalImage{{
URL: "imageUrl", URL: "imageUrl",
Size: 100, Size: 100,
}})) }}))
Expect(mock.Args).To(HaveExactElements("123", "test", "mb123")) Expect(mock.Args).To(HaveExactElements("123", "test", "test", "mb123"))
}) })
It("skips the agent if it returns an error", func() { It("skips the agent if it returns an error", func() {
mock.Err = errors.New("error") mock.Err = errors.New("error")
_, err := ag.GetArtistImages(ctx, "123", "test", "mb123") _, err := ag.GetArtistImages(ctx, "123", "test", "test", "mb123")
Expect(err).To(MatchError("not found")) Expect(err).To(MatchError("not found"))
Expect(mock.Args).To(HaveExactElements("123", "test", "mb123")) Expect(mock.Args).To(HaveExactElements("123", "test", "test", "mb123"))
}) })
It("interrupts if the context is canceled", func() { It("interrupts if the context is canceled", func() {
cancel() cancel()
_, err := ag.GetArtistImages(ctx, "123", "test", "mb123") _, err := ag.GetArtistImages(ctx, "123", "test", "test", "mb123")
Expect(err).To(MatchError(ErrNotFound)) Expect(err).To(MatchError(ErrNotFound))
Expect(mock.Args).To(BeEmpty()) Expect(mock.Args).To(BeEmpty())
}) })
@ -290,8 +290,8 @@ func (a *mockAgent) GetArtistBiography(_ context.Context, id, name, mbid string)
return "bio", nil return "bio", nil
} }
func (a *mockAgent) GetArtistImages(_ context.Context, id, name, mbid string) ([]ExternalImage, error) { func (a *mockAgent) GetArtistImages(_ context.Context, id, name, sortName, mbid string) ([]ExternalImage, error) {
a.Args = []interface{}{id, name, mbid} a.Args = []interface{}{id, name, sortName, mbid}
if a.Err != nil { if a.Err != nil {
return nil, a.Err return nil, a.Err
} }

2
core/agents/interfaces.go
View file

@ -62,7 +62,7 @@ type ArtistSimilarRetriever interface {
} }
type ArtistImageRetriever interface { type ArtistImageRetriever interface {
GetArtistImages(ctx context.Context, id, name, mbid string) ([]ExternalImage, error) GetArtistImages(ctx context.Context, id, name, sortName, mbid string) ([]ExternalImage, error)
} }
type ArtistTopSongsRetriever interface { type ArtistTopSongsRetriever interface {

39
core/agents/spotify/spotify.go
View file

@ -47,8 +47,8 @@ func (s *spotifyAgent) AgentName() string {
return spotifyAgentName return spotifyAgentName
} }
func (s *spotifyAgent) GetArtistImages(ctx context.Context, id, name, mbid string) ([]agents.ExternalImage, error) { func (s *spotifyAgent) GetArtistImages(ctx context.Context, id, name, sortName, mbid string) ([]agents.ExternalImage, error) {
a, err := s.searchArtist(ctx, name) a, err := s.searchArtist(ctx, name, sortName)
if err != nil { if err != nil {
if errors.Is(err, model.ErrNotFound) { if errors.Is(err, model.ErrNotFound) {
log.Warn(ctx, "Artist not found in Spotify", "artist", name) log.Warn(ctx, "Artist not found in Spotify", "artist", name)
@ -68,7 +68,7 @@ func (s *spotifyAgent) GetArtistImages(ctx context.Context, id, name, mbid strin
return res, nil return res, nil
} }
func (s *spotifyAgent) searchArtist(ctx context.Context, name string) (*Artist, error) { func (s *spotifyAgent) searchArtist(ctx context.Context, name string, sortName string) (*Artist, error) {
artists, err := s.client.searchArtists(ctx, name, 40) artists, err := s.client.searchArtists(ctx, name, 40)
if err != nil || len(artists) == 0 { if err != nil || len(artists) == 0 {
return nil, model.ErrNotFound return nil, model.ErrNotFound
@ -82,11 +82,36 @@ func (s *spotifyAgent) searchArtist(ctx context.Context, name string) (*Artist,
return ai < aj return ai < aj
}) })
// If the first one has the same name, that's the one // If the first result sorted by name matches the name, return that artist (should cover most use cases with English names)
if strings.ToLower(artists[0].Name) != name { if strings.ToLower(artists[0].Name) == name {
return nil, model.ErrNotFound return &artists[0], err
} }
return &artists[0], err
// If matching by name doesn't work(non-Latin alphabet names), match by sortName
sortName = strings.ToLower(sortName)
sort.Slice(artists, func(i, j int) bool {
ai := fmt.Sprintf("%-5t-%03d-%04d", len(artists[i].Images) == 0, customMetric(strings.ToLower(artists[i].Name), sortName), 1000-artists[i].Popularity)
aj := fmt.Sprintf("%-5t-%03d-%04d", len(artists[j].Images) == 0, customMetric(strings.ToLower(artists[j].Name), sortName), 1000-artists[j].Popularity)
return ai < aj
})
// If the first one has a similar name to sortName, that is the one
if customMetric(strings.ToLower(artists[0].Name), sortName) < 1 {
return &artists[0], err
}
return nil, model.ErrNotFound
}
func customMetric(name string, sortName string) int {
// Because sortNames often have commas and have different word orders(e.g. "John Williams" -> "Williams, John", "The Beatles"->"Beatles, The"),
// this custom metric returns the number of letters that are different from "name" and "sortName" but irrespective of the word order
name = strings.ReplaceAll(name, " ", "")
sortName = strings.ReplaceAll(sortName, " ", "")
substrings := strings.Split(sortName, ",")
for _, ss := range substrings {
name = strings.Replace(name, ss, "", 1)
}
return len(name)
} }
func init() { func init() {

2
core/external_metadata.go
View file

@ -439,7 +439,7 @@ func (e *externalMetadata) callGetBiography(ctx context.Context, agent agents.Ar
} }
func (e *externalMetadata) callGetImage(ctx context.Context, agent agents.ArtistImageRetriever, artist *auxArtist) { func (e *externalMetadata) callGetImage(ctx context.Context, agent agents.ArtistImageRetriever, artist *auxArtist) {
images, err := agent.GetArtistImages(ctx, artist.ID, artist.Name, artist.MbzArtistID) images, err := agent.GetArtistImages(ctx, artist.ID, artist.Name, artist.SortArtistName, artist.MbzArtistID)
if err != nil { if err != nil {
return return
} }