convert to Ginkgo

Signed-off-by: Deluan <deluan@navidrome.org>

core/external_metadata_simple_test.go

@@ -6,7 +6,6 @@ import (
 	"log"
 	"reflect"
 	"strings"
-	"testing"
 	"unsafe"
 
 	"github.com/Masterminds/squirrel"
@@ -15,7 +14,8 @@ import (
 	"github.com/navidrome/navidrome/model"
 	"github.com/navidrome/navidrome/tests"
 	"github.com/navidrome/navidrome/utils/str"
-	"github.com/stretchr/testify/assert"
+	. "github.com/onsi/ginkgo/v2"
+	. "github.com/onsi/gomega"
 )
 
 // Custom implementation of ArtistRepository for testing
@@ -285,14 +285,25 @@ func setStructField(obj interface{}, fieldName string, value interface{}) {
 	rf.Set(reflect.ValueOf(value))
 }
 
-// Direct implementation of ExternalMetadata for testing that avoids agents registration issues
-func TestDirectTopSongs(t *testing.T) {
-	// Setup
-	ctx := context.Background()
+var _ = Describe("CustomExternalMetadata", func() {
+	var ctx context.Context
 
+	BeforeEach(func() {
+		ctx = context.Background()
+	})
+
+	Describe("DirectTopSongs", func() {
+		var mockArtistRepo *customArtistRepo
+		var mockMediaFileRepo *customMediaFileRepo
+		var mockDS *tests.MockDataStore
+		var mockAgent *MockAgent
+		var agentsImpl *agents.Agents
+		var em ExternalMetadata
+
+		BeforeEach(func() {
 			// Create custom mock repositories
-	mockArtistRepo := newCustomArtistRepo()
-	mockMediaFileRepo := newCustomMediaFileRepo()
+			mockArtistRepo = newCustomArtistRepo()
+			mockMediaFileRepo = newCustomMediaFileRepo()
 
 			// Configure mock data
 			artist := model.Artist{ID: "artist-1", Name: "Artist One"}
@@ -326,13 +337,13 @@ func TestDirectTopSongs(t *testing.T) {
 			}
 
 			// Create mock datastore
-	mockDS := &tests.MockDataStore{
+			mockDS = &tests.MockDataStore{
 				MockedArtist:    mockArtistRepo,
 				MockedMediaFile: mockMediaFileRepo,
 			}
 
 			// Create mock agent
-	mockAgent := &MockAgent{
+			mockAgent = &MockAgent{
 				topSongs: []agents.Song{
 					{Name: "Song One", MBID: "mbid-1"},
 					{Name: "Song Two", MBID: "mbid-2"},
@@ -340,51 +351,50 @@ func TestDirectTopSongs(t *testing.T) {
 			}
 
 			// Use the real agents.Agents implementation but with our mock agent
-	agentsImpl := &agents.Agents{}
+			agentsImpl = &agents.Agents{}
 
 			// Set unexported fields using reflection and unsafe
 			setStructField(agentsImpl, "ds", mockDS)
 			setStructField(agentsImpl, "agents", []agents.Interface{mockAgent})
 
 			// Create our service under test
-	em := NewExternalMetadata(mockDS, agentsImpl)
+			em = NewExternalMetadata(mockDS, agentsImpl)
+		})
 
-	// Test
+		It("returns matching songs from the artist results", func() {
 			log.Printf("Test: Calling TopSongs for artist: %s", "Artist One")
 			songs, err := em.TopSongs(ctx, "Artist One", 5)
 
 			log.Printf("Test: Result: error=%v, songs=%v", err, songs)
 
-	// Assertions
-	assert.NoError(t, err)
-	assert.Len(t, songs, 2)
-	if len(songs) > 0 {
-		assert.Equal(t, "song-1", songs[0].ID)
-	}
-	if len(songs) > 1 {
-		assert.Equal(t, "song-2", songs[1].ID)
-	}
-}
+			Expect(err).ToNot(HaveOccurred())
+			Expect(songs).To(HaveLen(2))
+			Expect(songs[0].ID).To(Equal("song-1"))
+			Expect(songs[1].ID).To(Equal("song-2"))
+		})
+	})
 
-func TestTopSongs(t *testing.T) {
-	// Setup
-	ctx := context.Background()
+	Describe("TopSongs with agent registration", func() {
+		var mockArtistRepo *customArtistRepo
+		var mockMediaFileRepo *customMediaFileRepo
+		var mockDS *tests.MockDataStore
+		var mockAgent *MockAgent
+		var em ExternalMetadata
+		var originalAgentsConfig string
 
+		BeforeEach(func() {
 			// Store the original config to restore it later
-	originalAgentsConfig := conf.Server.Agents
+			originalAgentsConfig = conf.Server.Agents
 
 			// Set our mock agent as the only agent
 			conf.Server.Agents = "mock"
-	defer func() {
-		conf.Server.Agents = originalAgentsConfig
-	}()
 
 			// Clear the agents map to prevent interference
 			agents.Map = nil
 
 			// Create custom mock repositories
-	mockArtistRepo := newCustomArtistRepo()
-	mockMediaFileRepo := newCustomMediaFileRepo()
+			mockArtistRepo = newCustomArtistRepo()
+			mockMediaFileRepo = newCustomMediaFileRepo()
 
 			// Configure mock data
 			artist := model.Artist{ID: "artist-1", Name: "Artist One"}
@@ -418,13 +428,13 @@ func TestTopSongs(t *testing.T) {
 			}
 
 			// Create mock datastore
-	mockDS := &tests.MockDataStore{
+			mockDS = &tests.MockDataStore{
 				MockedArtist:    mockArtistRepo,
 				MockedMediaFile: mockMediaFileRepo,
 			}
 
 			// Create and register a mock agent
-	mockAgent := &MockAgent{
+			mockAgent = &MockAgent{
 				topSongs: []agents.Song{
 					{Name: "Song One", MBID: "mbid-1"},
 					{Name: "Song Two", MBID: "mbid-2"},
@@ -442,21 +452,23 @@ func TestTopSongs(t *testing.T) {
 
 			// Create the service to test
 			log.Printf("Test: Creating ExternalMetadata with conf.Server.Agents=%s", conf.Server.Agents)
-	em := NewExternalMetadata(mockDS, agents.GetAgents(mockDS))
+			em = NewExternalMetadata(mockDS, agents.GetAgents(mockDS))
+		})
 
-	// Test
+		AfterEach(func() {
+			conf.Server.Agents = originalAgentsConfig
+		})
+
+		It("returns matching songs from the registered agent", func() {
 			log.Printf("Test: Calling TopSongs for artist: %s", "Artist One")
 			songs, err := em.TopSongs(ctx, "Artist One", 5)
 
 			log.Printf("Test: Result: error=%v, songs=%v", err, songs)
 
-	// Assertions
-	assert.NoError(t, err)
-	assert.Len(t, songs, 2)
-	if len(songs) > 0 {
-		assert.Equal(t, "song-1", songs[0].ID)
-	}
-	if len(songs) > 1 {
-		assert.Equal(t, "song-2", songs[1].ID)
-	}
-}
+			Expect(err).ToNot(HaveOccurred())
+			Expect(songs).To(HaveLen(2))
+			Expect(songs[0].ID).To(Equal("song-1"))
+			Expect(songs[1].ID).To(Equal("song-2"))
+		})
+	})
+})