mirrors/navidrome
1
0
Fork 0
mirror of https://github.com/navidrome/navidrome.git synced 2025-04-04 21:17:37 +03:00
Code Issues Projects Releases Packages Wiki Activity

Replace COUNT(DISTINCT primary_key) with COUNT(*)

Browse source
This commit is contained in:
Deluan 2023-11-25 22:29:05 -05:00
parent b964018cd7
commit 8c8e1ea701
4 changed files with 2 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

1
persistence/album_repository.go
View file

@ -76,7 +76,6 @@ func artistFilter(field string, value interface{}) Sqlizer {
func (r *albumRepository) CountAll(options ...model.QueryOptions) (int64, error) { func (r *albumRepository) CountAll(options ...model.QueryOptions) (int64, error) {
sql := r.newSelectWithAnnotation("album.id") sql := r.newSelectWithAnnotation("album.id")
sql = r.withGenres(sql)
return r.count(sql, options...) return r.count(sql, options...)
} }

1
persistence/artist_repository.go
View file

@ -52,7 +52,6 @@ func (r *artistRepository) selectArtist(options ...model.QueryOptions) SelectBui
func (r *artistRepository) CountAll(options ...model.QueryOptions) (int64, error) { func (r *artistRepository) CountAll(options ...model.QueryOptions) (int64, error) {
sql := r.newSelectWithAnnotation("artist.id") sql := r.newSelectWithAnnotation("artist.id")
sql = r.withGenres(sql)
return r.count(sql, options...) return r.count(sql, options...)
} }

1
persistence/mediafile_repository.go
View file

@ -40,7 +40,6 @@ func NewMediaFileRepository(ctx context.Context, o orm.QueryExecutor) *mediaFile
func (r *mediaFileRepository) CountAll(options ...model.QueryOptions) (int64, error) { func (r *mediaFileRepository) CountAll(options ...model.QueryOptions) (int64, error) {
sql := r.newSelectWithAnnotation("media_file.id") sql := r.newSelectWithAnnotation("media_file.id")
sql = r.withGenres(sql)
return r.count(sql, options...) return r.count(sql, options...)
} }

3
persistence/sql_base_repository.go
View file

@ -180,7 +180,8 @@ func (r sqlRepository) exists(existsQuery SelectBuilder) (bool, error) {
} }
func (r sqlRepository) count(countQuery SelectBuilder, options ...model.QueryOptions) (int64, error) { func (r sqlRepository) count(countQuery SelectBuilder, options ...model.QueryOptions) (int64, error) {
countQuery = countQuery.Columns("count(distinct " + r.tableName + ".id) as count").From(r.tableName) countQuery = countQuery.
RemoveColumns().Columns("count(*) as count").From(r.tableName)
countQuery = r.applyFilters(countQuery, options...) countQuery = r.applyFilters(countQuery, options...)
var res struct{ Count int64 } var res struct{ Count int64 }
err := r.queryOne(countQuery, &res) err := r.queryOne(countQuery, &res)