From aee19e747cec38d8093f67a76df6fb699ea94ea8 Mon Sep 17 00:00:00 2001 From: Kendall Garner <17521368+kgarner7@users.noreply.github.com> Date: Sat, 22 Feb 2025 14:31:20 +0000 Subject: [PATCH] feat(ui): Improve Artist Album pagination (#3748) * feat(ui): Improve Artist Album pagination - use maximum of albumartist/artist credits for determining pagination - reduce default maxPerPage considerably. This gives values of 36/72/108 at largest size * enable pagination when over 90 Signed-off-by: Deluan --------- Signed-off-by: Deluan Co-authored-by: Deluan --- ui/src/artist/ArtistShow.jsx | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/ui/src/artist/ArtistShow.jsx b/ui/src/artist/ArtistShow.jsx index 180f3a5b2..2f3ff4299 100644 --- a/ui/src/artist/ArtistShow.jsx +++ b/ui/src/artist/ArtistShow.jsx @@ -60,9 +60,16 @@ const AlbumShowLayout = (props) => { let perPage = 0 let pagination = null - if (record?.stats?.['artist']?.albumCount > maxPerPage) { + const count = Math.max( + record?.stats?.['albumartist']?.albumCount || 0, + record?.stats?.['artist']?.albumCount ?? 0, + ) + + if (count > maxPerPage) { perPage = Math.trunc(maxPerPage / perPageOptions[0]) * perPageOptions[0] - const rowsPerPageOptions = [1, 2, 3].map((option) => option * perPage) + const rowsPerPageOptions = [1, 2, 3].map((option) => + Math.trunc(option * (perPage / 3)), + ) pagination = }