mirrors/navidrome
1
0
Fork 0
mirror of https://github.com/navidrome/navidrome.git synced 2025-04-04 13:07:36 +03:00
Code Issues Projects Releases Packages Wiki Activity

Fix XML marshaling of OpenSubsonic structured lyrics (#3041)

Browse source
This commit is contained in:
Drew Weymouth 2024-05-22 09:15:14 -07:00 • committed by GitHub
parent f88d3f82da
commit b6fce0e686
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 5 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

16
server/subsonic/responses/.snapshots/Responses LyricsList with data should match .XML
View file

@ -1,20 +1,12 @@
<subsonic-response xmlns="http://subsonic.org/restapi" status="ok" version="1.8.0" type="navidrome" serverVersion="v0.0.0" openSubsonic="true"> <subsonic-response xmlns="http://subsonic.org/restapi" status="ok" version="1.8.0" type="navidrome" serverVersion="v0.0.0" openSubsonic="true">
<lyricsList> <lyricsList>
<structuredLyrics displayArtist="Rick Astley" displayTitle="Never Gonna Give You Up" lang="eng" offset="100" synced="true"> <structuredLyrics displayArtist="Rick Astley" displayTitle="Never Gonna Give You Up" lang="eng" offset="100" synced="true">
<line start="18800"> <line start="18800">We&#39;re no strangers to love</line>
<value>We&#39;re no strangers to love</value> <line start="22801">You know the rules and so do I</line>
</line>
<line start="22801">
<value>You know the rules and so do I</value>
</line>
</structuredLyrics> </structuredLyrics>
<structuredLyrics displayArtist="Rick Astley" displayTitle="Never Gonna Give You Up" lang="xxx" offset="100" synced="false"> <structuredLyrics displayArtist="Rick Astley" displayTitle="Never Gonna Give You Up" lang="xxx" offset="100" synced="false">
<line> <line>We&#39;re no strangers to love</line>
<value>We&#39;re no strangers to love</value> <line>You know the rules and so do I</line>
</line>
<line>
<value>You know the rules and so do I</value>
</line>
</structuredLyrics> </structuredLyrics>
</lyricsList> </lyricsList>
</subsonic-response> </subsonic-response>

2
server/subsonic/responses/responses.go
View file

@ -458,7 +458,7 @@ type JukeboxPlaylist struct {
type Line struct { type Line struct {
Start *int64 `xml:"start,attr,omitempty" json:"start,omitempty"` Start *int64 `xml:"start,attr,omitempty" json:"start,omitempty"`
Value string `xml:"value" json:"value"` Value string `xml:",chardata" json:"value"`
} }
type StructuredLyric struct { type StructuredLyric struct {