mirror of
https://github.com/navidrome/navidrome.git
synced 2025-04-04 21:17:37 +03:00
Fix marshaling for genres.
This commit is contained in:
Caio Cotts
Deluan Quintão
parent
5d1493e845
commit
bb7186ce2f
10 changed files with 233 additions and 83 deletions
|
|
@ -0,0 +1,55 @@
|
|||
{
|
||||
"status": "ok",
|
||||
"version": "1.8.0",
|
||||
"type": "navidrome",
|
||||
"serverVersion": "v0.0.0",
|
||||
"openSubsonic": true,
|
||||
"album": {
|
||||
"id": "1",
|
||||
"name": "album",
|
||||
"artist": "artist",
|
||||
"userRating": 0,
|
||||
"genre": "rock",
|
||||
"genres": [
|
||||
{
|
||||
"name": "rock"
|
||||
},
|
||||
{
|
||||
"name": "progressive"
|
||||
}
|
||||
],
|
||||
"musicBrainzId": "1234",
|
||||
"song": [
|
||||
{
|
||||
"id": "1",
|
||||
"isDir": true,
|
||||
"title": "title",
|
||||
"album": "album",
|
||||
"artist": "artist",
|
||||
"track": 1,
|
||||
"year": 1985,
|
||||
"genre": "Rock",
|
||||
"genres": [
|
||||
{
|
||||
"name": "rock"
|
||||
},
|
||||
{
|
||||
"name": "progressive"
|
||||
}
|
||||
],
|
||||
"coverArt": "1",
|
||||
"size": 8421341,
|
||||
"contentType": "audio/flac",
|
||||
"suffix": "flac",
|
||||
"starred": "2016-03-02T20:30:00Z",
|
||||
"transcodedContentType": "audio/mpeg",
|
||||
"transcodedSuffix": "mp3",
|
||||
"duration": 146,
|
||||
"bitRate": 320,
|
||||
"isVideo": false,
|
||||
"bpm": 127,
|
||||
"comment": "a comment"
|
||||
}
|
||||
]
|
||||
}
|
||||
}
|
||||
|
|
@ -0,0 +1,10 @@
|
|||
<subsonic-response xmlns="http://subsonic.org/restapi" status="ok" version="1.8.0" type="navidrome" serverVersion="v0.0.0" openSubsonic="true">
|
||||
<album id="1" name="album" artist="artist" userRating="0" genre="rock" musicBrainzId="1234">
|
||||
<genres name="rock"></genres>
|
||||
<genres name="progressive"></genres>
|
||||
<song id="1" isDir="true" title="title" album="album" artist="artist" track="1" year="1985" genre="Rock" coverArt="1" size="8421341" contentType="audio/flac" suffix="flac" starred="2016-03-02T20:30:00Z" transcodedContentType="audio/mpeg" transcodedSuffix="mp3" duration="146" bitRate="320" isVideo="false" bpm="127" comment="a comment">
|
||||
<genres name="rock"></genres>
|
||||
<genres name="progressive"></genres>
|
||||
</song>
|
||||
</album>
|
||||
</subsonic-response>
|
||||
|
|
@ -0,0 +1,14 @@
|
|||
{
|
||||
"status": "ok",
|
||||
"version": "1.8.0",
|
||||
"type": "navidrome",
|
||||
"serverVersion": "v0.0.0",
|
||||
"openSubsonic": true,
|
||||
"album": {
|
||||
"id": "",
|
||||
"name": "",
|
||||
"userRating": 0,
|
||||
"genres": [],
|
||||
"musicBrainzId": ""
|
||||
}
|
||||
}
|
||||
|
|
@ -0,0 +1,3 @@
|
|||
<subsonic-response xmlns="http://subsonic.org/restapi" status="ok" version="1.8.0" type="navidrome" serverVersion="v0.0.0" openSubsonic="true">
|
||||
<album id="" name="" userRating="0" musicBrainzId=""></album>
|
||||
</subsonic-response>
|
||||
|
|
@ -15,7 +15,14 @@
|
|||
"track": 1,
|
||||
"year": 1985,
|
||||
"genre": "Rock",
|
||||
"genres": [],
|
||||
"genres": [
|
||||
{
|
||||
"name": "rock"
|
||||
},
|
||||
{
|
||||
"name": "progressive"
|
||||
}
|
||||
],
|
||||
"coverArt": "1",
|
||||
"size": 8421341,
|
||||
"contentType": "audio/flac",
|
||||
|
|
@ -26,8 +33,8 @@
|
|||
"duration": 146,
|
||||
"bitRate": 320,
|
||||
"isVideo": false,
|
||||
"bpm": 0,
|
||||
"comment": ""
|
||||
"bpm": 127,
|
||||
"comment": "a comment"
|
||||
}
|
||||
],
|
||||
"id": "1",
|
||||
|
|
|
|||
|
|
@ -1,5 +1,8 @@
|
|||
<subsonic-response xmlns="http://subsonic.org/restapi" status="ok" version="1.8.0" type="navidrome" serverVersion="v0.0.0" openSubsonic="true">
|
||||
<directory id="1" name="N">
|
||||
<child id="1" isDir="true" title="title" album="album" artist="artist" track="1" year="1985" genre="Rock" coverArt="1" size="8421341" contentType="audio/flac" suffix="flac" starred="2016-03-02T20:30:00Z" transcodedContentType="audio/mpeg" transcodedSuffix="mp3" duration="146" bitRate="320" isVideo="false" bpm="0" comment=""></child>
|
||||
<child id="1" isDir="true" title="title" album="album" artist="artist" track="1" year="1985" genre="Rock" coverArt="1" size="8421341" contentType="audio/flac" suffix="flac" starred="2016-03-02T20:30:00Z" transcodedContentType="audio/mpeg" transcodedSuffix="mp3" duration="146" bitRate="320" isVideo="false" bpm="127" comment="a comment">
|
||||
<genres name="rock"></genres>
|
||||
<genres name="progressive"></genres>
|
||||
</child>
|
||||
</directory>
|
||||
</subsonic-response>
|
||||
|
|
|
|||
|
|
@ -0,0 +1,21 @@
|
|||
{
|
||||
"status": "ok",
|
||||
"version": "1.8.0",
|
||||
"type": "navidrome",
|
||||
"serverVersion": "v0.0.0",
|
||||
"openSubsonic": true,
|
||||
"directory": {
|
||||
"child": [
|
||||
{
|
||||
"id": "1",
|
||||
"isDir": false,
|
||||
"genres": [],
|
||||
"isVideo": false,
|
||||
"bpm": 0,
|
||||
"comment": ""
|
||||
}
|
||||
],
|
||||
"id": "",
|
||||
"name": ""
|
||||
}
|
||||
}
|
||||
|
|
@ -0,0 +1,5 @@
|
|||
<subsonic-response xmlns="http://subsonic.org/restapi" status="ok" version="1.8.0" type="navidrome" serverVersion="v0.0.0" openSubsonic="true">
|
||||
<directory id="" name="">
|
||||
<child id="1" isDir="false" isVideo="false" bpm="0" comment=""></child>
|
||||
</directory>
|
||||
</subsonic-response>
|
||||
|
|
@ -117,7 +117,7 @@ type Child struct {
|
|||
Track int32 `xml:"track,attr,omitempty" json:"track,omitempty"`
|
||||
Year int32 `xml:"year,attr,omitempty" json:"year,omitempty"`
|
||||
Genre string `xml:"genre,attr,omitempty" json:"genre,omitempty"`
|
||||
Genres []ItemGenre `xml:"genres" json:"genres"`
|
||||
Genres ItemGenres `xml:"genres" json:"genres"`
|
||||
CoverArt string `xml:"coverArt,attr,omitempty" json:"coverArt,omitempty"`
|
||||
Size int64 `xml:"size,attr,omitempty" json:"size,omitempty"`
|
||||
ContentType string `xml:"contentType,attr,omitempty" json:"contentType,omitempty"`
|
||||
|
|
@ -146,20 +146,6 @@ type Child struct {
|
|||
*/
|
||||
}
|
||||
|
||||
func (c Child) MarshalJSON() ([]byte, error) {
|
||||
// ensure fields that need custom default values are set properly
|
||||
type Alias Child
|
||||
a := struct {
|
||||
Alias
|
||||
}{
|
||||
Alias: (Alias)(c),
|
||||
}
|
||||
if a.Genres == nil {
|
||||
a.Genres = make([]ItemGenre, 0)
|
||||
}
|
||||
return json.Marshal(a)
|
||||
}
|
||||
|
||||
type Songs struct {
|
||||
Songs []Child `xml:"song" json:"song,omitempty"`
|
||||
}
|
||||
|
|
@ -216,24 +202,10 @@ type AlbumID3 struct {
|
|||
UserRating int32 `xml:"userRating,attr" json:"userRating"`
|
||||
Year int32 `xml:"year,attr,omitempty" json:"year,omitempty"`
|
||||
Genre string `xml:"genre,attr,omitempty" json:"genre,omitempty"`
|
||||
Genres []ItemGenre `xml:"genres" json:"genres"`
|
||||
Genres ItemGenres `xml:"genres" json:"genres"`
|
||||
MusicBrainzId string `xml:"musicBrainzId,attr" json:"musicBrainzId"`
|
||||
}
|
||||
|
||||
func (a AlbumID3) MarshalJSON() ([]byte, error) {
|
||||
// ensure fields that need custom default values are set properly
|
||||
type Alias AlbumID3
|
||||
x := struct {
|
||||
Alias
|
||||
}{
|
||||
Alias: (Alias)(a),
|
||||
}
|
||||
if x.Genres == nil {
|
||||
x.Genres = make([]ItemGenre, 0)
|
||||
}
|
||||
return json.Marshal(x)
|
||||
}
|
||||
|
||||
type ArtistWithAlbumsID3 struct {
|
||||
ArtistID3
|
||||
Album []Child `xml:"album" json:"album,omitempty"`
|
||||
|
|
@ -458,3 +430,14 @@ type OpenSubsonicExtensions struct{}
|
|||
type ItemGenre struct {
|
||||
Name string `xml:"name,attr" json:"name"`
|
||||
}
|
||||
|
||||
type ItemGenres []ItemGenre
|
||||
|
||||
func (i ItemGenres) MarshalJSON() ([]byte, error) {
|
||||
if len(i) == 0 {
|
||||
return json.Marshal([]ItemGenre{})
|
||||
}
|
||||
type Alias []ItemGenre
|
||||
a := (Alias)(i)
|
||||
return json.Marshal(a)
|
||||
}
|
||||
|
|
|
|||
|
|
@ -121,6 +121,17 @@ var _ = Describe("Responses", func() {
|
|||
})
|
||||
|
||||
Describe("Child", func() {
|
||||
Context("without data", func() {
|
||||
BeforeEach(func() {
|
||||
response.Directory = &Directory{Child: []Child{{Id: "1"}}}
|
||||
})
|
||||
It("should match .XML", func() {
|
||||
Expect(xml.MarshalIndent(response, "", " ")).To(MatchSnapshot())
|
||||
})
|
||||
It("should match .JSON", func() {
|
||||
Expect(json.MarshalIndent(response, "", " ")).To(MatchSnapshot())
|
||||
})
|
||||
})
|
||||
Context("with data", func() {
|
||||
BeforeEach(func() {
|
||||
response.Directory = &Directory{Id: "1", Name: "N"}
|
||||
|
|
@ -130,7 +141,8 @@ var _ = Describe("Responses", func() {
|
|||
Id: "1", IsDir: true, Title: "title", Album: "album", Artist: "artist", Track: 1,
|
||||
Year: 1985, Genre: "Rock", CoverArt: "1", Size: 8421341, ContentType: "audio/flac",
|
||||
Suffix: "flac", TranscodedContentType: "audio/mpeg", TranscodedSuffix: "mp3",
|
||||
Duration: 146, BitRate: 320, Starred: &t,
|
||||
Duration: 146, BitRate: 320, Starred: &t, Genres: []ItemGenre{{Name: "rock"}, {Name: "progressive"}},
|
||||
Comment: "a comment", Bpm: 127,
|
||||
}
|
||||
response.Directory.Child = child
|
||||
})
|
||||
|
|
@ -144,6 +156,43 @@ var _ = Describe("Responses", func() {
|
|||
})
|
||||
})
|
||||
|
||||
Describe("AlbumWithSongsID3", func() {
|
||||
BeforeEach(func() {
|
||||
response.AlbumWithSongsID3 = &AlbumWithSongsID3{}
|
||||
})
|
||||
Context("without data", func() {
|
||||
It("should match .XML", func() {
|
||||
Expect(xml.MarshalIndent(response, "", " ")).To(MatchSnapshot())
|
||||
})
|
||||
It("should match .JSON", func() {
|
||||
Expect(json.MarshalIndent(response, "", " ")).To(MatchSnapshot())
|
||||
})
|
||||
})
|
||||
|
||||
Context("with data", func() {
|
||||
BeforeEach(func() {
|
||||
album := AlbumID3{Id: "1", Name: "album", Artist: "artist", Genre: "rock",
|
||||
Genres: []ItemGenre{{Name: "rock"}, {Name: "progressive"}}, MusicBrainzId: "1234"}
|
||||
t := time.Date(2016, 03, 2, 20, 30, 0, 0, time.UTC)
|
||||
songs := []Child{{
|
||||
Id: "1", IsDir: true, Title: "title", Album: "album", Artist: "artist", Track: 1,
|
||||
Year: 1985, Genre: "Rock", CoverArt: "1", Size: 8421341, ContentType: "audio/flac",
|
||||
Suffix: "flac", TranscodedContentType: "audio/mpeg", TranscodedSuffix: "mp3",
|
||||
Duration: 146, BitRate: 320, Starred: &t, Genres: []ItemGenre{{Name: "rock"}, {Name: "progressive"}},
|
||||
Comment: "a comment", Bpm: 127,
|
||||
}}
|
||||
response.AlbumWithSongsID3.AlbumID3 = album
|
||||
response.AlbumWithSongsID3.Song = songs
|
||||
})
|
||||
It("should match .XML", func() {
|
||||
Expect(xml.MarshalIndent(response, "", " ")).To(MatchSnapshot())
|
||||
})
|
||||
It("should match .JSON", func() {
|
||||
Expect(json.MarshalIndent(response, "", " ")).To(MatchSnapshot())
|
||||
})
|
||||
})
|
||||
})
|
||||
|
||||
Describe("Directory", func() {
|
||||
BeforeEach(func() {
|
||||
response.Directory = &Directory{Id: "1", Name: "N"}
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue