mirrors/navidrome
1
0
Fork 0
mirror of https://github.com/navidrome/navidrome.git synced 2025-04-04 13:07:36 +03:00
Code Issues Projects Releases Packages Wiki Activity

Fix logging smart playlist's song count

Browse source
This commit is contained in:
Deluan 2021-11-20 12:29:09 -05:00
parent 3e282df639
commit cbeaadf8e2
4 changed files with 18 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

1
model/playlist.go
View file

@ -90,7 +90,6 @@ type PlaylistRepository interface {
GetWithTracks(id string) (*Playlist, error) GetWithTracks(id string) (*Playlist, error)
GetAll(options ...QueryOptions) (Playlists, error) GetAll(options ...QueryOptions) (Playlists, error)
FindByPath(path string) (*Playlist, error) FindByPath(path string) (*Playlist, error)
RefreshStatus(playlistId string) error
Delete(id string) error Delete(id string) error
Tracks(playlistId string) PlaylistTrackRepository Tracks(playlistId string) PlaylistTrackRepository
} }

24
persistence/playlist_repository.go
View file

@ -113,7 +113,7 @@ func (r *playlistRepository) Put(p *model.Playlist) error {
if len(pls.Tracks) > 0 { if len(pls.Tracks) > 0 {
return r.updateTracks(id, p.MediaFiles()) return r.updateTracks(id, p.MediaFiles())
} }
return r.RefreshStatus(id) return r.refreshCounters(&pls.Playlist)
} }
func (r *playlistRepository) Get(id string) (*model.Playlist, error) { func (r *playlistRepository) Get(id string) (*model.Playlist, error) {
@ -224,14 +224,14 @@ func (r *playlistRepository) refreshSmartPlaylist(pls *model.Playlist) bool {
LeftJoin("genre on ag.genre_id = genre.id").GroupBy("media_file.id") LeftJoin("genre on ag.genre_id = genre.id").GroupBy("media_file.id")
sql = r.addCriteria(sql, rules) sql = r.addCriteria(sql, rules)
insSql := Insert("playlist_tracks").Columns("id", "playlist_id", "media_file_id").Select(sql) insSql := Insert("playlist_tracks").Columns("id", "playlist_id", "media_file_id").Select(sql)
c, err := r.executeSQL(insSql) _, err = r.executeSQL(insSql)
if err != nil { if err != nil {
log.Error(r.ctx, "Error refreshing smart playlist tracks", "playlist", pls.Name, "id", pls.ID, err) log.Error(r.ctx, "Error refreshing smart playlist tracks", "playlist", pls.Name, "id", pls.ID, err)
return false return false
} }
// Update playlist stats // Update playlist stats
err = r.RefreshStatus(pls.ID) err = r.refreshCounters(pls)
if err != nil { if err != nil {
log.Error(r.ctx, "Error updating smart playlist stats", "playlist", pls.Name, "id", pls.ID, err) log.Error(r.ctx, "Error updating smart playlist stats", "playlist", pls.Name, "id", pls.ID, err)
return false return false
@ -245,7 +245,7 @@ func (r *playlistRepository) refreshSmartPlaylist(pls *model.Playlist) bool {
return false return false
} }
log.Debug(r.ctx, "Refreshed playlist", "playlist", pls.Name, "id", pls.ID, "numTracks", c, "elapsed", time.Since(start)) log.Debug(r.ctx, "Refreshed playlist", "playlist", pls.Name, "id", pls.ID, "numTracks", pls.SongCount, "elapsed", time.Since(start))
return true return true
} }
@ -302,15 +302,15 @@ func (r *playlistRepository) addTracks(playlistId string, startingPos int, media
} }
} }
return r.RefreshStatus(playlistId) return r.refreshCounters(&model.Playlist{ID: playlistId})
} }
// RefreshStatus updates total playlist duration, size and count // RefreshStatus updates total playlist duration, size and count
func (r *playlistRepository) RefreshStatus(playlistId string) error { func (r *playlistRepository) refreshCounters(pls *model.Playlist) error {
statsSql := Select("sum(duration) as duration", "sum(size) as size", "count(*) as count"). statsSql := Select("sum(duration) as duration", "sum(size) as size", "count(*) as count").
From("media_file"). From("media_file").
Join("playlist_tracks f on f.media_file_id = media_file.id"). Join("playlist_tracks f on f.media_file_id = media_file.id").
Where(Eq{"playlist_id": playlistId}) Where(Eq{"playlist_id": pls.ID})
var res struct{ Duration, Size, Count float32 } var res struct{ Duration, Size, Count float32 }
err := r.queryOne(statsSql, &res) err := r.queryOne(statsSql, &res)
if err != nil { if err != nil {
@ -323,9 +323,15 @@ func (r *playlistRepository) RefreshStatus(playlistId string) error {
Set("size", res.Size). Set("size", res.Size).
Set("song_count", res.Count). Set("song_count", res.Count).
Set("updated_at", time.Now()). Set("updated_at", time.Now()).
Where(Eq{"id": playlistId}) Where(Eq{"id": pls.ID})
_, err = r.executeSQL(upd) _, err = r.executeSQL(upd)
return err if err != nil {
return err
}
pls.SongCount = int(res.Count)
pls.Duration = res.Duration
pls.Size = int64(res.Size)
return nil
} }
func (r *playlistRepository) loadTracks(sel SelectBuilder, id string) (model.PlaylistTracks, error) { func (r *playlistRepository) loadTracks(sel SelectBuilder, id string) (model.PlaylistTracks, error) {

4
persistence/playlist_track_repository.go
View file

@ -30,9 +30,7 @@ func (r *playlistRepository) Tracks(playlistId string) model.PlaylistTrackReposi
if err != nil { if err != nil {
return nil return nil
} }
if pls.IsSmartPlaylist() { r.refreshSmartPlaylist(pls)
r.refreshSmartPlaylist(pls)
}
p.playlist = pls p.playlist = pls
return p return p
} }

4
scanner/playlist_importer.go
View file

@ -42,9 +42,9 @@ func (s *playlistImporter) processPlaylists(ctx context.Context, dir string) int
continue continue
} }
if pls.IsSmartPlaylist() { if pls.IsSmartPlaylist() {
log.Debug("Imported smart playlist", "name", pls.Name, "lastUpdated", pls.UpdatedAt, "path", pls.Path, "numTracks", len(pls.Tracks)) log.Debug("Imported smart playlist", "name", pls.Name, "lastUpdated", pls.UpdatedAt, "path", pls.Path, "numTracks", pls.SongCount)
} else { } else {
log.Debug("Imported playlist", "name", pls.Name, "lastUpdated", pls.UpdatedAt, "path", pls.Path, "numTracks", len(pls.Tracks)) log.Debug("Imported playlist", "name", pls.Name, "lastUpdated", pls.UpdatedAt, "path", pls.Path, "numTracks", pls.SongCount)
} }
count++ count++
} }